From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 269B3AC02E5 for ; Thu, 24 Aug 2023 00:36:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KFI05vzdYjYgY+VJUHxw23kdn2XGHU8iuyyOKGbRFwg=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692837398; v=1; b=i6eQCitOORu4vbj1XSf3+Pu+pyrFyocntt80qNbJXkbGhF0kE3TxbFEoeMCUUlnIB12LcimC fK9R6ek2v5DNMxvknrSi2nmct5lCuojvh6ANnZvMzT0UXHzkoYr+A3M7MWFCXelaLbr3qrVhWa5 5vjS5nRnV6AkkIXXwOGwkdDw= X-Received: by 127.0.0.2 with SMTP id 5jbvYY7687511x47GYA96DtM; Wed, 23 Aug 2023 17:36:38 -0700 X-Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by mx.groups.io with SMTP id smtpd.web11.280.1692837397877839297 for ; Wed, 23 Aug 2023 17:36:38 -0700 X-Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-48d0e695fa1so244185e0c.1 for ; Wed, 23 Aug 2023 17:36:37 -0700 (PDT) X-Gm-Message-State: 3diLHCfCK4jwOQ3IDO3ZjZwwx7686176AA= X-Google-Smtp-Source: AGHT+IEC9t6AxRZXoluK7Bdh1nBIT03fCudIU/ctTMwrJdq0chvi7yXLTLpXobQlK/mq29U+TbuMA8JN8mICO0i1wqE= X-Received: by 2002:ac5:cace:0:b0:48f:89af:2c65 with SMTP id m14-20020ac5cace000000b0048f89af2c65mr3150659vkl.2.1692837396625; Wed, 23 Aug 2023 17:36:36 -0700 (PDT) MIME-Version: 1.0 References: <2096203168.82564.1692636984521@wsfrf1447.priv.atos.fr> <7F57F8F5-9C13-4DD1-96CE-C3F7A33A1AFF@apple.com> In-Reply-To: From: "Pedro Falcato" Date: Thu, 24 Aug 2023 01:36:25 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH] Use C99 flexible arrays To: devel@edk2.groups.io, rebecca@bsdio.com Cc: afish@apple.com, ehaouas@noos.fr, "Yao, Jiewen" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=i6eQCitO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Aug 23, 2023 at 10:41=E2=80=AFPM Rebecca Cran w= rote: > > With Visual Studio 2019 adding C11 and C17 support as first-class > features, I think we should be safe nowadays to rely on them. But we > should check if older versions that we still support (VS 2015 etc.) > support them too. > > https://devblogs.microsoft.com/cppblog/c11-and-c17-standard-support-arriv= ing-in-msvc/ Don't we explicitly rely on C11 now? Due to your __function__ changes? Anyway, I would recommend Elyes to break this change up into a patch set with per-package patches. This way maintainers could easily review and test the changes. The way it is right now isn't very reviewable nor testable. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107990): https://edk2.groups.io/g/devel/message/107990 Mute This Topic: https://groups.io/mt/100861513/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-