From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mx.groups.io with SMTP id smtpd.web10.103138.1674829663184014075 for ; Fri, 27 Jan 2023 06:28:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TxojC2y3; spf=pass (domain: gmail.com, ip: 209.85.214.176, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f176.google.com with SMTP id d3so5064783plr.10 for ; Fri, 27 Jan 2023 06:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GsCi1RKka0hGl36pQBidxGm59RmSicxm9mf4cW40BGo=; b=TxojC2y34QyjmsjaRMOXVUObyT9CijI4vATdTbZf2bTGG4deSGy8g3YS2sbPEsVNqn Xtwtc1PRLvzSNZcn7wvhwva5BjGc7AXfL91Pl3SeoUOVe02cZvRED01qF4uM7nvM/Y8e Zt9Q2Q8aT/9ixhGo3oD6LNoqu53/45H6HjLNovsRYAdBiqphRJ5JHg2EvHsGEBPpAr10 xOoVyd567KqeWxujGUKTMv+DRK0RYrFCFnIA2QGsXkpDG3DdCTKjyHiD+GWoBsb2vkEt GxHLMx0GrjilNsXZVrk2xrg077OJbe/btaSm3VaZrf//n0kTYvkWlKx3aVy46u8PEftm qpPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GsCi1RKka0hGl36pQBidxGm59RmSicxm9mf4cW40BGo=; b=yoOOhvfschuCUZu6F9kmZBzCsyUBxe1p0v8kj3lehOQHON5IzC/vpsS61A5WDORjCM n+yAs5+3xM6DMhqy9wX4u4hTdCn7fTooP1Uv1L69+HcIyMRc2564zY+hpuEKm8b2L94s EhUhqhpXNJCD72JFABL8f/7od3VL6M32BB7uzUYtKwRX/QMrSWk5eoQNih/SklOXQGKj riAu+BPfZ/VDMyDp5tRuyyzMaIpxwcMJPYWFzOoTBlTbzoW9N2UQSmDihBdIl0aTlu5M 2BGYWOAHj2dGgYkWrTdDR/jr6nw9wxZVNmZ7crqq+gl8IQwX+AQWmSUEZIMyOHzOi+l1 dDBw== X-Gm-Message-State: AFqh2komLLKAAVH9WV5H6MUHpLLYAgKBrXUHpYlLbmlea6c/+ftDwtrX kjwQvIDxU4a0ZpMjl/jkAAnidV5YkMQ6nnp83t0= X-Google-Smtp-Source: AMrXdXsBVb7w6nIqI/qlLRr2auuLiFwxFtj/pGJg+WV1qYc2El6pur6UF2sDXJwSBkp/w1lVUWGsjrggZtNni+tJZcA= X-Received: by 2002:a17:90a:1a03:b0:228:7eed:e756 with SMTP id 3-20020a17090a1a0300b002287eede756mr6460536pjk.166.1674829692128; Fri, 27 Jan 2023 06:28:12 -0800 (PST) MIME-Version: 1.0 References: <20230127092945.94389-1-savvamtr@gmail.com> <20230127092945.94389-10-savvamtr@gmail.com> In-Reply-To: <20230127092945.94389-10-savvamtr@gmail.com> From: "Pedro Falcato" Date: Fri, 27 Jan 2023 14:28:00 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH v3 09/11] Ext4Pkg: Add missing exit Status in Ext4OpenDirent To: Savva Mitrofanov Cc: devel@edk2.groups.io, =?UTF-8?Q?Marvin_H=C3=A4user?= , Vitaly Cheptsov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 27, 2023 at 9:29 AM Savva Mitrofanov wrote= : > > Missing EFI_OUT_OF_RESOURCES exit status on failed Ext4CreateDentry > leads to NULL-pointer dereference in Ext4GetFileInfo (passing NULL > buffer in Ext4ReadDir) > > Cc: Marvin H=C3=A4user > Cc: Pedro Falcato > Cc: Vitaly Cheptsov > Fixes: 21b1853880d5 ("Ext4Pkg: Add a directory entry tree.") > Signed-off-by: Savva Mitrofanov > --- > Features/Ext4Pkg/Ext4Dxe/Directory.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ext4= Dxe/Directory.c > index 2e9a58a7e329..0753a20b5377 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c > @@ -267,7 +267,8 @@ Ext4OpenDirent ( > } else { > File->Dentry =3D Ext4CreateDentry (FileName, Directory->Dentry); > > - if (!File->Dentry) { > + if (File->Dentry =3D=3D NULL) { > + Status =3D EFI_OUT_OF_RESOURCES; > goto Error; > } > } > -- > 2.39.0 > Reviewed-by: Pedro Falcato --=20 Pedro