From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
Oliver Smith-Denny <osde@linux.microsoft.com>,
"Pop, Aaron" <aaronpop@microsoft.com>
Subject: Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names
Date: Tue, 6 Jun 2023 22:01:52 +0100 [thread overview]
Message-ID: <CAKbZUD12B0t-ibRi7+M62YpRFeAxi-AwL=1nHoKUQpQ6bDP15w@mail.gmail.com> (raw)
In-Reply-To: <CO1PR11MB49292AC80B75115089A4DC8DD252A@CO1PR11MB4929.namprd11.prod.outlook.com>
On Tue, Jun 6, 2023 at 6:57 PM Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> Hi Pedro,
>
> Based on this info, would you prefer we use xor_ style instead of Xor?
>
> I can update the PR with that change.
>
> Mike
Hi Mike,
Sorry, I didn't know you were waiting for my input. Yes, I would
prefer xor_ style, but I'll leave it up to you.
You can add my
Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>
For the whole series, regardless of the style choice here.
--
Pedro
next prev parent reply other threads:[~2023-06-06 21:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 18:53 [Patch v2 0/3] Address C++ keyword collisions Michael D Kinney
2023-05-30 18:53 ` [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names Michael D Kinney
2023-05-31 18:17 ` Pedro Falcato
2023-05-31 18:41 ` Michael D Kinney
2023-06-01 15:01 ` Michael D Kinney
2023-06-06 17:56 ` Michael D Kinney
2023-06-06 21:01 ` Pedro Falcato [this message]
2024-02-27 23:46 ` [edk2-devel] " Michael D Kinney
2024-02-27 23:55 ` Pedro Falcato
2024-02-28 0:33 ` Michael D Kinney
2023-05-30 18:53 ` [Patch v2 2/3] SecurityPkg/Library/TpmCommandLib: Change xor to Xor Michael D Kinney
2023-05-31 2:38 ` [edk2-devel] [PATCH] ShellPkg\SmbiosView: SmBiosView does not print correct Slot ID information asperber
2023-05-30 18:53 ` [Patch v2 3/3] MdePkg/Include/IndustryStandard: Address C++ keyword collisions Michael D Kinney
2023-05-31 0:05 ` [edk2-devel] [Patch v2 0/3] " Yao, Jiewen
2023-05-31 17:46 ` Oliver Smith-Denny
2023-06-01 7:30 ` 回复: [edk2-devel] " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKbZUD12B0t-ibRi7+M62YpRFeAxi-AwL=1nHoKUQpQ6bDP15w@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox