From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by mx.groups.io with SMTP id smtpd.web10.589.1686085324442143472 for ; Tue, 06 Jun 2023 14:02:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=EJNznsxk; spf=pass (domain: gmail.com, ip: 209.85.222.53, mailfrom: pedro.falcato@gmail.com) Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7868d32ace2so2551088241.3 for ; Tue, 06 Jun 2023 14:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686085323; x=1688677323; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y9f79i+P8wUT/il45iZ30moEdLA+ryavk1eiyrJ7z3s=; b=EJNznsxklIOoLV+eCwQ5Ool+pS0Z2fTwB2oxhpYFdqIhU2QkzYwMrzHIXMw5nHvANV g/6UiCqZnzVJ7RMIrZWlrv4iIv/IIPvDkcU3MGsCnzHmOZSqUf8CmX1W0ijTDCs2XdDy lj9POeiXe03tdX36gffDoaIb3Y+G8PlH0/I3Db8ktKevQ4aBHrUP88au31HB/I/0h5Yw Zd7E1QqM94HjUq2E3S0hLibOZg6jVmCaL5e1yfeq84F2lHcsxQYsIucHuHJxAHKLnGOp zAGNylrbJRalc0SQ1eesOBzrsamdbPCAGWxpxsiK1eHL7enhXwyPe7faFYZywW04U8Ee wMbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686085323; x=1688677323; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y9f79i+P8wUT/il45iZ30moEdLA+ryavk1eiyrJ7z3s=; b=g6Y7k0eCJwElvFh5ZjFUaF6HUSim6C/hNuapbBlO7XV5+Z1Xk5IBLOpnpsclHhiVKx evM2wsXoNNBfVBLGxrNA0jcfqg2nUahTpTRwVvV3+bvYxyl8RjHAphTY40A1FkEqQv2e 2xjiVtiulAA0oC9fica2mBuCbrJyPLn48Ue1zO3XcWMgpzQOTs1EILNFvlhmifN/U9N3 rYDJpVbbYaLCOnwmQ/7/TQ1mBwTacyPeet7MSphop5TnbGvf/DgOKYPX4/Q3sg/ZxEjL edOGIv7UrMcFYAn5U5hovieNTWAScmyY8Ej+KtED18EC1q+7i5OjIarZlwHbIApeiz4V bHyA== X-Gm-Message-State: AC+VfDxBPYJRFqDcsqkY63b05CKDmwFCPNCndWh2uHUTU450ClcW3/jA TKONnrh7dIT/zYyjqxqN8CGwCxc32qjj4LpubammliHk X-Google-Smtp-Source: ACHHUZ7+JCWdLhj8XqP1iC1O7mzbWQ/bq9VjDx4QnecD/zMIXWNqnCwrIuCUE38Ps3xh/J8oWSKz9zLTWuYSD2LmjoE= X-Received: by 2002:a05:6102:3a55:b0:436:57fc:ffa4 with SMTP id c21-20020a0561023a5500b0043657fcffa4mr448453vsu.16.1686085323216; Tue, 06 Jun 2023 14:02:03 -0700 (PDT) MIME-Version: 1.0 References: <20230530185322.70-1-michael.d.kinney@intel.com> <20230530185322.70-2-michael.d.kinney@intel.com> In-Reply-To: From: "Pedro Falcato" Date: Tue, 6 Jun 2023 22:01:52 +0100 Message-ID: Subject: Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "Gao, Liming" , "Liu, Zhiguang" , Oliver Smith-Denny , "Pop, Aaron" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 6, 2023 at 6:57=E2=80=AFPM Michael D Kinney wrote: > > Hi Pedro, > > Based on this info, would you prefer we use xor_ style instead of Xor? > > I can update the PR with that change. > > Mike Hi Mike, Sorry, I didn't know you were waiting for my input. Yes, I would prefer xor_ style, but I'll leave it up to you. You can add my Reviewed-by: Pedro Falcato For the whole series, regardless of the style choice here. --=20 Pedro