From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: devel@edk2.groups.io, mike.maslenkin@gmail.com
Cc: Abner Chang <abner.chang@amd.com>,
Nickle Wang <nicklew@nvidia.com>,
Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses
Date: Wed, 13 Dec 2023 13:28:10 +0000 [thread overview]
Message-ID: <CAKbZUD15C__wA0OjmUMDjfYaszRaEQg3sPTqgXHZUpbATKoUrg@mail.gmail.com> (raw)
In-Reply-To: <20231207132419.6107-1-mike.maslenkin@gmail.com>
On Thu, Dec 7, 2023 at 1:24 PM Mike Maslenkin <mike.maslenkin@gmail.com> wrote:
> [...]
> + DiscoveredInstance->Information.Location = (CHAR16 *)AllocatePool (AllocSize);
Forgot to mention: don't cast void *! It's completely unneeded in C
and may hide real problems (implicit declarations); it also clutters
code.
--
Pedro
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112473): https://edk2.groups.io/g/devel/message/112473
Mute This Topic: https://groups.io/mt/103033764/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-12-13 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 13:24 [edk2-devel] [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses Mike Maslenkin
2023-12-13 11:09 ` Chang, Abner via groups.io
2023-12-13 13:15 ` Pedro Falcato
2023-12-13 13:35 ` Mike Maslenkin
2023-12-13 13:38 ` Chang, Abner via groups.io
2023-12-15 0:17 ` Chang, Abner via groups.io
2023-12-13 13:28 ` Pedro Falcato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKbZUD15C__wA0OjmUMDjfYaszRaEQg3sPTqgXHZUpbATKoUrg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox