From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 456E19415F7 for ; Wed, 13 Dec 2023 13:28:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=V2xmJqTt+eKM4G7AntxeUS/FZlwU6cI0Qs8L9z6ZdCA=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702474102; v=1; b=OMfWJUWUbweb9FfOnHqJwlCYeBwENvXfUNc/8o9IbZCm98J627JTIxNsdwMxIuUIBiPc4NpJ TphYiPf8l5E8YVrlHbDiuJ3WghSIHaTz8Y0JRpDG1pk/VyfnZo+Sw1ko5DuclkwUol8UM+Yk/Jm 9tDx2GIfJbJfqImUES7UCtiU= X-Received: by 127.0.0.2 with SMTP id qxZdYY7687511xF5V2RmQP9a; Wed, 13 Dec 2023 05:28:22 -0800 X-Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by mx.groups.io with SMTP id smtpd.web11.35569.1702474102306402276 for ; Wed, 13 Dec 2023 05:28:22 -0800 X-Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6d7fa93afe9so5127169a34.2 for ; Wed, 13 Dec 2023 05:28:22 -0800 (PST) X-Gm-Message-State: 2m6u9ccLYRxntpd6yELKKHzzx7686176AA= X-Google-Smtp-Source: AGHT+IFV1Pe6vF0pSJm48/xdp9Hs5JHlxSV/MNBStXJv1fyVLiokumC07kYdjReD2oFW+MWwKHdT3Anlufqd5l8Y2lM= X-Received: by 2002:a05:6830:134f:b0:6da:3409:fd90 with SMTP id r15-20020a056830134f00b006da3409fd90mr706840otq.62.1702474101255; Wed, 13 Dec 2023 05:28:21 -0800 (PST) MIME-Version: 1.0 References: <20231207132419.6107-1-mike.maslenkin@gmail.com> In-Reply-To: <20231207132419.6107-1-mike.maslenkin@gmail.com> From: "Pedro Falcato" Date: Wed, 13 Dec 2023 13:28:10 +0000 Message-ID: Subject: Re: [edk2-devel] [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses To: devel@edk2.groups.io, mike.maslenkin@gmail.com Cc: Abner Chang , Nickle Wang , Igor Kulchytskyy Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OMfWJUWU; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Dec 7, 2023 at 1:24=E2=80=AFPM Mike Maslenkin wrote: > [...] > + DiscoveredInstance->Information.Location =3D (CHAR16 *)AllocateP= ool (AllocSize); Forgot to mention: don't cast void *! It's completely unneeded in C and may hide real problems (implicit declarations); it also clutters code. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112473): https://edk2.groups.io/g/devel/message/112473 Mute This Topic: https://groups.io/mt/103033764/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-