From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D6FACD8042B for ; Thu, 2 Nov 2023 12:47:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QIkKw+c2IFydkrGPI9CLmmElXbhisH1sBs5yEXGRl5w=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698929262; v=1; b=SbVjCQLHKMeoiGVcc2UoIoPvKSqV74Dojm3sCPoDb0TSSwNRbDEKUSbIJijl8GOXci/moLWQ S7r6XszJkuckB2RVN53LdlwVHsCnKJE/wIG9ekSFOQQU7nt/UYKL/M55v6Xqa3QfDL8HG1c1PJ4 V/3yJY1YksOKYBvOEGxWd2gk= X-Received: by 127.0.0.2 with SMTP id zoY7YY7687511xfQAslC54xL; Thu, 02 Nov 2023 05:47:42 -0700 X-Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by mx.groups.io with SMTP id smtpd.web11.29769.1698929262009408218 for ; Thu, 02 Nov 2023 05:47:42 -0700 X-Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-7b9dc92881eso390533241.2 for ; Thu, 02 Nov 2023 05:47:41 -0700 (PDT) X-Gm-Message-State: HfztxjrX3r1cVcwhQzmiVkmQx7686176AA= X-Google-Smtp-Source: AGHT+IFXBvLx9xn8LK7QEW92XrF7uLBVJlsedkxAsnmQ7VK85RVgAwNF2GeOXqT3GYlrms0uZ6aNodNU11u8wesccyU= X-Received: by 2002:a67:c087:0:b0:457:c57c:ef13 with SMTP id x7-20020a67c087000000b00457c57cef13mr18521930vsi.31.1698929260421; Thu, 02 Nov 2023 05:47:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Thu, 2 Nov 2023 12:47:29 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP To: Jake Garver Cc: Ard Biesheuvel , "devel@edk2.groups.io" , "rebecca@bsdio.com" , "gaoliming@byosoft.com.cn" , "bob.c.feng@intel.com" , "yuwei.chen@intel.com" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SbVjCQLH; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Thu, Nov 2, 2023 at 11:47=E2=80=AFAM Jake Garver wrote= : > > Ard, Pedro, > > How would you like to proceed here? > > Do nothing. Treat it as a toolchain bug and not attempt a work-around. = Practically speaking, this means the Ubuntu20 container at https://github.c= om/tianocore/containers cannot be updated to the latest GCC 10.x (10.5). W= e can pin it to 10.3 or EOL it, migrating to Ubuntu22. > Rework the patch as a work-around. > ??? Something I missed. > > Note in option 1, I'm assuming that other versions of GCC, e.g. 12.x used= in Ubuntu22, don't eventually inherit this regression. But we can always r= evisit the work-around if we determine that to be the case. I'm starting U= buntu22 testing now, so I may have an answer soon. I think the correct way to proceed here is to find out what exactly is causing this. Once we find out, we can edit the patch's commit message and push (or drop the patch, depending on what the problem is). The patch itself looks fine to me (And I already Rb'd it I think), and it should be harmless to apply it, even for toolchains that do not share this mysterious problem. Also, FWIW: GCC 10.5 is a stable release, so I find it hard to believe that something actually broke between 10.4 and 10.5. One more thing: What happens if you build without LTO? --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110525): https://edk2.groups.io/g/devel/message/110525 Mute This Topic: https://groups.io/mt/102202314/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-