From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by mx.groups.io with SMTP id smtpd.web08.1378.1643823113887466780 for ; Wed, 02 Feb 2022 09:31:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DXkTnVNZ; spf=pass (domain: gmail.com, ip: 209.85.222.42, mailfrom: pedro.falcato@gmail.com) Received: by mail-ua1-f42.google.com with SMTP id p26so434345uaa.11 for ; Wed, 02 Feb 2022 09:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2ts4v7JAu9fs2qg8fzCK2KDm1xCr3Hha08zXh+bhn9E=; b=DXkTnVNZWJ8VcGIE7m0D6Y5s0NASw7Pw776lByHhfBHMEbgQ5xSQ+3qqncAJi/JI6k 1bdh55oOGoH1qu3FGWsijEckqBaw9j9WCv2P6Gqps+NZgmxsDIc6yR8G2iP1XJmPrHzA LcFaWES1D5sZidV/dIVXtHv2gs04rNo3BacTuylb45h4Zvk9oF5wpc/kGm3ktk7VJnXk THwuTXU0Ud3xaKUgoHdss3MKj2znwTwuytVV1QfHvRiQjY08YrcgHsBVYFQycZwQccgo FYr0q4hEotE3P3qp7tfQ5/7CfN8L1Qolcq1UOR6+82QG8K8K4ySemTDaenbfTI4rMzpn oqzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2ts4v7JAu9fs2qg8fzCK2KDm1xCr3Hha08zXh+bhn9E=; b=TXV5zghTU27SpJyPorLHcaTqT+ho0Q6LJx/JwWGWbzIMmohcHSPg2m0NeJtl//NURc e9PKQ27qfyHv5cgi/Jjk7ymAcvz/C+HSKPt24xRbF7x0ucYEODI2H2HAtPQbGdN0AOr6 SJ5sRibn3M26nz+7YJc9ct0zoX2KogmY9UnJhmTj7cjQh5gOJ55Nxx6p6Whbq8hKI0d+ FCAUy2A/4cIPTP40LgVqbT1+kLNjM0PgAq6cnQBJstycsABnYPYFpPxe+IKI5EQzTHIK LPOEX01qr2u2p6mVSfedIQ6YOzRhZemeRJGp+GyVx2QBNWTQT7YL0FQuNhe0vsJon64H qRkw== X-Gm-Message-State: AOAM531gvyfd7OFZ4BCYIOo2+ElrAPSIQZqyVccLMWq8C7sdREIk5YYb caFn9M3phzbxjH8dqioKLb0NCPipl8JUg9SJxxc= X-Google-Smtp-Source: ABdhPJwIrU/4JAqJqGucKSTGSzXbQYK80c681Gok9e2fRJKfwL6HBeqzTbfnybi3ZL6h9cX2pgxOt2jlSHLHe4kdk8U= X-Received: by 2002:a67:6102:: with SMTP id v2mr11929718vsb.15.1643823112936; Wed, 02 Feb 2022 09:31:52 -0800 (PST) MIME-Version: 1.0 References: <5d55ef7504d9c460d7fcdda26f890df8feeb8972.1643119699.git.jake@nvidia.com> In-Reply-To: <5d55ef7504d9c460d7fcdda26f890df8feeb8972.1643119699.git.jake@nvidia.com> From: "Pedro Falcato" Date: Wed, 2 Feb 2022 17:31:41 +0000 Message-ID: Subject: Re: [PATCH] Features/Ext4Pkg: Modularize Ext4 DSC/FDF files To: Jake Garver Cc: edk2-devel-groups-io , Jeff Brasen , ashishsingha@nvidia.com Content-Type: multipart/alternative; boundary="000000000000b8625f05d70c6451" --000000000000b8625f05d70c6451 Content-Type: text/plain; charset="UTF-8" Jake, Sorry for the delay. Pushed as 8f41641a6f29e2ae3ffe2ed44a026db7993ed94f. On Tue, Jan 25, 2022 at 2:13 PM Jake Garver wrote: > This change modularizes the Ext4 DSC/FDF files following the model used > in edk2/NetworkPkg. > > A platform DSC can include Ext4 using "!include Features/Ext4.dsc.inc". > Ext.dsc.inc includes all the required information to enable Ext4 > features. Similarly, "!include Features/Ext4.fdf.inc" would be used in > the platform FDF. > > The Ext4 feature is enabled by default, but could be disabled at build > time using: > > BLD_*_EXT4_ENABLE=FALSE > > Signed-off-by: Jake Garver > --- > Features/Ext4Pkg/Ext4.dsc.inc | 16 ++++++++++++++++ > Features/Ext4Pkg/Ext4.fdf.inc | 11 +++++++++++ > Features/Ext4Pkg/Ext4Components.dsc.inc | 14 ++++++++++++++ > Features/Ext4Pkg/Ext4Defines.dsc.inc | 14 ++++++++++++++ > Features/Ext4Pkg/Ext4Libs.dsc.inc | 11 +++++++++++ > 5 files changed, 66 insertions(+) > create mode 100644 Features/Ext4Pkg/Ext4.dsc.inc > create mode 100644 Features/Ext4Pkg/Ext4.fdf.inc > create mode 100644 Features/Ext4Pkg/Ext4Components.dsc.inc > create mode 100644 Features/Ext4Pkg/Ext4Defines.dsc.inc > create mode 100644 Features/Ext4Pkg/Ext4Libs.dsc.inc > > diff --git a/Features/Ext4Pkg/Ext4.dsc.inc b/Features/Ext4Pkg/Ext4.dsc.inc > new file mode 100644 > index 0000000000..b560b9acbb > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4.dsc.inc > @@ -0,0 +1,16 @@ > +## @file > +# Ext4 DSC include file for Platform DSC > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > +!include Features/Ext4Pkg/Ext4Defines.dsc.inc > + > +[LibraryClasses] > +!include Features/Ext4Pkg/Ext4Libs.dsc.inc > + > +[Components.common] > +!include Features/Ext4Pkg/Ext4Components.dsc.inc > diff --git a/Features/Ext4Pkg/Ext4.fdf.inc b/Features/Ext4Pkg/Ext4.fdf.inc > new file mode 100644 > index 0000000000..fb36070860 > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4.fdf.inc > @@ -0,0 +1,11 @@ > +## @file > +# Ext4 FDF include file for All Architectures. > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!if $(EXT4_ENABLE) == TRUE > + INF Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf > +!endif > diff --git a/Features/Ext4Pkg/Ext4Components.dsc.inc > b/Features/Ext4Pkg/Ext4Components.dsc.inc > new file mode 100644 > index 0000000000..34401272a0 > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4Components.dsc.inc > @@ -0,0 +1,14 @@ > +## @file > +# Ext4 DSC include file for [Components] section of all Architectures. > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!if $(EXT4_ENABLE) == TRUE > + Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf { > + > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000007 > + } > +!endif > diff --git a/Features/Ext4Pkg/Ext4Defines.dsc.inc > b/Features/Ext4Pkg/Ext4Defines.dsc.inc > new file mode 100644 > index 0000000000..b02eac59cf > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4Defines.dsc.inc > @@ -0,0 +1,14 @@ > +## @file > +# Ext4 DSC include file for [Defines] section of all Architectures. > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!ifndef EXT4_ENABLE > + # > + # This flag is to enable or disable the ext4 feature. > + # > + DEFINE EXT4_ENABLE = TRUE > +!endif > diff --git a/Features/Ext4Pkg/Ext4Libs.dsc.inc > b/Features/Ext4Pkg/Ext4Libs.dsc.inc > new file mode 100644 > index 0000000000..078183e0cc > --- /dev/null > +++ b/Features/Ext4Pkg/Ext4Libs.dsc.inc > @@ -0,0 +1,11 @@ > +## @file > +# Ext4 DSC include file for [LibraryClasses] section of all Architectures. > +# > +# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & > AFFILIATES. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +!if $(EXT4_ENABLE) == TRUE > + BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > +!endif > -- > 2.17.1 > > -- Pedro Falcato --000000000000b8625f05d70c6451 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Jake,

Sorry for the delay.

Pushed as 8f41641a6f29e2ae3ffe2ed44a026db7= 993ed94f.

On Tue, Jan 25, 2022 at 2:13 PM Jake Garver &= lt;jake@nvidia.com> wrote:
This change modularize= s the Ext4 DSC/FDF files following the model used
in edk2/NetworkPkg.

A platform DSC can include Ext4 using "!include Features/Ext4.dsc.inc&= quot;.
Ext.dsc.inc includes all the required information to enable Ext4
features.=C2=A0 Similarly, "!include Features/Ext4.fdf.inc" would= be used in
the platform FDF.

The Ext4 feature is enabled by default, but could be disabled at build
time using:

=C2=A0 =C2=A0 BLD_*_EXT4_ENABLE=3DFALSE

Signed-off-by: Jake Garver <jake@nvidia.com>
---
=C2=A0Features/Ext4Pkg/Ext4.dsc.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0| 16 ++++++++++++++++
=C2=A0Features/Ext4Pkg/Ext4.fdf.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0| 11 +++++++++++
=C2=A0Features/Ext4Pkg/Ext4Components.dsc.inc | 14 ++++++++++++++
=C2=A0Features/Ext4Pkg/Ext4Defines.dsc.inc=C2=A0 =C2=A0 | 14 ++++++++++++++=
=C2=A0Features/Ext4Pkg/Ext4Libs.dsc.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0| 11 ++++= +++++++
=C2=A05 files changed, 66 insertions(+)
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4.dsc.inc
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4.fdf.inc
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Components.dsc.inc
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Defines.dsc.inc
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Libs.dsc.inc

diff --git a/Features/Ext4Pkg/Ext4.dsc.inc b/Features/Ext4Pkg/Ext4.dsc.inc<= br> new file mode 100644
index 0000000000..b560b9acbb
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4.dsc.inc
@@ -0,0 +1,16 @@
+## @file
+# Ext4 DSC include file for Platform DSC
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+!include Features/Ext4Pkg/Ext4Defines.dsc.inc
+
+[LibraryClasses]
+!include Features/Ext4Pkg/Ext4Libs.dsc.inc
+
+[Components.common]
+!include Features/Ext4Pkg/Ext4Components.dsc.inc
diff --git a/Features/Ext4Pkg/Ext4.fdf.inc b/Features/Ext4Pkg/Ext4.fdf.inc<= br> new file mode 100644
index 0000000000..fb36070860
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4.fdf.inc
@@ -0,0 +1,11 @@
+## @file
+# Ext4 FDF include file for All Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!if $(EXT4_ENABLE) =3D=3D TRUE
+=C2=A0 INF Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf
+!endif
diff --git a/Features/Ext4Pkg/Ext4Components.dsc.inc b/Features/Ext4Pkg/Ext= 4Components.dsc.inc
new file mode 100644
index 0000000000..34401272a0
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4Components.dsc.inc
@@ -0,0 +1,14 @@
+## @file
+# Ext4 DSC include file for [Components] section of all Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!if $(EXT4_ENABLE) =3D=3D TRUE
+=C2=A0 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf {
+=C2=A0 =C2=A0 <PcdsFixedAtBuild>
+=C2=A0 =C2=A0 =C2=A0 gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80= 000007
+=C2=A0 }
+!endif
diff --git a/Features/Ext4Pkg/Ext4Defines.dsc.inc b/Features/Ext4Pkg/Ext4De= fines.dsc.inc
new file mode 100644
index 0000000000..b02eac59cf
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4Defines.dsc.inc
@@ -0,0 +1,14 @@
+## @file
+# Ext4 DSC include file for [Defines] section of all Architectures.
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!ifndef EXT4_ENABLE
+=C2=A0 #
+=C2=A0 # This flag is to enable or disable the ext4 feature.
+=C2=A0 #
+=C2=A0 DEFINE EXT4_ENABLE =3D TRUE
+!endif
diff --git a/Features/Ext4Pkg/Ext4Libs.dsc.inc b/Features/Ext4Pkg/Ext4Libs.= dsc.inc
new file mode 100644
index 0000000000..078183e0cc
--- /dev/null
+++ b/Features/Ext4Pkg/Ext4Libs.dsc.inc
@@ -0,0 +1,11 @@
+## @file
+# Ext4 DSC include file for [LibraryClasses] section of all Architectures.=
+#
+# SPDX-FileCopyrightText: Copyright (c) 2022 NVIDIA CORPORATION & AFFI= LIATES. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+!if $(EXT4_ENABLE) =3D=3D TRUE
+=C2=A0 BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.= inf
+!endif
--
2.17.1



--
Pedro Falcato
--000000000000b8625f05d70c6451--