From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175])
 by mx.groups.io with SMTP id smtpd.web11.164.1682532471528237253
 for <devel@edk2.groups.io>;
 Wed, 26 Apr 2023 11:07:51 -0700
Authentication-Results: mx.groups.io;
 dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=CfXZh1Ba;
 spf=pass (domain: gmail.com, ip: 209.85.215.175, mailfrom: pedro.falcato@gmail.com)
Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-51b4ef5378bso7349029a12.1
        for <devel@edk2.groups.io>; Wed, 26 Apr 2023 11:07:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20221208; t=1682532470; x=1685124470;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=GIKTag+8UlnqI4h+2D1gTDbQc8Mrz3xwH30E8/zJBZ8=;
        b=CfXZh1BagJqnCdoSEORCJwvRd8Jf7XVUnpJ/d6ZL7ZStOYW13IP1x3u4Mh0opHdEtz
         EmujLUc2RzfmwfAl6RBfVkE1zUmq/YNeTbs4TGpIpKWWAfJj7FmZytfj9zd7ltYuwOH3
         t/dYsQjG4QjC6+lnZsqN0XJ5jZ3WdyJo4L/AsPJqMZYyT+BOHCTXuz/4jVUVndNdoPE0
         QP63GoxyEI4rKbjkH7pZdN07A32jXqBBLsBSI2fRvJRvtK+qnfR7Weng9kCI7kcnqICf
         LiMKi4BboOSxSQlbuQ6LFcMyscBJNFgmzzr3/Wii4e+4cWxfEs8lpbrd9p/nPhgv8RfO
         +EDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1682532470; x=1685124470;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=GIKTag+8UlnqI4h+2D1gTDbQc8Mrz3xwH30E8/zJBZ8=;
        b=YljDkeudX4JYqp9nquPlhzyZezowqo4SITBEHZAet3UxT445WjWh9uA9N2bAL6T07Y
         Ghippclky0nN2ngtGl27WsH0DaCvQuivJylMUMOdi9R0SLQvvtH1lkNahGynJufvNP1K
         PeUtuL89CQyUPD6vvVxd8wt0wxBHJfcLZ4BDrM6nwq7gSsbwpLe6bdJVs02PZ2eZPqTy
         xBfGA8G6sF76QqggehdgY2+19t2X1idlzywYbslc0EdLj7kfi9Ze9b3r4wP7Tw1j0vcK
         WxCZr33CLL4U9PAltuUlvXO1V7xR7Bz3GB5WU8A3+PaAZW1D2JWmW5R5DfEFkR+W1cX3
         TLjw==
X-Gm-Message-State: AAQBX9cAtwVnTvZmX5H3hDDlREIzommaeivcOtsSItzjaSOf4sOfYIjL
	AuYtpzoalfi392tzGE4ABO4qKKvtAHF31O3L+p3aSPIZ91flPQ==
X-Google-Smtp-Source: AKy350ak9io59A8keVEeRGHrBbN+ag9h+W0yy3qUYBrhy+CTyzSHFRZKCtT+qdijhFVnll6bIflIw+k4OFCXjzQAGPU=
X-Received: by 2002:a17:90a:ac18:b0:249:6086:a301 with SMTP id
 o24-20020a17090aac1800b002496086a301mr21505096pjq.27.1682532470495; Wed, 26
 Apr 2023 11:07:50 -0700 (PDT)
MIME-Version: 1.0
References: <7edb8c7baae2fc58034a62f50f5f4000fb5bd102.1682442501.git.benjamin.doron00@gmail.com>
 <bf649962c3bbca8da5f23192433eafe3fbb9e9f3.1682442501.git.benjamin.doron00@gmail.com>
In-Reply-To: <bf649962c3bbca8da5f23192433eafe3fbb9e9f3.1682442501.git.benjamin.doron00@gmail.com>
From: "Pedro Falcato" <pedro.falcato@gmail.com>
Date: Wed, 26 Apr 2023 19:07:39 +0100
Message-ID: <CAKbZUD1B5QmuRwa5SJoTijca9gjKVLGOrTmETJ91XWz4S9EnCA@mail.gmail.com>
Subject: Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support
To: devel@edk2.groups.io, benjamin.doron00@gmail.com
Cc: Guo Dong <guo.dong@intel.com>, Ray Ni <ray.ni@intel.com>, 
	Sean Rhodes <sean@starlabs.systems>, James Lu <james.lu@intel.com>, Gua Guo <gua.guo@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 25, 2023 at 6:09=E2=80=AFPM Benjamin Doron
<benjamin.doron00@gmail.com> wrote:
>
> From: Benjamin Doron <benjamin.doron@9elements.com>
>
> Uses CPU RDRAND support and installs the EfiRngProtocol.
> The protocol may be used by iPXE or the Linux kernel to gather entropy.
>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sean Rhodes <sean@starlabs.systems>
> Cc: James Lu <james.lu@intel.com>
> Cc: Gua Guo <gua.guo@intel.com>
> Signed-off-by: Benjamin Doron <benjamin.doron@9elements.com>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.dsc | 3 +++
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 3 +++
>  2 files changed, 6 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPaylo=
adPkg.dsc
> index 1e803ba01567..486af2396731 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -634,6 +634,9 @@
>    MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
>  !endif
>    UefiCpuPkg/CpuDxe/CpuDxe.inf
> +!if $(CPU_RNG_ENABLE) =3D=3D TRUE
> +  SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf
> +!endif
>    MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
>  !if $(BOOTSPLASH_IMAGE)
>    MdeModulePkg/Logo/LogoDxe.inf
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPaylo=
adPkg.fdf
> index f8c2aa8c4a02..53add65a6a40 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -157,6 +157,9 @@ INF CryptoPkg/Driver/CryptoDxe.inf
>  INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
>  !endif
>  INF UefiCpuPkg/CpuDxe/CpuDxe.inf
> +!if $(CPU_RNG_ENABLE) =3D=3D TRUE
> +INF SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf

Friendly reminder: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4163

Which ended up never getting merged. Do check if this affects you
(particularly as coreboot is used by a lot of older devices).

--=20
Pedro