From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by mx.groups.io with SMTP id smtpd.web09.496.1637105421079350995 for ; Tue, 16 Nov 2021 15:30:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=nK2nBnWq; spf=pass (domain: gmail.com, ip: 209.85.222.47, mailfrom: pedro.falcato@gmail.com) Received: by mail-ua1-f47.google.com with SMTP id v3so1744729uam.10 for ; Tue, 16 Nov 2021 15:30:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vDIc7BwLLdwP4c/jnpCLt9BuEY1sLeDeWGjtFee1lCA=; b=nK2nBnWq6gHgfSbrhLJ9nJ48TpcYhhnkPiuOyLEc0QOWMuwj7bSWijyecCg30306YT iEUqtPO1ayQ2CmumXV74cMcId2GFTlBzyRzaLx4pOMEb8fepkn5PrFMDadGhKTr5shL0 ualbd1d8xzUspB2hj4SuzlVzXyyCGTRUIP+LkX/TFAe2CRAciN2XoclbKk0L2VU4gg7D mk4MUVM0tZouzWN8vbO94c1Su3RpnMSTsma84zraFNkyyygDZQr2exJLn6/Ii1r1UXYU zS6fEGDRlm7YeA23FSvQnit1x3Fu9EiusIP9cO5XBOQgJOK0QR+HfX0/isIB3L8ePGi3 u6eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vDIc7BwLLdwP4c/jnpCLt9BuEY1sLeDeWGjtFee1lCA=; b=P+aTExlYL13Uph+HV43UjzPehktEfEHm6ISNQFUaZ3PJnmNtD5JUbyvY/RQMMbtIu8 ZZLXqOu+XMituG+2AGgL+gg8HrNGH5JC2JtmjK96EOcjQymylLDRD+VwT4maBlqrneTn 78TqGCVAx+O5PGxpJxEc0v3jac6511auUvzXZUzX5byoULQs3seO7PnhpmCssKRL+56z AI868YV1nkHH3LOoDDaN1+L4hF4RT1+z4VvbaHFLVRN137xfOCbc1Z5RWGQ1hZg5mBE4 L+5n9+tpNYLeW7JUfGuQH+yCVQWHtBG6Ixoun8riKpimYnVt6s3SZEPwxhYwbB+96Z9+ A24g== X-Gm-Message-State: AOAM530oyUM0mzvkyIJnPQngdE8WG67nMdAZ6EXaGWV3vDG4IPKik/wI LIYYBm4do1G1jYB4/HnTsWQw9Cacy8cjkSBManGTVZ+A9Ko/7Q== X-Google-Smtp-Source: ABdhPJzyzdx9WGJC7sy5Gcgb1Hu0d1t+8OQz6Dk0vT6/Hk8Har9eoVRp2T+CpHmm4cvkapmhN+EvUPP4AZNLFgqVbpI= X-Received: by 2002:a67:f805:: with SMTP id l5mr61315631vso.17.1637105420145; Tue, 16 Nov 2021 15:30:20 -0800 (PST) MIME-Version: 1.0 References: <42fc968b-0108-da06-42a4-d946f0592072@linux.microsoft.com> <6ef9d0eb-942f-943b-5a01-ca7602d31459@linux.microsoft.com> In-Reply-To: <6ef9d0eb-942f-943b-5a01-ca7602d31459@linux.microsoft.com> From: "Pedro Falcato" Date: Tue, 16 Nov 2021 23:30:06 +0000 Message-ID: Subject: Re: [edk2-devel] Uncrustify configuration file and file/function templates To: Michael Kubacki Cc: edk2-devel-groups-io Content-Type: multipart/alternative; boundary="00000000000007163e05d0f04f09" --00000000000007163e05d0f04f09 Content-Type: text/plain; charset="UTF-8" Yes, I do. Essentially, my changes make it so the function parameters are aligned and there are always two spaces between the parameter's type and name; it also adds spaces between control statements, as you mentioned. "force" instead of "add" for sp_before_sparen is a good idea though. I assume these are good additions to the "upstream" edk2.cfg? On Tue, Nov 16, 2021 at 11:20 PM Michael Kubacki < mikuback@linux.microsoft.com> wrote: > Hi Pedro, > > By "new config", do you mean the config file in the latest branch > https://github.com/makubacki/edk2/blob/uncrustify_poc_5/uncrustify.cfg)? > > The main difference I see from the diff in that gist and poc_5 is that > "align_func_params_gap" and "align_func_params_span" are two instead of > zero. > > The value "force" instead of "add" for "sp_before_sparen" will ensure a > single space is always added between a control statement and the > parenthesis. > > Thanks, > Michael > > On 11/16/2021 6:05 PM, Pedro Falcato wrote: > > Hi, > > > > RE: Uncrustify's configuration > > > > I had made a few changes to the config file, when trying out Uncrustify, > > a few months ago, on Mike Kinney's suggestion. In my experience, the new > > config file reflects the edk2 coding style better. > > > > In particular, it adds spaces between things like 'if' and the > > parenthesis, and better aligns functions' parameters. > > Feel free to check out the diff: > > https://gist.github.com/heatd/5bb048a188726cb8bc9f5b4a844b0ec2 > > . > > There's a bit of diff noise due to it being based on > > https://dev.azure.com/projectmu/_git/Uncrustify?path=/etc/edk2.cfg > > > but > > diffed on > > > https://github.com/makubacki/edk2/blob/uncrustify_poc_2/.uncrustify/edk2.cfg > > < > https://github.com/makubacki/edk2/blob/uncrustify_poc_2/.uncrustify/edk2.cfg > >. > > > > Thanks, > > Pedro > > > > On Tue, Nov 16, 2021 at 7:26 PM Michael Kubacki > > > > wrote: > > > > I think that makes sense. I will look into it further and let you > know > > if there's any downsides found. > > > > On 11/16/2021 2:18 PM, Kinney, Michael D wrote: > > > Could we add this feature to the Uncrustify CI Plugin? > > > > > > Mike > > > > > >> -----Original Message----- > > >> From: Michael Kubacki > > > > >> Sent: Tuesday, November 16, 2021 10:54 AM > > >> To: devel@edk2.groups.io ; Kinney, > > Michael D > > > > >> Subject: Re: [edk2-devel] Uncrustify configuration file and > > file/function templates > > >> > > >> I would prefer to have a single version of the file if possible > to > > >> reduce synchronization issues across the two copies. > > >> > > >> It seems that a CI plugin to read the contents of the template > > files and > > >> search incoming code for that text wouldn't be too difficult to > > add as a > > >> new plugin. > > >> > > >> Thanks, > > >> Michael > > >> > > >> On 11/16/2021 1:31 PM, Michael D Kinney wrote: > > >>> Hi Michael, > > >>> > > >>> Should we have 2 versions of the config file? > > >>> > > >>> One used by automation tools such as CI and git hooks that do > > not use the > > >>> templates. > > >>> > > >>> And another one that a developer can optionally use that will > > add the > > >>> templates for missing file/function headers that the developer > > then needs > > >>> to fill out. > > >>> > > >>> One concern I have about the templates is if they get used but > > a developer > > >>> does not fill in the missing information. It would be best if > > a CI check > > >>> rejects a file/function header that has not been filled in. > > >>> > > >>> Mike > > >>> > > >>>> -----Original Message----- > > >>>> From: devel@edk2.groups.io > > > On Behalf Of > > Michael Kubacki > > >>>> Sent: Tuesday, November 16, 2021 10:25 AM > > >>>> To: devel@edk2.groups.io ; > > Kinney, Michael D > > > > >>>> Subject: Re: [edk2-devel] Uncrustify configuration file and > > file/function templates > > >>>> > > >>>> Hi Mike, > > >>>> > > >>>> Those were just disabled because I typically run a separate > > invocation > > >>>> of Uncrustify with them enabled to isolate code which is > missing > > >>>> file/function headers. My thought was the templates are > > helpful but we > > >>>> would need to individually identify where they are placed to > > file TCBZs > > >>>> for maintainers to replace the template with the actual > > information. > > >>>> > > >>>> In some of my previous poc branches (like > > >>>> > > > https://github.com/makubacki/edk2/commits/uncrustify_poc_3_with_headers > > < > https://github.com/makubacki/edk2/commits/uncrustify_poc_3_with_headers>), > > I > > >>>> also pushed a branch with those results. > > >>>> > > >>>> So I do think we would want them enabled in the final config > > file. We > > >>>> can also review the contents of the templates in the future > > patch series > > >>>> to see if any changes are recommended. > > >>>> > > >>>> I prefer using a .uncrustify directory to help group related > > collateral > > >>>> but I don't have a strong opinion there. > > >>>> > > >>>> Thanks, > > >>>> Michael > > >>>> > > >>>> On 11/16/2021 12:16 PM, Michael D Kinney wrote: > > >>>>> Hi Michael, > > >>>>> > > >>>>> In your POC branch > > (https://github.com/makubacki/edk2/tree/uncrustify_poc_5 > > ), I see > the > > >>>>> uncrustify.cfg configuration file in the root. > > >>>>> > > >>>>> > > > https://github.com/makubacki/edk2/blob/uncrustify_poc_5/uncrustify.cfg > > < > https://github.com/makubacki/edk2/blob/uncrustify_poc_5/uncrustify.cfg> > > >>>>> > > >>>>> However, in your Wiki, you provide examples where this > > configuration file is in an > > >>>>> .uncrustify directory > > >>>>> > > >>>>> > > > https://dev.azure.com/projectmu/Uncrustify/_wiki/wikis/Uncrustify.wiki/1/Project-Mu-(EDK-II)-Fork-Readme > > < > https://dev.azure.com/projectmu/Uncrustify/_wiki/wikis/Uncrustify.wiki/1/Project-Mu-(EDK-II)-Fork-Readme > > > > >>>>> > > >>>>> The uncrustify.cfg files also contains commented out settings > > for the file header > > >>>>> and function header templates. > > >>>>> > > >>>>> # cmt_insert_file_header = > > default_file_header.txt > > >>>>> # cmt_insert_func_header = > > default_function_header.txt > > >>>>> > > >>>>> Are these disabled on purpose? > > >>>>> > > >>>>> Do we want to enable them? If so, should the uncrustify > > configuration file > > >>>>> and the templates go into a .uncrustify directory? > > >>>>> > > >>>>> Thanks, > > >>>>> > > >>>>> Mike > > >>>>> > > >>>>> > > >>>>> > > >>>>> > > >>>>> > > >>>>> > > >>>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > > > > > > > > > > > > > > > -- > > Pedro Falcato > > > -- Pedro Falcato --00000000000007163e05d0f04f09 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, I do.

Essentially, my c= hanges make it so the function parameters are aligned and there are always = two spaces between the parameter's type and name; it also adds spaces b= etween control statements, as you mentioned.
"force" in= stead of "add" for sp_before_sparen is a good idea though.
<= div>I assume these are good additions to the "upstream" edk2.cfg?=

On Tue, Nov 16, 2021 at 11:20 PM Michael Kubacki <mikuback@linux.microsoft.com> wr= ote:
Hi Pedro,
By "new config", do you mean the config file in the latest branch=
https://github.com/makubacki/e= dk2/blob/uncrustify_poc_5/uncrustify.cfg)?

The main difference I see from the diff in that gist and poc_5 is that
"align_func_params_gap" and "align_func_params_span" ar= e two instead of
zero.

The value "force" instead of "add" for "sp_before_= sparen" will ensure a
single space is always added between a control statement and the
parenthesis.

Thanks,
Michael

On 11/16/2021 6:05 PM, Pedro Falcato wrote:
> Hi,
>
> RE: Uncrustify's configuration
>
> I had made a few changes to the config file, when trying out Uncrustif= y,
> a few months ago, on Mike Kinney's suggestion. In my experience, t= he new
> config file reflects the edk2 coding style better.
>
> In particular, it adds spaces between things like 'if' and the=
> parenthesis, and better aligns functions' parameters.
> Feel free to check out the diff:
> https://gist.github.com/heatd/5bb= 048a188726cb8bc9f5b4a844b0ec2
> <https://gist.github.com/heatd= /5bb048a188726cb8bc9f5b4a844b0ec2>.
> There's a bit of diff noise due to it being based on
> https://dev.azure.com/proje= ctmu/_git/Uncrustify?path=3D/etc/edk2.cfg
> <https://dev.azure.com/p= rojectmu/_git/Uncrustify?path=3D/etc/edk2.cfg> but
> diffed on
> https://github.com/= makubacki/edk2/blob/uncrustify_poc_2/.uncrustify/edk2.cfg
> <https://github.= com/makubacki/edk2/blob/uncrustify_poc_2/.uncrustify/edk2.cfg>.
>
> Thanks,
> Pedro
>
> On Tue, Nov 16, 2021 at 7:26 PM Michael Kubacki
> <= mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com>>= wrote:
>
>=C2=A0 =C2=A0 =C2=A0I think that makes sense. I will look into it furth= er and let you know
>=C2=A0 =C2=A0 =C2=A0if there's any downsides found.
>
>=C2=A0 =C2=A0 =C2=A0On 11/16/2021 2:18 PM, Kinney, Michael D wrote:
>=C2=A0 =C2=A0 =C2=A0 > Could we add this feature to the Uncrustify C= I Plugin?
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Mike
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 >> -----Original Message-----
>=C2=A0 =C2=A0 =C2=A0 >> From: Michael Kubacki <mikuback@linux.microsoft= .com
>=C2=A0 =C2=A0 =C2=A0<mailto:mikuback@linux.microsoft.com>>
>=C2=A0 =C2=A0 =C2=A0 >> Sent: Tuesday, November 16, 2021 10:54 AM=
>=C2=A0 =C2=A0 =C2=A0 >> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Kinne= y,
>=C2=A0 =C2=A0 =C2=A0Michael D <michael.d.kinney@intel.com
>=C2=A0 =C2=A0 =C2=A0<mailto:michael.d.kinney@intel.com>>
>=C2=A0 =C2=A0 =C2=A0 >> Subject: Re: [edk2-devel] Uncrustify conf= iguration file and
>=C2=A0 =C2=A0 =C2=A0file/function templates
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> I would prefer to have a single version o= f the file if possible to
>=C2=A0 =C2=A0 =C2=A0 >> reduce synchronization issues across the = two copies.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> It seems that a CI plugin to read the con= tents of the template
>=C2=A0 =C2=A0 =C2=A0files and
>=C2=A0 =C2=A0 =C2=A0 >> search incoming code for that text wouldn= 't be too difficult to
>=C2=A0 =C2=A0 =C2=A0add as a
>=C2=A0 =C2=A0 =C2=A0 >> new plugin.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> Thanks,
>=C2=A0 =C2=A0 =C2=A0 >> Michael
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> On 11/16/2021 1:31 PM, Michael D Kinney w= rote:
>=C2=A0 =C2=A0 =C2=A0 >>> Hi Michael,
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>> Should we have 2 versions of the conf= ig file?
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>> One used by automation tools such as = CI and git hooks that do
>=C2=A0 =C2=A0 =C2=A0not use the
>=C2=A0 =C2=A0 =C2=A0 >>> templates.
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>> And another one that a developer can = optionally use that will
>=C2=A0 =C2=A0 =C2=A0add the
>=C2=A0 =C2=A0 =C2=A0 >>> templates for missing file/function h= eaders that the developer
>=C2=A0 =C2=A0 =C2=A0then needs
>=C2=A0 =C2=A0 =C2=A0 >>> to fill out.
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>> One concern I have about the template= s is if they get used but
>=C2=A0 =C2=A0 =C2=A0a developer
>=C2=A0 =C2=A0 =C2=A0 >>> does not fill in the missing informat= ion.=C2=A0 It would be best if
>=C2=A0 =C2=A0 =C2=A0a CI check
>=C2=A0 =C2=A0 =C2=A0 >>> rejects a file/function header that h= as not been filled in.
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>> Mike
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>>> -----Original Message-----
>=C2=A0 =C2=A0 =C2=A0 >>>> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io= >
>=C2=A0 =C2=A0 =C2=A0<devel@edk2.groups.io <mailto:devel@edk2.groups.io>> On Behalf O= f
>=C2=A0 =C2=A0 =C2=A0Michael Kubacki
>=C2=A0 =C2=A0 =C2=A0 >>>> Sent: Tuesday, November 16, 2021 = 10:25 AM
>=C2=A0 =C2=A0 =C2=A0 >>>> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>= ;;
>=C2=A0 =C2=A0 =C2=A0Kinney, Michael D <michael.d.kinney@intel.com
>=C2=A0 =C2=A0 =C2=A0<mailto:michael.d.kinney@intel.com>>
>=C2=A0 =C2=A0 =C2=A0 >>>> Subject: Re: [edk2-devel] Uncrust= ify configuration file and
>=C2=A0 =C2=A0 =C2=A0file/function templates
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>> Hi Mike,
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>> Those were just disabled because = I typically run a separate
>=C2=A0 =C2=A0 =C2=A0invocation
>=C2=A0 =C2=A0 =C2=A0 >>>> of Uncrustify with them enabled t= o isolate code which is missing
>=C2=A0 =C2=A0 =C2=A0 >>>> file/function headers. My thought= was the templates are
>=C2=A0 =C2=A0 =C2=A0helpful but we
>=C2=A0 =C2=A0 =C2=A0 >>>> would need to individually identi= fy where they are placed to
>=C2=A0 =C2=A0 =C2=A0file TCBZs
>=C2=A0 =C2=A0 =C2=A0 >>>> for maintainers to replace the te= mplate with the actual
>=C2=A0 =C2=A0 =C2=A0information.
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>> In some of my previous poc branch= es (like
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0https= ://github.com/makubacki/edk2/commits/uncrustify_poc_3_with_headers
>=C2=A0 =C2=A0 =C2=A0<h= ttps://github.com/makubacki/edk2/commits/uncrustify_poc_3_with_headers&= gt;),
>=C2=A0 =C2=A0 =C2=A0I
>=C2=A0 =C2=A0 =C2=A0 >>>> also pushed a branch with those r= esults.
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>> So I do think we would want them = enabled in the final config
>=C2=A0 =C2=A0 =C2=A0file. We
>=C2=A0 =C2=A0 =C2=A0 >>>> can also review the contents of t= he templates in the future
>=C2=A0 =C2=A0 =C2=A0patch series
>=C2=A0 =C2=A0 =C2=A0 >>>> to see if any changes are recomme= nded.
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>> I prefer using a .uncrustify dire= ctory to help group related
>=C2=A0 =C2=A0 =C2=A0collateral
>=C2=A0 =C2=A0 =C2=A0 >>>> but I don't have a strong opi= nion there.
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>> Thanks,
>=C2=A0 =C2=A0 =C2=A0 >>>> Michael
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>> On 11/16/2021 12:16 PM, Michael D= Kinney wrote:
>=C2=A0 =C2=A0 =C2=A0 >>>>> Hi Michael,
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>> In your POC branch
>=C2=A0 =C2=A0 =C2=A0(https://github.com/m= akubacki/edk2/tree/uncrustify_poc_5
>=C2=A0 =C2=A0 =C2=A0<https://github.co= m/makubacki/edk2/tree/uncrustify_poc_5>), I see the
>=C2=A0 =C2=A0 =C2=A0 >>>>> uncrustify.cfg configuration = file in the root.
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0https:= //github.com/makubacki/edk2/blob/uncrustify_poc_5/uncrustify.cfg
>=C2=A0 =C2=A0 =C2=A0<ht= tps://github.com/makubacki/edk2/blob/uncrustify_poc_5/uncrustify.cfg>= ;
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>> However, in your Wiki, you pr= ovide examples where this
>=C2=A0 =C2=A0 =C2=A0configuration file is in an
>=C2=A0 =C2=A0 =C2=A0 >>>>> .uncrustify directory
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0https://dev.azure.com/projectmu/Uncrustify/_wik= i/wikis/Uncrustify.wiki/1/Project-Mu-(EDK-II)-Fork-Readme
>=C2=A0 =C2=A0 =C2=A0<https://dev.azure.com/projectmu/Uncrustif= y/_wiki/wikis/Uncrustify.wiki/1/Project-Mu-(EDK-II)-Fork-Readme>
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>> The uncrustify.cfg files also= contains commented out settings
>=C2=A0 =C2=A0 =C2=A0for the file header
>=C2=A0 =C2=A0 =C2=A0 >>>>> and function header templates= .
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 # = cmt_insert_file_header=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D
>=C2=A0 =C2=A0 =C2=A0default_file_header.txt
>=C2=A0 =C2=A0 =C2=A0 >>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 # = cmt_insert_func_header=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D
>=C2=A0 =C2=A0 =C2=A0default_function_header.txt
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>> Are these disabled on purpose= ?
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>> Do we want to enable them?=C2= =A0 If so, should the uncrustify
>=C2=A0 =C2=A0 =C2=A0configuration file
>=C2=A0 =C2=A0 =C2=A0 >>>>> and the templates go into a .= uncrustify directory?
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>> Thanks,
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>> Mike
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>>
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>>
>=C2=A0 =C2=A0 =C2=A0 >>>
>
>
>
>
>
>
>
> --
> Pedro Falcato


--
Pedro Falcato
--00000000000007163e05d0f04f09--