From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id C8540D80230 for ; Sun, 5 May 2024 18:10:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jeMPHV7CzSQnvAj/iS3NoK0zbWKXFAU0nMvM2355VG4=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714932635; v=1; b=4x1lftrnz+NuLLsO81IDHFFTYWSxdE/Dmb9uXVRiEG0Eu4NgF/fJsI2IWYF0/m/qnzJtZ44C eQT8ko134lHW9R8faigsRk4Xrahaa7YJq8xjlsEHW/z9vPVLjEGgIvM6I3DRUFtbCDfirD/zM3K 1LqVKH/7krK/gNx7/B9GSh2bw0UzDRRtq0EEhG1TY72MoAXz5hilAG3sTc98sRQgdejYR5mrfLu 8UWL5UCQWVjLeY7tZ1NaFybXz+RuFOgX+PHKH15befaFQqpA194SJa63MqXOe6ZcBqap6vVxSB0 Qv4bAWxPZwOCiEBVuKl5sYjI/wnnC1ioCt/b2cU7HAv9g== X-Received: by 127.0.0.2 with SMTP id nV9VYY7687511xu4jCE7qqbI; Sun, 05 May 2024 11:10:35 -0700 X-Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by mx.groups.io with SMTP id smtpd.web10.3545.1714932634424653888 for ; Sun, 05 May 2024 11:10:34 -0700 X-Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-4df3e3c674fso62749e0c.2; Sun, 05 May 2024 11:10:34 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWgC0uzvBtBBUEwYD7yoA1ylN36bFAgguLBzD4xmSZENcLCOWeYzIBqPwuKu5GoxNxNWwO/UQw1YUa/Aga+6VkKXfM= X-Gm-Message-State: GtxuHqlsnY565BzXfc4GPRMcx7686176AA= X-Google-Smtp-Source: AGHT+IHiQaPmtG8PdYZUIrp9siCpjLEAZjv9riKtQCVdryWRcdMdAX6NS4sy3QjlrBSmgCEZIVv4RxqRcNMhT3uRKV0= X-Received: by 2002:a05:6122:4812:b0:4df:31f2:a4d5 with SMTP id ef18-20020a056122481200b004df31f2a4d5mr3060646vkb.4.1714932633445; Sun, 05 May 2024 11:10:33 -0700 (PDT) MIME-Version: 1.0 References: <093489b7-67c1-4315-8929-8f7b5f0c16b0@linux.microsoft.com> In-Reply-To: <093489b7-67c1-4315-8929-8f7b5f0c16b0@linux.microsoft.com> From: "Pedro Falcato" Date: Sun, 5 May 2024 19:10:21 +0100 Message-ID: Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: Michael Kubacki Cc: devel@edk2.groups.io, michael.d.kinney@intel.com, "rfc@edk2.groups.io" , Leif Lindholm , "Andrew Fish (afish@apple.com)" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 05 May 2024 11:10:34 -0700 Resent-From: pedro.falcato@gmail.com Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=4x1lftrn; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Sat, May 4, 2024 at 1:57=E2=80=AFAM Michael Kubacki wrote: > > On 5/3/2024 4:38 PM, Michael D Kinney wrote: > > > > > >> -----Original Message----- > >> From: Kinney, Michael D > >> Sent: Friday, May 3, 2024 1:13 PM > >> To: Pedro Falcato > >> Cc: rfc@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm > >> ; Andrew Fish (afish@apple.com) ; > >> Kinney, Michael D > >> Subject: RE: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code > >> Review from email to GitHub Pull Requests on 5-24-2024 > >> > >> > >> > >>> -----Original Message----- > >>> From: Pedro Falcato > >>> Sent: Friday, May 3, 2024 10:39 AM > >>> To: Kinney, Michael D > >>> Cc: rfc@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm > >>> ; Andrew Fish (afish@apple.com) > >>> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Cod= e > >>> Review from email to GitHub Pull Requests on 5-24-2024 > >>> > >>> On Thu, May 2, 2024 at 7:17=E2=80=AFPM Kinney, Michael D > >>> wrote: > >>>> > >>>> > >>>> > >>>>> -----Original Message----- > >>>>> From: rfc@edk2.groups.io On Behalf Of Pedro > >>> Falcato > >>>>> Sent: Thursday, May 2, 2024 10:51 AM > >>>>> To: devel@edk2.groups.io; Kinney, Michael D > >>> > >>>>> Cc: rfc@edk2.groups.io; Leif Lindholm ; Andrew > >>> Fish > >>>>> (afish@apple.com) > >>>>> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore > >>> Code > >>>>> Review from email to GitHub Pull Requests on 5-24-2024 > >>>>> > >>>>> On Wed, May 1, 2024 at 6:44=E2=80=AFPM Michael D Kinney via groups.= io > >>>>> wrote: > >>> > >>>>>> * All contributors, maintainers, and reviewers must have GitHub > >>> IDs. > >>>>>> * The commit message would no longer require Cc:, Reviewed-by:, > >>> Acked- > >>>>> by: > >>>>>> or Tested-by: tags. The only required tag would be Signed- > >> off- > >>> by. > >>>>> > >>>>> I'd just like to note that losing the CC:, Reviewed-by:, etc is a > >>> big > >>>>> loss. Gerrit auto-adds Rb's, github PR's do not (I'd guess there's > >> a > >>>>> way to pull that off with github actions, but I haven't looked). > >>> It'll > >>>>> be a mess if I have to go through online GH PR backlogs just to > >> find > >>>>> who to CC/add-to-review. It kills the decentralized bit off of git > >>> too > >>>>> :) > >>>>> > >>>> > >>>> Can you provide more details on the impact of the loss? > >>> > >>> In my view, commits should be fairly self-describing. What changes, > >>> why, are obvious, but who looked at it, who reviewed it, who was cc'd > >>> but didn't respond, who tested are also pretty important. Git is > >>> supposed to be decentralized, let's not forget. If we ever migrate > >>> from GH, if GH ever goes down, if the links ever go down, you'll neve= r > >>> be able to know who looked at it. If you're looking at an EDK2 commit > >>> deep into an Intel-internal fork, you won't know what "PR #478" is > >>> (heck, rebase-and-merge doesn't reference PRs either). > >>> > >>> Side-note: How are we supposed to find the PR for a given commit? > >>> Searching doesn't seem to work well. For instance, I picked a random > >>> non-trivial commit out of the current open PRs: > >>> MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers. > >>> > >> https://github.com/tianocore/edk2/pulls?q=3Dis%3Apr+is%3Aopen+MdeModul= ePkg > >>> %2FBus%2FSpi%2FSpiBus%3A+Adding+SpiBus+Drivers > >>> has no matches? > >> > >> If you have the sha of the commit, you can search in GitHub > >> > >> For example, I selected a commit at random from recent edk2 commit > >> history: > >> > >> https://github.com/tianocore/edk2/commit/032830e96841f2a752e36437= 8c > >> 3428ac5d2f59d1 > >> > >> Goto the "Pull Requests" tab for the repo and in the "Filters" search > >> box enter > >> > >> is:pr is:merged > >> > >> In this example: > >> > >> is:pr is:merged 032830e96841f2a752e364378c3428ac5d2f59d1 > >> > >> This returns a single hit on PR #5560 > >> > >> https://github.com/tianocore/edk2/pull/5560 > >> > >> There is also a 'gh' command line utility that can be used to write > >> small scripts to collect this information > > > > Here is the equivalent query and output using 'gh' CLI command: > > > > gh pr list --repo tianocore/edk2 --state merged --search 032830e96= 841f2a752e364378c3428ac5d2f59d1 > > > > Showing 1 of 1 pull request in tianocore/edk2 that matches your se= arch > > > > ID TITLE BRANCH CREATED AT > > #5560 Loongcpu niruiyu:loongcpu about 17 days ago > > I didn't see this explicitly mentioned but the easiest way to get to the > PR if you already have a commit hash/URL like > https://github.com/tianocore/edk2/commit/032830e is to click the PR link > next to the branch name at the bottom of the commit message. > > In that commit you'll see: "master (#5560)" > > Where "#5560" is the PR number and the link to the PR. Thank you Mike(s), this is useful stuff (and should be written down)! --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118575): https://edk2.groups.io/g/devel/message/118575 Mute This Topic: https://groups.io/mt/105873467/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-