From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by mx.groups.io with SMTP id smtpd.web10.2306.1649707972645365849 for ; Mon, 11 Apr 2022 13:12:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=FoxVvvy2; spf=pass (domain: gmail.com, ip: 209.85.221.181, mailfrom: pedro.falcato@gmail.com) Received: by mail-vk1-f181.google.com with SMTP id b81so8110907vkf.1 for ; Mon, 11 Apr 2022 13:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GlhyMNqFcrfQQCq5x/+cOxP7zudXq58Tbshw0wUJ5g0=; b=FoxVvvy2QNniOi38RoK7Kw8cmnmYB26VQECtah9mejYk1ts7dCQGomE8aSywaTlG/v zt8ZQfkEtBwleIV5KFH3et0vwVgUBRsw718eGz5v7Kp52ry6J9uuxI+lxV8u1ngtBUXN vMIDpZxOEPkSv0sxXfepFRC3MtNXfPzesm+HJti2QPQKSHXqcMFpNSq+7ZxrRoncRaR4 rkF9OcPzkC4VzxNVsQ72et5kkj0dITsCa8ssGA9CG8+qyDk0HbjcM1St+jroXgM2cT33 nrfRswslI3hAN+5AgsgqX6BeSr/Kkdv2JMYaVCFViPIAC3ZGESoPxRsmNgG2eukRGFP8 2mNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GlhyMNqFcrfQQCq5x/+cOxP7zudXq58Tbshw0wUJ5g0=; b=eJx7FCUtdHLUWR9B4Rt99tsCpBpORREVegAKoSoVGBwk5ayWmero//BAFFkn+/jzv+ jzV5twRpdB1LM9FTwVj7iIzg+4nk2zbym2hJrQnCPPQolC4EU2sGdbTlKyTPjx3XcG4N 8LqV/A+lSu3r1gYuH80FQd7HTnsLWQFOMhmsNgZ13TTaLMz/vC7P99cRltWF+TX8EvW7 iwGGc9/5IJLtk4A1rpFx7ffuNf3rc+zzpHeTc78sbtFMw9Aw/akQBAwcAq45PEy+6DwA SGqR8hbn2egRVNS+2u5rTdEJ189wI3jq/IhGyaYH60ZxEMgf7a38oGCRtI8w6gL8XdW9 FSPA== X-Gm-Message-State: AOAM530UxQuFMhytQcyh4xnja0UHgwrbu5Xonvs2sSlXKrmGZGdSg7zc WWdwGlklZ9OGmUYYpqNOySGr6oC2vS4WsoV5JZ6BKAHmMzo= X-Google-Smtp-Source: ABdhPJx4iC9xg5lswYZFdnqK5FVEaW6DFSgxJbWa0/vrxJmoUi1CKM02TZKqai1tmgwLitk0XTxYb0lYnz/LmSOmIKM= X-Received: by 2002:a1f:1184:0:b0:345:15de:73a with SMTP id 126-20020a1f1184000000b0034515de073amr7016429vkr.23.1649707971620; Mon, 11 Apr 2022 13:12:51 -0700 (PDT) MIME-Version: 1.0 References: <20220411112457.506101-1-kraxel@redhat.com> <20220411112457.506101-7-kraxel@redhat.com> In-Reply-To: <20220411112457.506101-7-kraxel@redhat.com> From: "Pedro Falcato" Date: Mon, 11 Apr 2022 21:12:40 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v3 6/8] CryptoPkg/CrtLibSupport: add off_t To: edk2-devel-groups-io , Gerd Hoffmann Cc: Oliver Steffen , Pawel Polawski , Jian J Wang , Xiaoyu Lu , Jiewen Yao , Guomin Jiang Content-Type: multipart/alternative; boundary="000000000000a1b5be05dc669132" --000000000000a1b5be05dc669132 Content-Type: text/plain; charset="UTF-8" Hi Gerd, According to POSIX, off_t should be a signed integer type, so I suggest we use INTN there. On Mon, Apr 11, 2022 at 12:25 PM Gerd Hoffmann wrote: > Add typedef for off_t. > Will be needed by openssl 3.0. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Jiewen Yao > --- > CryptoPkg/Library/Include/CrtLibSupport.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h > b/CryptoPkg/Library/Include/CrtLibSupport.h > index 9829ec010aee..287d7f76bfb3 100644 > --- a/CryptoPkg/Library/Include/CrtLibSupport.h > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h > @@ -104,6 +104,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > // Basic types mapping > // > typedef UINTN size_t; > +typedef UINTN off_t; > typedef UINTN u_int; > typedef INTN ptrdiff_t; > typedef INTN ssize_t; > -- > 2.35.1 > > > > > > > -- Pedro Falcato --000000000000a1b5be05dc669132 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Gerd,

According to POSIX,= off_t should be a signed integer type, so I suggest we use INTN there.
=

On Mon, Apr 11, 2022 at 12:25 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
Add typedef for off_t.
Will be needed by openssl 3.0.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
---
=C2=A0CryptoPkg/Library/Include/CrtLibSupport.h | 1 +
=C2=A01 file changed, 1 insertion(+)

diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/= Include/CrtLibSupport.h
index 9829ec010aee..287d7f76bfb3 100644
--- a/CryptoPkg/Library/Include/CrtLibSupport.h
+++ b/CryptoPkg/Library/Include/CrtLibSupport.h
@@ -104,6 +104,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
=C2=A0// Basic types mapping
=C2=A0//
=C2=A0typedef UINTN=C2=A0 =C2=A0size_t;
+typedef UINTN=C2=A0 =C2=A0off_t;
=C2=A0typedef UINTN=C2=A0 =C2=A0u_int;
=C2=A0typedef INTN=C2=A0 =C2=A0 ptrdiff_t;
=C2=A0typedef INTN=C2=A0 =C2=A0 ssize_t;
--
2.35.1








--
Pedro Falcato
--000000000000a1b5be05dc669132--