From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47])
 by mx.groups.io with SMTP id smtpd.web11.6803.1670384493800557998
 for <devel@edk2.groups.io>;
 Tue, 06 Dec 2022 19:41:33 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@gmail.com header.s=20210112 header.b=XEoUwFXm;
 spf=pass (domain: gmail.com, ip: 209.85.216.47, mailfrom: pedro.falcato@gmail.com)
Received: by mail-pj1-f47.google.com with SMTP id o12so16361318pjo.4
        for <devel@edk2.groups.io>; Tue, 06 Dec 2022 19:41:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=2D5IA0zhbILEFLM0grfayPk2Ou21syttypf0dkAsvds=;
        b=XEoUwFXmoMl9S6EBv6NbSEEksyq72ddIjWlYAZhsFIw2bVeP6uM3vL7bhQ3Cccv2hm
         H7EkvIY1h51LNKuWyxkU+tspGlQpwaZoBOAlWflvurDy/MooKTYJ/T0DsspSoTgldRl3
         PDkZD7ivHvSUO1Grr2ezOeRAAwZb1BcLEZE7lH5rnOpPq6qbcG1fC2KPKeTWvm9tivro
         k+10itwPPDHXhSL3037remKKhbnQWk/x/jBVmF1NhxeEsJgoDKHR1CtM0G/qaRPa0RZ/
         5jWrFtU3f956tEUzosHE5rCPEmQKuyqFuw0f6mK09z8soQEXDrdPLa+6SD/CFPtOl5xv
         Qh1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=2D5IA0zhbILEFLM0grfayPk2Ou21syttypf0dkAsvds=;
        b=7k6y1Jgf19y8K95SR+2Pq5yndlKOay0iIz0d2BcrWBbwhTzkBZWjpi+eZiMZ5C3ljI
         DPMaJEFPM/drxdOGJXK8ABs8FKPrjgc2Fv6uBYRyPHc3BBP7xjIRFY+hpSYtm7smETwn
         UHVewgsxNkQS8qYkc5+oItVMNEDBiblUxlQEZYHzB4WLiSmXZhgVxK3px6zvraXJN3D/
         lVUUxn0mECz1plp9g7pV8ZOWKt5qMn+bOnXlrFTyhSCX6IJp/jRCREARjGUaFwlUjfc2
         JbeGlRJTsoGKsmoeWAT+WoAPTqNHKgoXkWjXGPSXizHtWgozm8VUhAjQAgzCTEevzh6G
         SeDg==
X-Gm-Message-State: ANoB5plu+ejKvyfckAFacLx6f2RJ3LTMMhUvuBZU9EzJeaDWbl8geLYo
	u9QhY8D8w0c9O4M2aVnx0T0vrgWU/YAqfRdxYrquFREiuDpErw==
X-Google-Smtp-Source: AA0mqf4shrMsP74uHZFVmoDfAsxhLldgXv5aSRjaqV0P7Jh+iBky54duednzFh2/CCUj7P/D3p5ybyxbO5POKIgdmmY=
X-Received: by 2002:a17:90a:8402:b0:218:7744:5e9 with SMTP id
 j2-20020a17090a840200b00218774405e9mr99547749pjn.44.1670384492843; Tue, 06
 Dec 2022 19:41:32 -0800 (PST)
MIME-Version: 1.0
References: <20221122223103.597984-1-pedro.falcato@gmail.com> <001001d909df$3ed34350$bc79c9f0$@byosoft.com.cn>
In-Reply-To: <001001d909df$3ed34350$bc79c9f0$@byosoft.com.cn>
From: "Pedro Falcato" <pedro.falcato@gmail.com>
Date: Wed, 7 Dec 2022 03:41:21 +0000
Message-ID: <CAKbZUD1Zb2PQMC-n_=kLOcH-i+dC+RUZB7tm0UO-DFnQoL+c9w@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v4 1/1] MdePkg/BaseRngLib: Add a smoketest for RDRAND and check CPUID
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn
Cc: Michael D Kinney <michael.d.kinney@intel.com>, Zhiguang Liu <zhiguang.liu@intel.com>, 
	"Jason A . Donenfeld" <Jason@zx2c4.com>
Content-Type: multipart/alternative; boundary="0000000000005597d405ef34b208"

--0000000000005597d405ef34b208
Content-Type: text/plain; charset="UTF-8"

> Pedro:
>   To keep the same behavior, I suggest to only update
> BaseRngLibConstructor() API with TestRdRand, don't touch other APIs.

Liming,
the point is to fix the library's broken behavior, as previously discussed
in the ML, and documented in the commit message and the bugzilla.
Only updating BaseRngLibConstructor would do absolutely nothing.
ArchIsRngSupported needs updating because it's bogus.
The individual ArchGetRandomNumberN() do not *need* updating, but it's a
good idea to make sure that "Existing software depends on this always
returning TRUE" isn't actually reality.

Pedro

--0000000000005597d405ef34b208
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left=
:1px solid rgb(204,204,204);padding-left:1ex"><div>Pedro:<br>
=C2=A0 To keep the same behavior, I suggest to only update<br></div>
BaseRngLibConstructor() API with TestRdRand, don&#39;t touch other APIs.</b=
lockquote><div>Liming,</div><div>the point is to fix the library&#39;s brok=
en behavior, as previously discussed in the ML, and documented in the commi=
t message and the bugzilla.</div><div>Only updating BaseRngLibConstructor w=
ould do absolutely nothing.</div><div>ArchIsRngSupported needs updating bec=
ause it&#39;s bogus.</div><div>The individual ArchGetRandomNumberN() do not=
 *need* updating, but it&#39;s a good idea to make sure that &quot;Existing=
 software depends on this always returning TRUE&quot; isn&#39;t actually re=
ality.</div><div><br></div><div>Pedro<br></div></div></div>

--0000000000005597d405ef34b208--