From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: "pawel.karczewski@solidigm.com" <pawel.karczewski@solidigm.com>,
"Jayaprakash, N" <n.jayaprakash@intel.com>
Subject: Re: [edk2-devel] Using ekd2-libc with C++20
Date: Fri, 16 Feb 2024 20:02:12 +0000 [thread overview]
Message-ID: <CAKbZUD1_YnLHOrCwWA2UcjzTbLegdgFpApFR-JktVuofpFECZQ@mail.gmail.com> (raw)
In-Reply-To: <CO1PR11MB492961912C1331DC3B3BBD97D24C2@CO1PR11MB4929.namprd11.prod.outlook.com>
On Fri, Feb 16, 2024 at 5:26 PM Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> I think adding a #define to define register to nothings makes sense.
No, the correct fix is to remove 'register' from the parameters. It
does not change the ABI, nor the API, nor are the parameters
"register"-ified in the C or C++ standards.
AFAIK the only side effect of 'register' (on modern compilers, aka
GCC/clang/MSVC, etc) is that you can't grab its address
(https://godbolt.org/z/cx9zf9n9n). But that's not a problem in this
case.
--
Pedro
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115552): https://edk2.groups.io/g/devel/message/115552
Mute This Topic: https://groups.io/mt/104393456/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-02-16 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 10:00 [edk2-devel] Using ekd2-libc with C++20 pawel.karczewski via groups.io
2024-02-16 17:26 ` Michael D Kinney
2024-02-16 20:02 ` Pedro Falcato [this message]
2024-02-16 20:06 ` Pedro Falcato
2024-02-16 20:48 ` Michael D Kinney
2024-02-16 21:29 ` Michael D Kinney
2024-02-17 2:09 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKbZUD1_YnLHOrCwWA2UcjzTbLegdgFpApFR-JktVuofpFECZQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox