From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 857E27803CC for ; Fri, 16 Feb 2024 20:02:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AhOPkhq4MZfDHbBzRgz35xkfLYDUDNWgAX/WdGnH7Sc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708113745; v=1; b=YcvTYAA1X94vh1Yu7uNQ+HUN0UVd/Q8dUHjNnUFiQZfoCK5FV4fcuNmaWmj7/WuvlxYHcTZq LOLP2G6fTt9jKgjFjVj4HD8g/ssQt2PaPEyPcOTA5kA3SeBujZAD/H82vDNulfQ5hvadMebWZfO OXnaJMWHCg4wdyQU9iNQb3IM= X-Received: by 127.0.0.2 with SMTP id lOVAYY7687511xeFSuEtmeq0; Fri, 16 Feb 2024 12:02:25 -0800 X-Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by mx.groups.io with SMTP id smtpd.web10.7577.1708113744479895619 for ; Fri, 16 Feb 2024 12:02:24 -0800 X-Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3bbc649c275so1329140b6e.0 for ; Fri, 16 Feb 2024 12:02:24 -0800 (PST) X-Gm-Message-State: U2eEy62doLoSrvXYTjMUyKZPx7686176AA= X-Google-Smtp-Source: AGHT+IFp2Ods8VJvDhqY3gu1SA1cSsW9tkQTZFlzSDsx6d+jA2z7tqN2J6wAVV84A98zTo5/nlsOTug84f1NTQogJsk= X-Received: by 2002:a05:6871:e7cc:b0:21e:881a:5f1b with SMTP id qc12-20020a056871e7cc00b0021e881a5f1bmr310728oac.9.1708113743458; Fri, 16 Feb 2024 12:02:23 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Fri, 16 Feb 2024 20:02:12 +0000 Message-ID: Subject: Re: [edk2-devel] Using ekd2-libc with C++20 To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "pawel.karczewski@solidigm.com" , "Jayaprakash, N" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=YcvTYAA1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Feb 16, 2024 at 5:26=E2=80=AFPM Michael D Kinney wrote: > > I think adding a #define to define register to nothings makes sense. No, the correct fix is to remove 'register' from the parameters. It does not change the ABI, nor the API, nor are the parameters "register"-ified in the C or C++ standards. AFAIK the only side effect of 'register' (on modern compilers, aka GCC/clang/MSVC, etc) is that you can't grab its address (https://godbolt.org/z/cx9zf9n9n). But that's not a problem in this case. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115552): https://edk2.groups.io/g/devel/message/115552 Mute This Topic: https://groups.io/mt/104393456/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-