Re: [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one

["Pedro Falcato" <pedro.falcato@gmail.com>]

On Thu, Jun 1, 2023 at 5:12 PM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Tue, 9 May 2023 at 18:32, Pedro Falcato <pedro.falcato@gmail.com> wrote:
> >
> > This patch-set replaces the OVMF specific SataControllerDxe with the MdeModulePkg/Bus/Pci one.
> > They were both forked from the same code, and are code-and-functionality similar. As such, there
> > seems to be no need for duplication here.
> >
> > The first four pages both replay OvmfPkg/SataControllerDxe commits and fix up a couple of details.
> > The rest of the patches (minus the last) replace OvmfPkg/SataControllerDxe with the MdeModulePkg variant.
> > The last patch, finally, removes the thing.
> >
> > Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)).
> > More testing from other, alternative platforms is desired, although breakage seems unlikely.
> >
> > This patchset (or at least, the last patch) depends on the edk2-platforms patch series to get merged.
> >
> > (+CC Laszlo as the author of the original SataControllerDxe patches)
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc :Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Cc: Michael Roth <michael.roth@amd.com>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Peter Grehan <grehan@freebsd.org>
> > Cc: Corvin Köhne <corvink@freebsd.org>
> > Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien@xen.org>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> >
> > Changes:
> > v2:
> >   - Address Laszlo's feedback wrt commit to port into MdeModulePkg
> >   - Address Laszlo's feedback wrt how to split the removal of the driver and the patches for each sub-platform maintainer
> >   - Address Mike Maslenkin's feedback on the preexisting ASSERTs (Private != NULL)
> >   - Add Gerd's ACK and Tested-by (conservatively) to patches 6 and 12 (since they are remotely QEMU related)
> >
> > Pedro Falcato (12):
> >   MdeModulePkg/SataControllerDxe: Clean up error handling in Start()
> >   MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO
> >     level
> >   MdeModulePkg/SataControllerDxe: Remove useless null check
> >   MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private != NULL)
> >   OvmfPkg: Replace the OVMF-specific SataControllerDxe
> >   OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe
> >   OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe
> >   OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe
> >   OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe
> >   OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe
> >   OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe
> >   OvmfPkg: Remove SataControllerDxe
> >
>
> What is the state of this series?
>
> Are we waiting for the MdeModulePkg changes to be picked up, and do
> the OVMF changes have to wait for that?

Hi Ard,

I believe we've got the appropriate reviews/acks from the relevant
people for both MdeModulePkg and OvmfPkg.

I've just updated my PR with the appropriate tags on each commit:
https://github.com/tianocore/edk2/pull/4370

-- 
Pedro