From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by mx.groups.io with SMTP id smtpd.web11.220.1685639554883742653 for ; Thu, 01 Jun 2023 10:12:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=mEqtWmez; spf=pass (domain: gmail.com, ip: 209.85.221.175, mailfrom: pedro.falcato@gmail.com) Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-4573e1e6cb9so1645500e0c.0 for ; Thu, 01 Jun 2023 10:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685639554; x=1688231554; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qi+8AXb171pKsC8Jzoc/ELWeEMbh2tEc4xcR8E7quf0=; b=mEqtWmezulbxIt7WJuh+ZAcLYU2OBZR4T/b39Nv9LFnL/jL/1lMNWcMaSW37xJqWMK dJ5ZLZ9rPi3oT0GbNTJ6p4tXErDaAgXuuff6wwGe3l8EayhqghPvcyMXkFCxbIiBfDF8 WITBJi0RCTIIDGs+22JY/6jAakKULElw9vgBMe6q3CTVtAfr8rIoyZW5XqT5qQ64cUur CJjSaWw35Q1SCTMINkTLbkd2aFWV70Ox/o4/zicYbRkFshaiU6Fy3OgkEZuPIOBU3Sat ROMWGs6ihVKrfv+TlzV9aMeYOLk97A7V/44gA76UHqWPr3CFogBeWKO3ArQ0iYkbtWG2 hpYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685639554; x=1688231554; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qi+8AXb171pKsC8Jzoc/ELWeEMbh2tEc4xcR8E7quf0=; b=lid+dIsGKs0QQNvdMP85ZepZ4OGbaQ3kJGaf3n1aXabvyK+/hCeNfoc/SwR6F8cQ2x dwWfbgzqqHg+0/WM54OYEGcnH+tf8Md0ZzzM/KUr0D2cQwBmrNSjPBcpTHzaqioKIwXb HwV7sGstQTi5qD1yhxl58KUDZ1zuMStlVCcleMXxBSPGSVvXGjOwZBAUz2ozwLpx1U5p iMHVwMCVCrtXxr3xxLrjcsrc859LnoA5V/YYVx/Ru1S5e+uW0rHTADCRR3zc4GMfV4Uv Fhx0e5gYx03u+81DFD67xGvSetXL2+mMWI5a5fp+iPce49uzRHl2koffgK/i09Si6rhJ A1lA== X-Gm-Message-State: AC+VfDwimGGdGe8oqDWCsmnjT9e5pGmgKBiv/UmTQhcne68LJoA5ETUN wDJV2gPYrA1rRfMyH0wEw75c4/O4d/ka81CbzMU= X-Google-Smtp-Source: ACHHUZ6Pc9dzEeBW4u4ciL0wnaW9uJ2n7Kcac6cR6JDPLNRjZ/UCYOtyd8aGKwX+tB2RLGfyN3anAZK0qFdUQYNCMng= X-Received: by 2002:a05:6102:1623:b0:434:3068:8314 with SMTP id cu35-20020a056102162300b0043430688314mr1601611vsb.5.1685639553832; Thu, 01 Jun 2023 10:12:33 -0700 (PDT) MIME-Version: 1.0 References: <20230509163212.291333-1-pedro.falcato@gmail.com> In-Reply-To: From: "Pedro Falcato" Date: Thu, 1 Jun 2023 18:12:22 +0100 Message-ID: Subject: Re: [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one To: Ard Biesheuvel Cc: devel@edk2.groups.io, Laszlo Ersek , Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , =?UTF-8?Q?Corvin_K=C3=B6hne?= , Sebastien Boeuf , Anthony Perard , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 1, 2023 at 5:12=E2=80=AFPM Ard Biesheuvel wro= te: > > On Tue, 9 May 2023 at 18:32, Pedro Falcato wrot= e: > > > > This patch-set replaces the OVMF specific SataControllerDxe with the Md= eModulePkg/Bus/Pci one. > > They were both forked from the same code, and are code-and-functionalit= y similar. As such, there > > seems to be no need for duplication here. > > > > The first four pages both replay OvmfPkg/SataControllerDxe commits and = fix up a couple of details. > > The rest of the patches (minus the last) replace OvmfPkg/SataController= Dxe with the MdeModulePkg variant. > > The last patch, finally, removes the thing. > > > > Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). > > More testing from other, alternative platforms is desired, although bre= akage seems unlikely. > > > > This patchset (or at least, the last patch) depends on the edk2-platfor= ms patch series to get merged. > > > > (+CC Laszlo as the author of the original SataControllerDxe patches) > > > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc :Jordan Justen > > Cc: Gerd Hoffmann > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Min Xu > > Cc: Tom Lendacky > > Cc: Michael Roth > > Cc: Rebecca Cran > > Cc: Peter Grehan > > Cc: Corvin K=C3=B6hne > > Cc: Sebastien Boeuf > > Cc: Anthony Perard > > Cc: Julien Grall > > Cc: Laszlo Ersek > > > > Changes: > > v2: > > - Address Laszlo's feedback wrt commit to port into MdeModulePkg > > - Address Laszlo's feedback wrt how to split the removal of the drive= r and the patches for each sub-platform maintainer > > - Address Mike Maslenkin's feedback on the preexisting ASSERTs (Priva= te !=3D NULL) > > - Add Gerd's ACK and Tested-by (conservatively) to patches 6 and 12 (= since they are remotely QEMU related) > > > > Pedro Falcato (12): > > MdeModulePkg/SataControllerDxe: Clean up error handling in Start() > > MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO > > level > > MdeModulePkg/SataControllerDxe: Remove useless null check > > MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private !=3D NULL) > > OvmfPkg: Replace the OVMF-specific SataControllerDxe > > OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe > > OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe > > OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe > > OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe > > OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe > > OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe > > OvmfPkg: Remove SataControllerDxe > > > > What is the state of this series? > > Are we waiting for the MdeModulePkg changes to be picked up, and do > the OVMF changes have to wait for that? Hi Ard, I believe we've got the appropriate reviews/acks from the relevant people for both MdeModulePkg and OvmfPkg. I've just updated my PR with the appropriate tags on each commit: https://github.com/tianocore/edk2/pull/4370 --=20 Pedro