From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: devel@edk2.groups.io, ardb@kernel.org,
Liming Gao <gaoliming@byosoft.com.cn>,
Rebecca Cran <rebecca@bsdio.com>,
Pierre Gondois <pierre.gondois@arm.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH 3/3] OvmfPkg/OvmfX86: Enable RDRAND based EFI_RNG_PROTOCOL implementation
Date: Tue, 22 Nov 2022 14:17:19 +0000 [thread overview]
Message-ID: <CAKbZUD1jGdw8akuZnMJ5=XOzJB8VCXUzu-TABagiFSaTejof6w@mail.gmail.com> (raw)
In-Reply-To: <CAHmME9o5TU9GKi8Afz9TdWcnt-thSfpnTheuBHkMGCAHQtugww@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
On Tue, Nov 22, 2022 at 1:10 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> Yes. If what you say is true, this should be fixed asap. Do you intend
> to send a patch?
>
I have sent out a patch (https://edk2.groups.io/g/devel/message/96552)
fixing the CPUID checks with a naive attempt to sniff out RDRAND issues.
Your Linux snippet is probably better but I couldn't look at it due to
licensing concerns.
To point out again, this is already hooked up to baremetal firmware.
> So if you see issues that are worth fixing, fix them, but it shouldn't
> hold up Ard's patchset.
"Real firmware" is frequently not a shining example of quality :) They can
also more or less know what CPUs the fw will run on, but OVMF runs mostly
everywhere.
In any case, I've sent out a patch (hopefully) fixing these issues. It
should be trivial enough to review and apply so that Ard's patch doesn't
get held up.
I think it's best to apply this only after my patch gets merged (in order
to avoid weird breakage between commits) but that's up to the OVMF
maintainers to decide.
Pedro
[-- Attachment #2: Type: text/html, Size: 1858 bytes --]
next prev parent reply other threads:[~2022-11-22 14:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 13:47 [PATCH 0/3] OVMF: support EFI_RNG_PROTOCOL without virtio-rng Ard Biesheuvel
2022-11-10 13:47 ` [PATCH 1/3] ArmPkg/ArmTrngLib: Fix incorrect GUID reference in DEBUG() output Ard Biesheuvel
2022-11-10 14:39 ` Sami Mujawar
2022-11-10 13:47 ` [PATCH 2/3] ArmVirtPkg/ArmVirtQemu: Expose TRNG hypercall via RngDxe if implemented Ard Biesheuvel
2022-11-18 16:48 ` PierreGondois
2023-01-11 16:49 ` [edk2-devel] " Ard Biesheuvel
2023-01-11 17:38 ` PierreGondois
2023-01-11 17:45 ` Ard Biesheuvel
2022-11-10 13:47 ` [PATCH 3/3] OvmfPkg/OvmfX86: Enable RDRAND based EFI_RNG_PROTOCOL implementation Ard Biesheuvel
2022-11-22 11:35 ` [edk2-devel] " Pedro Falcato
2022-11-22 12:20 ` Jason A. Donenfeld
2022-11-22 12:45 ` Pedro Falcato
2022-11-22 13:10 ` Jason A. Donenfeld
2022-11-22 14:17 ` Pedro Falcato [this message]
2022-11-22 14:21 ` Jason A. Donenfeld
2022-11-22 12:29 ` Jason A. Donenfeld
2022-11-11 0:41 ` 回复: [PATCH 0/3] OVMF: support EFI_RNG_PROTOCOL without virtio-rng gaoliming
2022-11-11 2:41 ` Jason A. Donenfeld
2022-11-11 7:47 ` Ard Biesheuvel
2022-11-11 17:03 ` Jason A. Donenfeld
[not found] ` <172660F4A69E435E.25609@groups.io>
2022-11-11 3:53 ` 回复: [edk2-devel] 回复: " gaoliming
2022-11-11 7:34 ` Ard Biesheuvel
2022-11-11 8:14 ` [edk2-devel] " Gerd Hoffmann
2023-01-10 18:19 ` Jason A. Donenfeld
2023-01-11 11:41 ` Ard Biesheuvel
2023-01-11 15:23 ` [edk2-devel] " Laszlo Ersek
2023-01-11 16:03 ` Ard Biesheuvel
2023-01-11 16:05 ` Ard Biesheuvel
2023-01-12 9:27 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKbZUD1jGdw8akuZnMJ5=XOzJB8VCXUzu-TABagiFSaTejof6w@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox