From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mx.groups.io with SMTP id smtpd.web10.19647.1669126651627166503 for ; Tue, 22 Nov 2022 06:17:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lBsdEbQp; spf=pass (domain: gmail.com, ip: 209.85.214.182, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f182.google.com with SMTP id 4so13802572pli.0 for ; Tue, 22 Nov 2022 06:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=q4tS5jkxZGnyG0tygZOPIhD7CclYkVPDs1WNfoexv34=; b=lBsdEbQp0Rpy1nuPK2mZyKs+2PYvMjrt/z0OX8GROjzGzl+I0/lnC/8i/7YGduIxIY CPlTi9WcqauqCbKxv2nbkSGchI7VQQSpqD+iIzY+DBLWjEvAd8qvWLa3K/qnDxIQD1WI aDHaaIt8CWgvv1ErOLYz87wlnhVAVQ8GuaalnCeMQSbmbffdRyEXu42kRRtl5Y6e47Cu Jl/fccDN8UdFgDVG4YEjo1+bPX7znTaWQqLq8u4xeX2EwYzMeAQTrjMR39Du0ao1Sgc1 mCOf+8s7hkDfftbvCqkBAKL+w7liwnUmIumr9nJM2vwrRJX3ptSV+RtCCROXgRy7J+7H Gk8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q4tS5jkxZGnyG0tygZOPIhD7CclYkVPDs1WNfoexv34=; b=xd12yIHG47DTtzO/wCMShy7ne03S+WVnr5nyMmUEG2OAcxSrQvl+Nhz21eA3YQ94H+ UK/bOeOBFloe0rZjNipkFj3Mm5plRmkaqSsSobLvym1YEIJTHnT3OcAQJkf+cpDQw3Z7 sSxnKxaTE0AeqEiMyj6OXDI1MyrwI2t2/b74RsOYRL18aCm5QN59oGm4LcXpK8P16+tJ l5zZTqyt1w1aGGrp+/yvq9M5TlrObpWZCGyihzOxdjY/MSznqGq2z1EqDMvjsSzogLR7 XCuQ8eDMq65sTR4+AeX6Taf4GtJQaE5Wzhu7BE7WolgXvZ9BDKmmDM93ehnss2vzFU7O Oefg== X-Gm-Message-State: ANoB5pkEfMJP3UXV3EfuC34vgmkJCFUr8Bn0zjsRQsovRJ4CQBFMOD1x 5b2UZz9OtuiDhAcF9MK8chpTZluvzv0ZMe3NeK0= X-Google-Smtp-Source: AA0mqf6zbruSYdCM7uvjHVEiqFMZ5uKsdmR8okrwFqSYG9oo/3Bb7zc7/Plc7xHrsm/rYwNxr5ZB+3Ba6PYHhjYo9Dk= X-Received: by 2002:a17:902:b691:b0:188:5240:50ec with SMTP id c17-20020a170902b69100b00188524050ecmr4398867pls.168.1669126651002; Tue, 22 Nov 2022 06:17:31 -0800 (PST) MIME-Version: 1.0 References: <20221110134738.3798618-1-ardb@kernel.org> <20221110134738.3798618-4-ardb@kernel.org> In-Reply-To: From: "Pedro Falcato" Date: Tue, 22 Nov 2022 14:17:19 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH 3/3] OvmfPkg/OvmfX86: Enable RDRAND based EFI_RNG_PROTOCOL implementation To: "Jason A. Donenfeld" Cc: devel@edk2.groups.io, ardb@kernel.org, Liming Gao , Rebecca Cran , Pierre Gondois , Leif Lindholm , Sami Mujawar , Gerd Hoffmann Content-Type: multipart/alternative; boundary="0000000000001e469605ee0fd5e1" --0000000000001e469605ee0fd5e1 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 22, 2022 at 1:10 PM Jason A. Donenfeld wrote: > Yes. If what you say is true, this should be fixed asap. Do you intend > to send a patch? > I have sent out a patch (https://edk2.groups.io/g/devel/message/96552) fixing the CPUID checks with a naive attempt to sniff out RDRAND issues. Your Linux snippet is probably better but I couldn't look at it due to licensing concerns. To point out again, this is already hooked up to baremetal firmware. > So if you see issues that are worth fixing, fix them, but it shouldn't > hold up Ard's patchset. "Real firmware" is frequently not a shining example of quality :) They can also more or less know what CPUs the fw will run on, but OVMF runs mostly everywhere. In any case, I've sent out a patch (hopefully) fixing these issues. It should be trivial enough to review and apply so that Ard's patch doesn't get held up. I think it's best to apply this only after my patch gets merged (in order to avoid weird breakage between commits) but that's up to the OVMF maintainers to decide. Pedro --0000000000001e469605ee0fd5e1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Nov 22, 2022 at 1:10 PM Jason= A. Donenfeld <Jason@zx2c4.com>= ; wrote:
Yes. If what you say is true, this should be fixed asap. Do you intend
to send a patch?

I have sent out a patch (https://edk2.groups.io/g/devel/message/9= 6552) fixing the CPUID checks with a naive attempt to sniff out RDRAND = issues.
Your Linux snippet is probably bett= er but I couldn't look at it due to licensing concerns.

To point out again, this is already hooked up to baremetal firmware.
So if you see issues that are worth fixing, fix them, but it shouldn't<= br> hold up Ard's patchset.
=C2=A0
"Real fi= rmware" is frequently not a shining example of quality :) They can als= o more or less know what CPUs the fw will run on, but OVMF runs mostly ever= ywhere.

In any case, I've sent out a patch (ho= pefully) fixing these issues. It should be trivial enough to review and app= ly so that Ard's patch doesn't get held up.
I think it= 9;s best to apply this only after my patch gets merged (in order to avoid w= eird breakage between commits) but that's up to the OVMF maintainers to= decide.

Pedro
--0000000000001e469605ee0fd5e1--