From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: devel@edk2.groups.io, marcin.juszkiewicz@linaro.org
Cc: Nhi Pham <nhi@os.amperecomputing.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Chuong Tran <chuong@os.amperecomputing.com>,
Rebecca Cran <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present
Date: Wed, 18 Oct 2023 12:23:15 +0100 [thread overview]
Message-ID: <CAKbZUD1jfFPpV2wAXisLLba1ngXD7Kh=RtcEyWThick1xP7tNA@mail.gmail.com> (raw)
In-Reply-To: <2d881cf4-d12b-4ddb-8a5c-deb5f070c1cc@linaro.org>
On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>
> W dniu 18.10.2023 o 12:32, Nhi Pham pisze:
> > Acked-by: Nhi Pham <nhi@os.amperecomputing.com>
> >
> > Nit: I think you want to run uncrustify for Patch 3 as well :)
>
> Done, will check other changes too.
>
> I have a strong feeling that Qemu part of EDK2 needs a bit
> bigger patch when it comes to formatting:
>
> Platform/Qemu/QemuOpenBoardPkg/Include/Library/QemuOpenFwCfgLib.h | 7 +-
> Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c | 33 +-
> Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/Ia32/SecEntry.nasm | 99 ++-
> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c | 108 +--
> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c | 30 +-
> Platform/Qemu/QemuOpenBoardPkg/README.md | 43 +-
Something must be wrong with your config because QemuOpenBoardPkg is
and was, AFAIK, all formatted using uncrustify. And if I run it
locally, it seems to agree with me.
--
Pedro
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109730): https://edk2.groups.io/g/devel/message/109730
Mute This Topic: https://groups.io/mt/102035954/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-18 11:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 10:07 [edk2-devel] [PATCH edk2-platforms v4 0/4] Provide XHCI USB controller only for newer hardware Marcin Juszkiewicz
2023-10-18 10:07 ` [edk2-devel] [PATCH edk2-platforms v4 1/4] SbsaQemu: introduce macro to compare platform version Marcin Juszkiewicz
2023-10-18 10:07 ` [edk2-devel] [PATCH edk2-platforms v4 2/4] SbsaQemu: add AcpiLib Marcin Juszkiewicz
2023-10-18 10:07 ` [edk2-devel] [PATCH edk2-platforms v4 3/4] SbsaQemu: initialize XHCI only if it exists Marcin Juszkiewicz
2023-10-18 10:07 ` [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present Marcin Juszkiewicz
2023-10-18 10:32 ` Nhi Pham via groups.io
2023-10-18 11:16 ` Marcin Juszkiewicz
2023-10-18 11:23 ` Pedro Falcato [this message]
2023-10-18 11:28 ` Marcin Juszkiewicz
2023-10-18 11:38 ` Pedro Falcato
2023-10-18 13:36 ` Laszlo Ersek
2023-10-18 14:27 ` Marcin Juszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKbZUD1jfFPpV2wAXisLLba1ngXD7Kh=RtcEyWThick1xP7tNA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox