From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7BACDAC0E09 for ; Wed, 18 Oct 2023 11:23:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ID6MNV/vXRrqP2Fq0XW3asQJS7vfId06Kau7wHYuozs=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697628209; v=1; b=GNGqXUCJEnUbP0EFm7cWwGZMxjXTUoUet/6sx/k03PsWfeLiC99EMj1+SVLUZ0MrKvMBu2UL 6NsH6KZLZ1PgA/hSc/4MaywsJCP089B20MCRXsqx6pkEtRNEhmLweRQiTWxM7uAcYAZVzmF73MJ TaHC63C4L9YBihzdsuh2zkxI= X-Received: by 127.0.0.2 with SMTP id bAJjYY7687511xYHCCgRBWbD; Wed, 18 Oct 2023 04:23:29 -0700 X-Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by mx.groups.io with SMTP id smtpd.web10.279314.1697628208487421600 for ; Wed, 18 Oct 2023 04:23:28 -0700 X-Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7afc13d58c6so2414261241.1 for ; Wed, 18 Oct 2023 04:23:28 -0700 (PDT) X-Gm-Message-State: kWacIvJiy4S3H4dJOkU8lg0Sx7686176AA= X-Google-Smtp-Source: AGHT+IGAmxxsqVh4eDlAaLRj8R/b6Rvo2PHuL1TPYh7Hqprecrlrz4r8HfqZr4I7sNF5Pro4hER8ROBZlCVjDo0rnp4= X-Received: by 2002:a67:ae07:0:b0:452:7617:a757 with SMTP id x7-20020a67ae07000000b004527617a757mr5254370vse.26.1697628207307; Wed, 18 Oct 2023 04:23:27 -0700 (PDT) MIME-Version: 1.0 References: <20231018-ehci-xhci-fix-v4-0-aa53138997a5@linaro.org> <20231018-ehci-xhci-fix-v4-4-aa53138997a5@linaro.org> <75b23ede-8f50-4d44-a786-fb04cd4abd00@os.amperecomputing.com> <2d881cf4-d12b-4ddb-8a5c-deb5f070c1cc@linaro.org> In-Reply-To: <2d881cf4-d12b-4ddb-8a5c-deb5f070c1cc@linaro.org> From: "Pedro Falcato" Date: Wed, 18 Oct 2023 12:23:15 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present To: devel@edk2.groups.io, marcin.juszkiewicz@linaro.org Cc: Nhi Pham , Leif Lindholm , Ard Biesheuvel , Jeremy Linton , Chuong Tran , Rebecca Cran Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GNGqXUCJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Oct 18, 2023 at 12:16=E2=80=AFPM Marcin Juszkiewicz wrote: > > W dniu 18.10.2023 o 12:32, Nhi Pham pisze: > > Acked-by: Nhi Pham > > > > Nit: I think you want to run uncrustify for Patch 3 as well :) > > Done, will check other changes too. > > I have a strong feeling that Qemu part of EDK2 needs a bit > bigger patch when it comes to formatting: > > Platform/Qemu/QemuOpenBoardPkg/Include/Library/QemuOpenFwCfgLib.h = | 7 +- > Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c = | 33 +- > Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/Ia32/SecEntry.nas= m | 99 ++- > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c = | 108 +-- > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c = | 30 +- > Platform/Qemu/QemuOpenBoardPkg/README.md = | 43 +- Something must be wrong with your config because QemuOpenBoardPkg is and was, AFAIK, all formatted using uncrustify. And if I run it locally, it seems to agree with me. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109730): https://edk2.groups.io/g/devel/message/109730 Mute This Topic: https://groups.io/mt/102035954/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-