From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by mx.groups.io with SMTP id smtpd.web10.6617.1655131514188834168 for ; Mon, 13 Jun 2022 07:45:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cYXTcItg; spf=pass (domain: gmail.com, ip: 209.85.222.47, mailfrom: pedro.falcato@gmail.com) Received: by mail-ua1-f47.google.com with SMTP id j11so1109081uan.9 for ; Mon, 13 Jun 2022 07:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KBH8BL85I4jZOZTW0CHdDUYs3fpgL+ovIPa8rrfoPF0=; b=cYXTcItghH9JGxJ5Wyt23RXeOpN4ndlqm9FzxVvUuN3VmsSjM9EHxTaKoxI1E7ZF1T K5H/Q2JdQXyHxdjvbkf1C+rYSrJeWEEC+s0ZogLa8JygrrcnMp1r0Gk+noBRn/nNOqK5 fPa8yYwo+jZOIO4nuHgYCAeuUjEdursNLVUNHvn+BpoRibt85Yew7+k/omU4U9cVWPhW tQA9q7nTFkzxFBp84PAeqJ+Ndgfc+6vws+JWzQNq+huFJLcxxwuTgugfBcT2ulFBxJ9i 5xXqE3RIsOEkTfLnff3L6Kp+9h8lcbwulHPp/eHZ8nrfwBsentStsewabYJEZJSxuC2/ AsBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KBH8BL85I4jZOZTW0CHdDUYs3fpgL+ovIPa8rrfoPF0=; b=gK3v2tyfP3nfOEGej9n2pMiw2umGhwNfVIg3rUm64YWcQQwqjGN1Cn5LXWcKFRZobX QPWlkTIZPFf2z5eH7Ch2MRQCYkriGyTOK3O8Ai/eD7+qq5l7luQfaxw9fPC+RNhwBpSB dpxGFuhTrTKFV1+kSTQJVHtinb8V/1bH8YPyjZ1d8QIZtiJxfZKpL/DLhZlLOE9gFwJW R9iLLylmskpNwD9N7/RuQ3DMlcldNPSy0CfKSh7dK6cfuKLZaMLYGYkwkDcLbmc7dlrM HXHptq/r7pB9uAQngbSIXdr8+hVKLQHmZSMllMSbobW3xFgrKuYUF2t/kJtcosQ15CtH daJA== X-Gm-Message-State: AOAM531KHEv1k1/rTAlcCnUulfr0qmLAQJyA9dejaM7WMDO+0I4Dd2x7 GUAr9DWvOnH3QwP6BD+WQICg7Uwj8Gq+yhJ6IDM= X-Google-Smtp-Source: ABdhPJyJqQvBhbGUfYkarkn+di9F8VA8LjMWB+ZffAnzL5x2shHN9YVqN15LM/NW4SvsEkkYWpdZy2lM8jS6gfxa1zY= X-Received: by 2002:ab0:162a:0:b0:379:5294:d522 with SMTP id k39-20020ab0162a000000b003795294d522mr5608103uae.105.1655131513225; Mon, 13 Jun 2022 07:45:13 -0700 (PDT) MIME-Version: 1.0 References: <20220407220146.149580-1-pedro.falcato@gmail.com> <16E9330A7A87074F.18109@groups.io> <16EE1DD8FA9A45F3.9448@groups.io> <00f801d8762d$7a24fd40$6e6ef7c0$@byosoft.com.cn> In-Reply-To: <00f801d8762d$7a24fd40$6e6ef7c0$@byosoft.com.cn> From: "Pedro Falcato" Date: Mon, 13 Jun 2022 15:45:02 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib To: gaoliming Cc: edk2-devel-groups-io , Leif Lindholm , Michael D Kinney , Zhiguang Liu Content-Type: multipart/alternative; boundary="000000000000e707ee05e15555d2" --000000000000e707ee05e15555d2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Liming, Sorry for the question, but can I merge this with your Ack and my RB or do I have to wait for another RB? I want to solve this as soon as possible since right now Ext4Pkg won't build with upstream edk2. Thanks, Pedro On Thu, Jun 2, 2022 at 4:05 AM gaoliming wrote: > Pedro=EF=BC=9A > > Thanks for your enhancement to support ext2/3 file system. Acked-by: > Liming Gao for this patch set. > > > > Thanks > > Liming > > *=E5=8F=91=E4=BB=B6=E4=BA=BA:* Pedro Falcato > *=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:* 2022=E5=B9=B46=E6=9C=881=E6=97=A5= 5:33 > *=E6=94=B6=E4=BB=B6=E4=BA=BA:* edk2-devel-groups-io ; Pedro Falcato < > pedro.falcato@gmail.com> > *=E6=8A=84=E9=80=81:* Leif Lindholm ; Michael D Kinney= < > michael.d.kinney@intel.com>; Liming Gao ; > Zhiguang Liu > *=E4=B8=BB=E9=A2=98:* Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg= : Add ext2/3 > support and move crc16/32c to BaseLib > > > > Ping. Please review now that the stable freeze is over. > > > > On Wed, May 11, 2022 at 6:42 PM Pedro Falcato via groups.io > wrote: > > Ping. Could someone review these patches? > > > > On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io > wrote: > > Ping. If someone could take a look, it would be much appreciated. > > > > On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato > wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3745 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3871 > > Hi all, > > This patch-set attempts to address two open feature requests for Ext4Pkg > by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLi= b > (id 3871). > > The previous patch-set regarding 3871 attempted to merge the different > crc16 implementations > but failed because, contrary to what I thought, there are many, many > different CRC16s which > are all slightly different. This one (plus the separate edk2 patch) > attempts to just merge > CRC16-ANSI (confusingly, also known as CRC16) into BaseLib. > > Since this patch set grew to be considerably different from the original, > I didn't mark it > as v2 but rather a separate, new patch-set. > > CC'ing the edk2-platforms stewards (as I cannot review my own code) and > the CC's of the MdePkg > patch. > > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > > Pedro Falcato (3): > Ext4Pkg: Replace the CRC implementations with BaseLib > Ext4Pkg: Format using uncrustify > Ext4Pkg: Add ext2/3 support > > Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +- > Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++ > Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +- > Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ----- > Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------ > Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +- > Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++--- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------ > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +- > Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +- > Features/Ext4Pkg/Ext4Dxe/File.c | 19 +- > Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +- > Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +- > 16 files changed, 640 insertions(+), 487 deletions(-) > create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c > delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c > delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c > > -- > 2.35.1 > > > > -- > > Pedro Falcato > > > > -- > > Pedro Falcato > >=20 > > > > -- > > Pedro Falcato > --=20 Pedro Falcato --000000000000e707ee05e15555d2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Liming,

Sorry for the questi= on, but can I merge this with your Ack and my RB or do I have to wait for a= nother RB?
I want to solve this as soon as possible since right n= ow Ext4Pkg won't build with upstream edk2.

Tha= nks,
Pedro

On Thu, Jun 2, 2022 at 4:05 AM gaoliming <= gaoliming@byosoft.com.cn>= ; wrote:

Pedro=EF=BC=9A

=C2=A0= Thanks for your enhancement to support ext2/3 file system. Acked-by: Liming= Gao <gaol= iming@byosoft.com.cn> for this patch set.

<= p class=3D"MsoNormal">=C2=A0

Thanks

Liming

=E5=8F= =91=E4=BB=B6=E4=BA=BA: Pedro Falca= to <pedro.f= alcato@gmail.com>
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B46=E6=9C=88= 1=E6=97=A5 5:33
= =E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io <devel@edk2.groups.io>; Pedro Falcato <pedro.falcato@gmail.c= om>
=E6=8A=84=E9=80=81:= Leif Lindholm <leif@nuviainc.com>; Michael D Kinney <michael.d.kinney@i= ntel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.= com>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg:= Add ext2/3 support and move crc16/32c to BaseLib

=C2=A0=

Ping. Pl= ease review now that the stable freeze is over.

=C2=A0<= /p>

On Wed, May 11, 20= 22 at 6:42 PM Pedro Falcato via groups.io <pedro.falcato=3Dgmail.com@groups.io> wrote:=

Ping. Could someone= review these patches?

=C2=A0

On Mon, Apr 25, 2022 at 6:14 PM Pedro Falca= to via groups.io <ped= ro.falcato=3Dgmail= .com@groups.io> wrote:

Ping. If someone could take a look, it would= be much appreciated.

= =C2=A0

On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcat= o <pedro.fa= lcato@gmail.com> wrote:

BZ: https:= //bugzilla.tianocore.org/show_bug.cgi?id=3D3745
BZ: https:/= /bugzilla.tianocore.org/show_bug.cgi?id=3D3871

Hi all,

Th= is patch-set attempts to address two open feature requests for Ext4Pkg
b= y adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib (= id 3871).

The previous patch-set regarding 3871 attempted to merge t= he different crc16 implementations
but failed because, contrary to what = I thought, there are many, many different CRC16s which
are all slightly = different. This one (plus the separate edk2 patch) attempts to just mergeCRC16-ANSI (confusingly, also known as CRC16) into BaseLib.

Since = this patch set grew to be considerably different from the original, I didn&= #39;t mark it
as v2 but rather a separate, new patch-set.

CC'= ing the edk2-platforms stewards (as I cannot review my own code) and the CC= 's of the MdePkg
patch.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Mi= chael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.c= n>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>

Pedro Falcato (3):=
=C2=A0 Ext4Pkg: Replace the CRC implementations with BaseLib
=C2=A0 = Ext4Pkg: Format using uncrustify
=C2=A0 Ext4Pkg: Add ext2/3 support
<= br>=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |=C2=A0 10 +-
=C2=A0Featu= res/Ext4Pkg/Ext4Dxe/BlockMap.c=C2=A0 =C2=A0| 279 +++++++++++++++++
=C2= =A0Features/Ext4Pkg/Ext4Dxe/Collation.c=C2=A0 |=C2=A0 =C2=A04 +-
=C2=A0F= eatures/Ext4Pkg/Ext4Dxe/Crc16.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 75 -----
=C2= =A0Features/Ext4Pkg/Ext4Dxe/Crc32c.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 84 ------=C2=A0Features/Ext4Pkg/Ext4Dxe/Directory.c=C2=A0 |=C2=A0 13 +-
=C2=A0F= eatures/Ext4Pkg/Ext4Dxe/DiskUtil.c=C2=A0 =C2=A0|=C2=A0 =C2=A06 +-
=C2=A0= Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h=C2=A0 =C2=A0|=C2=A0 30 +-
=C2=A0Feat= ures/Ext4Pkg/Ext4Dxe/Ext4Dxe.c=C2=A0 =C2=A0 |=C2=A0 95 +++---
=C2=A0Feat= ures/Ext4Pkg/Ext4Dxe/Ext4Dxe.h=C2=A0 =C2=A0 | 417 ++++++++++++++-----------= -
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf=C2=A0 |=C2=A0 =C2=A03 +-=C2=A0Features/Ext4Pkg/Ext4Dxe/Extents.c=C2=A0 =C2=A0 |=C2=A0 27 +-
=C2= =A0Features/Ext4Pkg/Ext4Dxe/File.c=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 19 +-<= br>=C2=A0Features/Ext4Pkg/Ext4Dxe/Inode.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 33 +-=
=C2=A0Features/Ext4Pkg/Ext4Dxe/Partition.c=C2=A0 |=C2=A0 12 +-
=C2= =A0Features/Ext4Pkg/Ext4Dxe/Superblock.c |=C2=A0 20 +-
=C2=A016 files ch= anged, 640 insertions(+), 487 deletions(-)
=C2=A0create mode 100644 Feat= ures/Ext4Pkg/Ext4Dxe/BlockMap.c
=C2=A0delete mode 100644 Features/Ext4Pk= g/Ext4Dxe/Crc16.c
=C2=A0delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc3= 2c.c

--
2.35.1



--

Pedro Fa= lcato



--

Pedro Falcato=



--

Pedro Falcato



--
Pedro Falcato
--000000000000e707ee05e15555d2--