From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mx.groups.io with SMTP id smtpd.web11.40051.1680213030594891270 for ; Thu, 30 Mar 2023 14:50:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Y76aNfSr; spf=pass (domain: gmail.com, ip: 209.85.216.41, mailfrom: pedro.falcato@gmail.com) Received: by mail-pj1-f41.google.com with SMTP id om3-20020a17090b3a8300b0023efab0e3bfso23388724pjb.3 for ; Thu, 30 Mar 2023 14:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680213030; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fMM7XpKq0l6aIBQykNHlhyEQSxFo9GN95p/QSmMnBUw=; b=Y76aNfSrhfjAzkYWlSSPWxyiowKG0TIub0nJYbp5V84pBHdwl3OGv5XebpXbF4ueS8 foXJi4lc/kXo5KJlXTLwj7BJbddCPEqzASn7r8MDfXKD7c/BN7lt23k3GBm8AhQS8wqZ kpm+RfWgc6ugPMIHKyr9T1/GGjJi6Ns2iMlkOu3H6UZai9obpwp5ANiK86fAMjnx61Vi DND/CMLpLOc6knpC6UsA2VL7lnI2QVh2vUZKooquSQoG+bkksumn+HGuKMVGBdfv+CAX 7A0aaYJFdxLdbYC+gmDmYhveQMn0LWtkSdrH6qW1M84Ekkf8bDQMrJd2HQ77z1RHR5oh bwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680213030; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fMM7XpKq0l6aIBQykNHlhyEQSxFo9GN95p/QSmMnBUw=; b=ioNyodWrmnsBkgueIUd/CYAvw8lXg1m/caJgcCEdyVuFOAq5yTPOOkoAUUlub9RHzW fA5spKqfnva6ANuhXhZw9/FZXUCRYLr51JCcv8AMRAg/xgHIGwMtefCmcXKo39FEQneN 54+NkYQJG5FleliIsg8fhv7Vo554HuVo7v6mVkDO3j+ixygp9r0kusxel5ygJyTfxMwf u9HCf+FtzLpf0hOwQhadknVB52o/SqJ6iNgpzuNQ8rU1Z0rVLdSVadvgoil3Ybr1Bxg4 o6tLrsqmWEs2izYj5CGyGtw+P+rIIkG0O9fXr/YQy8EFjsiiiBzY1vpk6mZ+8xEE9TXs dp5w== X-Gm-Message-State: AAQBX9flD/rwCMsxZjAB0L6ja0Grin1bZoL8pukm85thmg+2QY1zIKPX 3KgIh/rTudhPI2oqGK5b9fXGp/cj10ymZCeOR2LmNNNXkgY= X-Google-Smtp-Source: AKy350YSaP7BQY7i51vdnJBXpEi+zybwLgqp5YYaP9o8GYxmTdaDFkWCD+83h33zR8/bIDW0bCc9889KIDEx2xkjSAo= X-Received: by 2002:a17:90a:17ed:b0:236:6e4c:8a1e with SMTP id q100-20020a17090a17ed00b002366e4c8a1emr7559586pja.1.1680213029703; Thu, 30 Mar 2023 14:50:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Thu, 30 Mar 2023 22:50:18 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/2] Support FDT library. To: devel@edk2.groups.io, benny.lin@intel.com Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Sean Brogan , Michael Kubacki Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 30, 2023 at 6:13=E2=80=AFPM Benny Lin wro= te: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4392 > Add FDT support in EDK2 by submodule 3rd party libfdt > (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt) > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Sean Brogan > Cc: Michael Kubacki > Signed-off-by: Benny Lin > > Benny Lin (2): > MdePkg: Support FDT library. > .pytool: Support FDT library. > > .gitmodules | 3 + > .pytool/CISettings.py | 2 + > MdePkg/Include/Library/FdtLib.h | 300 ++++++++++++++++++++++ > MdePkg/Library/BaseFdtLib/BaseFdtLib.inf | 62 +++++ > MdePkg/Library/BaseFdtLib/BaseFdtLib.uni | 14 + > MdePkg/Library/BaseFdtLib/FdtLib.c | 284 ++++++++++++++++++++ > MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 102 ++++++++ > MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 138 ++++++++++ > MdePkg/Library/BaseFdtLib/libfdt | 1 + > MdePkg/Library/BaseFdtLib/limits.h | 10 + > MdePkg/Library/BaseFdtLib/stdbool.h | 10 + > MdePkg/Library/BaseFdtLib/stddef.h | 10 + > MdePkg/Library/BaseFdtLib/stdint.h | 10 + > MdePkg/Library/BaseFdtLib/stdlib.h | 10 + > MdePkg/Library/BaseFdtLib/string.h | 10 + > MdePkg/MdePkg.ci.yaml | 17 +- > MdePkg/MdePkg.dec | 4 + > MdePkg/MdePkg.dsc | 2 + > ReadMe.rst | 1 + > 19 files changed, 988 insertions(+), 2 deletions(-) > create mode 100644 MdePkg/Include/Library/FdtLib.h > create mode 100644 MdePkg/Library/BaseFdtLib/BaseFdtLib.inf > create mode 100644 MdePkg/Library/BaseFdtLib/BaseFdtLib.uni > create mode 100644 MdePkg/Library/BaseFdtLib/FdtLib.c > create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtSupport.h > create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtWrapper.c > create mode 160000 MdePkg/Library/BaseFdtLib/libfdt > create mode 100644 MdePkg/Library/BaseFdtLib/limits.h > create mode 100644 MdePkg/Library/BaseFdtLib/stdbool.h > create mode 100644 MdePkg/Library/BaseFdtLib/stddef.h > create mode 100644 MdePkg/Library/BaseFdtLib/stdint.h > create mode 100644 MdePkg/Library/BaseFdtLib/stdlib.h > create mode 100644 MdePkg/Library/BaseFdtLib/string.h > > -- > 2.39.1.windows.1 There's already a copy of libfdt plus "FdtLib" at https://github.com/tianocore/edk2/tree/master/EmbeddedPkg/Library/FdtLib. Please figure out what to do with it. It's an old copy and has been accidentally uncrustify'd so it's probably a good idea to at least ditch that specific copy for a git submodule. Also, NAK to Yet Another libc Implementation (and not a particularly good one at that). --=20 Pedro