public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: Jeff Brasen <jbrasen@nvidia.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Subject: Re: [PATCH v3 0/2] ExtPkg Updates
Date: Sat, 11 Sep 2021 02:02:41 +0100	[thread overview]
Message-ID: <CAKbZUD1u-86pGnPwcZfRwjsC+jAN7TTYAA2CX_NeiPHKTaX6LQ@mail.gmail.com> (raw)
In-Reply-To: <cover.1631311760.git.jbrasen@nvidia.com>

Pushed as to edk2-platforms as
71f334393361d53e805fe9a01e2cf7bc43e909ce and
7872c983ed45de4c9e4e9295aa249e1369913094, respectively.

On Fri, Sep 10, 2021 at 11:11 PM Jeff Brasen <jbrasen@nvidia.com> wrote:
>
> I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had.
>
> Had a couple updates to propose
>
> 1. Changed the implementation of the binding protocol to both check if the driver is already bound
> to the partition as well as added a really quick check to validate the magic value in supported.
> This improves performance when you have a large number of non-ext4 partitions on the system.
>
> 2. As we are planning on using this for boot support we want to support unclean filesystem states in
> case the user doesn't reset cleanly. I added a check if the recovery journal is present and if so treat
> the filesystem as read-only (I know the driver is only RO at this point, but figured if you added write
> support prior to recovery journal support we would want that). With this everything seems to work great.
> I can add this under a FeaturePcd if desired as well.
>
> Change log
>
> v3 - Removed goto flow on binding supported failures
>      Minor code review comments
> v2 - Minor code review comments
> v1 - Initial revision
>
> Jeff Brasen (2):
>   Ext4Pkg: Improve Ext4IsBindingSupported() behavior
>   Ext4Pkg: Support uncleanly unmounted filesystems
>
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 14 +++++++
>  Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c    | 54 +++++++++++++++++++++------
>  Features/Ext4Pkg/Ext4Dxe/Superblock.c | 46 +++++++++++++++++++++--
>  3 files changed, 99 insertions(+), 15 deletions(-)
>
> --
> 2.17.1
>


-- 
Pedro Falcato

      parent reply	other threads:[~2021-09-11  1:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 22:11 [PATCH v3 0/2] ExtPkg Updates Jeff Brasen
2021-09-10 22:11 ` [PATCH v3 1/2] Ext4Pkg: Improve Ext4IsBindingSupported() behavior Jeff Brasen
2021-09-12 10:40   ` [edk2-devel] " Marvin Häuser
2021-09-13 16:35     ` Pedro Falcato
2021-09-10 22:11 ` [PATCH v3 2/2] Ext4Pkg: Support uncleanly unmounted filesystems Jeff Brasen
2021-09-11  0:59 ` [PATCH v3 0/2] ExtPkg Updates Pedro Falcato
2021-09-11  1:02 ` Pedro Falcato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKbZUD1u-86pGnPwcZfRwjsC+jAN7TTYAA2CX_NeiPHKTaX6LQ@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox