From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by mx.groups.io with SMTP id smtpd.web09.1766.1631322175158647389 for ; Fri, 10 Sep 2021 18:02:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Je/fvSpD; spf=pass (domain: gmail.com, ip: 209.85.217.46, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f46.google.com with SMTP id d6so3178437vsr.7 for ; Fri, 10 Sep 2021 18:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L7KzIgv8uTdc89g4mBUfMC/j4e6vyC1JhnDKwBtcRII=; b=Je/fvSpDfKOZi6/UUIGODrBj7Sv+RykkF2ARd1zk2Y/69fZRE+g3ncrBGMMDYtaekk n4AZ/fcsQ9P/nCs4Eq9Dv+lR0Rowx8xIF6B6XPaN/FC75N/XqjrEivrboZIItWCa/KmU HKQP7Jyj0PL/Wj0FdQItJFvn2PcWGS7Cyh71R9ynO8tQN3ohero9OusaaLQ7EU6Ssmbv wr/gz1utIVlOUfmgkWo9BCz/kZp5pzU3z/IyEUVlFF65DPbq/9XhS3CZPXKq6Ud9Fk0V 71vawBqrNmrxdI07MCC26pr2r7qBVrmMXe+2iVuHopByzQ0fWq9MPVdruub1bmhLo2ss Juow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L7KzIgv8uTdc89g4mBUfMC/j4e6vyC1JhnDKwBtcRII=; b=wxPZBSRl1P7OJc5Ma/0W5iGq1KRfTVeeeQXHkHT4AgQYLhqhkyYuV9pD5g/yc9QuId B+E2Y081L03z+nc73vdW7LBnCvzdUpN69PqnkCx/817UQs8I8aAf43649KnHXzxsu5FL CYXw8mQOe/fy0BA6WYfEFatHJKJ+T5vmO641UGBqJWQlTeY07r2uEsoReKv9g7xcQMZ/ gyrDQuYHwOJ4xNU0JD1VHlPRFQIaeOtLELQ/yGcCZqP/8LD1RDtA6Y/Y4iPSPyMA69Nr v/S27P8acJzPMsI/PL6/SfJqIvrPHd875KMV6O/J88lFYMGbsHQe20meaLUdhSMsRGrM geeQ== X-Gm-Message-State: AOAM531FOicIqSkUOWohlYfj4Tz69Etx3OWUyLvaulu/l0rGodJx28ec AZf4oklYOeZ7auxfhlNhwMwt5HkVei4htbpHrP1edb7k0KPRlw== X-Google-Smtp-Source: ABdhPJw+s26PFYf9xENd1XbXB8ga7Czi8hgmhasxBBUbz55J0S8ankCM9B3v13S+tSWx/Bk/X76Bm8HiCSRC0n9KV20= X-Received: by 2002:a05:6102:483:: with SMTP id n3mr150968vsa.42.1631322174269; Fri, 10 Sep 2021 18:02:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Sat, 11 Sep 2021 02:02:41 +0100 Message-ID: Subject: Re: [PATCH v3 0/2] ExtPkg Updates To: Jeff Brasen Cc: edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" Pushed as to edk2-platforms as 71f334393361d53e805fe9a01e2cf7bc43e909ce and 7872c983ed45de4c9e4e9295aa249e1369913094, respectively. On Fri, Sep 10, 2021 at 11:11 PM Jeff Brasen wrote: > > I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had. > > Had a couple updates to propose > > 1. Changed the implementation of the binding protocol to both check if the driver is already bound > to the partition as well as added a really quick check to validate the magic value in supported. > This improves performance when you have a large number of non-ext4 partitions on the system. > > 2. As we are planning on using this for boot support we want to support unclean filesystem states in > case the user doesn't reset cleanly. I added a check if the recovery journal is present and if so treat > the filesystem as read-only (I know the driver is only RO at this point, but figured if you added write > support prior to recovery journal support we would want that). With this everything seems to work great. > I can add this under a FeaturePcd if desired as well. > > Change log > > v3 - Removed goto flow on binding supported failures > Minor code review comments > v2 - Minor code review comments > v1 - Initial revision > > Jeff Brasen (2): > Ext4Pkg: Improve Ext4IsBindingSupported() behavior > Ext4Pkg: Support uncleanly unmounted filesystems > > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 14 +++++++ > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 54 +++++++++++++++++++++------ > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 46 +++++++++++++++++++++-- > 3 files changed, 99 insertions(+), 15 deletions(-) > > -- > 2.17.1 > -- Pedro Falcato