From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>, marietto2008@gmail.com
Cc: "Rebecca Cran" <rebecca@bsdio.com>,
"Corvin Köhne" <C.Koehne@beckhoff.com>,
"Peter Grehan" <grehan@freebsd.org>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Jiewen Yao" <jiewen.yao@intel.com>,
"Jordan Justen" <jordan.l.justen@intel.com>,
"FreeBSD Virtualization" <freebsd-virtualization@freebsd.org>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg
Date: Fri, 8 Apr 2022 20:59:21 +0100 [thread overview]
Message-ID: <CAKbZUD1xT80g-TCn=RsZ9S_Gum8YBb4Ua9KaFZhb3LAk6jqanQ@mail.gmail.com> (raw)
In-Reply-To: <CA+1FSiiYSVb1ZJYXQURpDNUe-qY9Bm_hvC6iGak_M465nP+PiQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]
Is this a laptop? Things may not work there because video output is done
through the Intel GPU, even when using the Nvidia GPU, although I'm not
sure.
On Fri, Apr 8, 2022 at 6:49 PM Mario Marietto <marietto2008@gmail.com>
wrote:
> im trying to test the patch on my pc,that has two graphic cards,the intel
> coffee lake and the nvidia. i tried to start the pc from the nvidia card
> and ive configured the xorg.conf file giving the proper bus id value. in
> addition ive loaded the kernel.ko file from the boot loader.conf i have
> removed the intel and the drm drivers used by the Intel graphic card.
> unfortunately my pc wont boot from the nvidia card. my mouse and keyboard
> freezes just before the desktop manager (xfce and kde5) starts.
>
> Il gio 7 apr 2022, 18:46 Rebecca Cran <rebecca@bsdio.com> ha scritto:
>
>> I've just looked at the patch and it looks good, though I haven't tested
>> it.
>>
>> So yes, please add:
>>
>>
>> Acked-by: Rebecca Cran <rebecca@bsdio.com>
>>
>>
>> On 4/6/22 23:24, Corvin Köhne wrote:
>> > Hi Peter and Rebecca,
>> >
>> > thanks for your feedback. This patch is backward compatible. It checks
>> > if QemuFwCfg is available and if QemuFwCfg is missing it falls
>> > back to BhyveFwCtl.
>> >
>> > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the
>> > commit message?
>> >
>> >
>> > Thanks
>> > Corvin
>> >
>> > Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans
>> Beckhoff
>> > Registered office: Verl, Germany | Register court: Guetersloh HRA 7075
>> >
>> >
>> >
>>
>>
>
>
--
Pedro Falcato
[-- Attachment #2: Type: text/html, Size: 2448 bytes --]
next prev parent reply other threads:[~2022-04-08 19:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 10:14 [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Corvin Köhne
2022-04-06 7:00 ` Corvin Köhne
2022-04-06 17:40 ` [edk2-devel] " Rebecca Cran
2022-04-06 17:45 ` Rebecca Cran
2022-04-06 19:52 ` Peter Grehan
2022-04-07 5:24 ` Corvin Köhne
2022-04-07 16:46 ` Rebecca Cran
2022-04-07 16:56 ` Mario Marietto
2022-04-08 19:59 ` Pedro Falcato [this message]
2022-04-07 22:57 ` Peter Grehan
2022-04-08 5:54 ` Corvin Köhne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKbZUD1xT80g-TCn=RsZ9S_Gum8YBb4Ua9KaFZhb3LAk6jqanQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox