From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by mx.groups.io with SMTP id smtpd.web12.1474.1649447974084470827 for ; Fri, 08 Apr 2022 12:59:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=iISIvtnh; spf=pass (domain: gmail.com, ip: 209.85.217.49, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f49.google.com with SMTP id l21so4446552vsm.1 for ; Fri, 08 Apr 2022 12:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cPPuHJ9f5p67WW/Sw/Y4bqED9Q8UDWFWK7FeSoW5ZRQ=; b=iISIvtnhXWEh8HWV6hqlVvEbIOIYw6LbWOW9MQg8NU6kbVzAYbgqD+wJuMOflO0138 0EA+7FXulLlaVPCsLf2UER7uOlIbeX9N6audbiI//ymTNlnfeyFKp8xMbuhlay7Hu8Hm g2jrya0atk2LkDZ67nbSLMpvpWFWtXHcdoQCrHQao42w+T3hsBZ2TSmf9HdB4LQATsDV scNBVPMWjRvTGbKRXrLJHPj3UtyVjOEjVUi2zi/q80ajE4eCLbBARJZrBXNRsDRjxQvI Vf3e9MLFwSU4IR0f3blvQy7DgtanVkmq5V5ZHDIUj1D6vxMU0zPeGPp21fdvGcNpGNQK 47Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cPPuHJ9f5p67WW/Sw/Y4bqED9Q8UDWFWK7FeSoW5ZRQ=; b=Yg5v1ocETDXaq4WVdZ8DJlj0PhBhJXhXic2KoRC7VzaaGjcKUJ08zhh9BMZwf1r0o7 hsbIL2vhZxPoMDz8NK19w48YAWl/sr5ZDLR9q+JumY9NeNZBh4DLXiQ8KNuRyQfP4JIi vPcm3ph/PSwKgnAo6VmelTi0+pg//b+fmbJkMOoInE+CpUrvtsD33AVXBv4OnVVH2FH+ dLfjXiEmU84c7JRDwOvt4B2oeqHpY09wHy4VwOa335bc5vfrfeC9HAt3ml1JQFBMD0aA QemnQTxd91cYG/q24aXZvOXyTkzvpE0P0dOZrTh+ZtYtOv8reuk01bi+vccH0JBUJIno gvmg== X-Gm-Message-State: AOAM5339UGKx12Pczpb5ZUO3IHagYhcobOwZMA6/FpSQfCsyT+q2v26B p/QvvUGobVpxWJSnyJMJiFdJiUte3lqYL5aJPKpewO3j960= X-Google-Smtp-Source: ABdhPJyz5IovJkfmSSLF86KyTXF4YdzcE6nbfKWqDNx/gzuGw6okLNWKJ3qAaKHoZWVyo7V48PLbibiNerXRBkGUddM= X-Received: by 2002:a67:b24d:0:b0:327:dd90:ec43 with SMTP id s13-20020a67b24d000000b00327dd90ec43mr6707600vsh.15.1649447973078; Fri, 08 Apr 2022 12:59:33 -0700 (PDT) MIME-Version: 1.0 References: <20220329101417.617-1-c.koehne@beckhoff.com> <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com> In-Reply-To: From: "Pedro Falcato" Date: Fri, 8 Apr 2022 20:59:21 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg To: edk2-devel-groups-io , marietto2008@gmail.com Cc: Rebecca Cran , =?UTF-8?Q?Corvin_K=C3=B6hne?= , Peter Grehan , Ard Biesheuvel , Jiewen Yao , Jordan Justen , FreeBSD Virtualization , Gerd Hoffmann Content-Type: multipart/alternative; boundary="00000000000082cba905dc2a0802" --00000000000082cba905dc2a0802 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Is this a laptop? Things may not work there because video output is done through the Intel GPU, even when using the Nvidia GPU, although I'm not sure. On Fri, Apr 8, 2022 at 6:49 PM Mario Marietto wrote: > im trying to test the patch on my pc,that has two graphic cards,the intel > coffee lake and the nvidia. i tried to start the pc from the nvidia card > and ive configured the xorg.conf file giving the proper bus id value. in > addition ive loaded the kernel.ko file from the boot loader.conf i have > removed the intel and the drm drivers used by the Intel graphic card. > unfortunately my pc wont boot from the nvidia card. my mouse and keyboard > freezes just before the desktop manager (xfce and kde5) starts. > > Il gio 7 apr 2022, 18:46 Rebecca Cran ha scritto: > >> I've just looked at the patch and it looks good, though I haven't tested >> it. >> >> So yes, please add: >> >> >> Acked-by: Rebecca Cran >> >> >> On 4/6/22 23:24, Corvin K=C3=B6hne wrote: >> > Hi Peter and Rebecca, >> > >> > thanks for your feedback. This patch is backward compatible. It checks >> > if QemuFwCfg is available and if QemuFwCfg is missing it falls >> > back to BhyveFwCtl. >> > >> > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the >> > commit message? >> > >> > >> > Thanks >> > Corvin >> > >> > Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Han= s >> Beckhoff >> > Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 >> > >> > >> > >> >>=20 > > --=20 Pedro Falcato --00000000000082cba905dc2a0802 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Is this a laptop? Things may not work there because video = output is done through the Intel GPU, even when using the Nvidia GPU, altho= ugh I'm not sure.

On Fri, Apr 8, 2022 at 6:49 PM Mario Marietto <= marietto2008@gmail.com> wr= ote:
im trying to test the patch on my pc,that has two graphic cards,the = intel coffee lake and the nvidia. i tried to start the pc from the nvidia c= ard and ive configured the xorg.conf file giving the proper bus id value. i= n addition ive loaded the kernel.ko file from the boot loader.conf i have r= emoved the intel and the drm drivers used by the Intel graphic card. unfort= unately my pc wont boot from the nvidia card. my mouse and keyboard freezes= just before the desktop manager (xfce and kde5) starts.

Il gio 7 apr 2022, = 18:46 Rebecca Cran <rebecca@bsdio.com> ha scritto:
I've just looked at the patch and it looks goo= d, though I haven't tested it.

So yes, please add:


Acked-by: Rebecca Cran <rebecca@bsdio.com>


On 4/6/22 23:24, Corvin K=C3=B6hne wrote:
> Hi Peter and Rebecca,
>
> thanks for your feedback. This patch is backward compatible. It checks=
> if QemuFwCfg is available and if QemuFwCfg is missing it falls
> back to BhyveFwCtl.
>
> So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > commit message?
>
>
> Thanks
> Corvin
>
> Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys.= Hans Beckhoff
> Registered office: Verl, Germany | Register court: Guetersloh HRA 7075=
>
>
>

=20



--
Pedro Falcato
--00000000000082cba905dc2a0802--