From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by mx.groups.io with SMTP id smtpd.web11.1667.1631322004810441055 for ; Fri, 10 Sep 2021 18:00:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=h/MDpxyL; spf=pass (domain: gmail.com, ip: 209.85.217.52, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f52.google.com with SMTP id s25so3165846vsa.9 for ; Fri, 10 Sep 2021 18:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AbUAcGyrcslJvYZhBpv05NoAHyoEeqh3+kXvCNAR12I=; b=h/MDpxyLi0SSSjoeS9/yY9ulM0/BcgWd5x9825gTTE6wJoEPtK3sMj6A37Ji8wBDB+ O+Ca9Jko39yPQa+cjIEquQx7kFljCRHVChVOa3tGFfgNKnSacYWsXWA1YURg8eVvm9Kv o4uD46BYUcSjF8ixx/zi0c9PecHoTyy/k+7/Br0DGERpVteks1RfRL/ZT4PgeUJSe8EG W4Jt8dpemWrkPjZ7BavFaWMEwV5EdKA1Y4/+hh9FcOC5fjjhnM6yb/LdOP0rA1L/pDYa rFKLBS8JEsYzW+sg+9h2ip7ahWHZv09T5C/Lo6ZrJMBFiuaQ4X4L+EkD7jq74klRm/0i 0uJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AbUAcGyrcslJvYZhBpv05NoAHyoEeqh3+kXvCNAR12I=; b=L+C7wvELVtxFOtvnS7xv/eTxqIErAl/v92tZLG6CQqWDJjf+EPVJdqr5jV2URVwqyY gl5u3qNxWSaInChUY5Ymq687bHPoMSck3Wx9V63JtlnSMa8uerqVOmu+8b+6bcxKTwM8 tGWMxkhyrA0S5qmxdClMhu5UO4gq4BzyMIMZGADDnoHC/eAXO9RJNphruTTpii1HBtAz IAkhtV2PsvAKMp0oO2KI8qIZIpOSQ7Ssi+FyUgL2hr1ZiCYUlx9OKrIQIrVayu8raMWq UW78MSRDSbe3vXRsbu5KxJE/bIEu7bHVi9whLasR8zApTjZhltzNaxC2Vb/SGUyBrvAe fDXA== X-Gm-Message-State: AOAM5321MuFr5sKVIefiFHDs99AHkCEyrYldXH+tMmcICP8hq58sJ/8x xe8glII3/cAo/g9NKKdB0YXMrrTXqcmKZ0hVrns= X-Google-Smtp-Source: ABdhPJx6GKhrBQXqxBCkNAJ+TAyHeAbFKj++yNUCyYrQze/I6srBTqqKFQC/ofvlWz3KeXKl6pBr1e9Tk8q1SEMaXoU= X-Received: by 2002:a67:ee45:: with SMTP id g5mr164939vsp.56.1631322003861; Fri, 10 Sep 2021 18:00:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Sat, 11 Sep 2021 01:59:52 +0100 Message-ID: Subject: Re: [PATCH v3 0/2] ExtPkg Updates To: Jeff Brasen Cc: edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" Series Reviewed-by: Pedro Falcato On Fri, Sep 10, 2021 at 11:11 PM Jeff Brasen wrote: > > I have been using the new Ext4Pkg and been pretty successful and it is solving a use case we had. > > Had a couple updates to propose > > 1. Changed the implementation of the binding protocol to both check if the driver is already bound > to the partition as well as added a really quick check to validate the magic value in supported. > This improves performance when you have a large number of non-ext4 partitions on the system. > > 2. As we are planning on using this for boot support we want to support unclean filesystem states in > case the user doesn't reset cleanly. I added a check if the recovery journal is present and if so treat > the filesystem as read-only (I know the driver is only RO at this point, but figured if you added write > support prior to recovery journal support we would want that). With this everything seems to work great. > I can add this under a FeaturePcd if desired as well. > > Change log > > v3 - Removed goto flow on binding supported failures > Minor code review comments > v2 - Minor code review comments > v1 - Initial revision > > Jeff Brasen (2): > Ext4Pkg: Improve Ext4IsBindingSupported() behavior > Ext4Pkg: Support uncleanly unmounted filesystems > > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 14 +++++++ > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 54 +++++++++++++++++++++------ > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 46 +++++++++++++++++++++-- > 3 files changed, 99 insertions(+), 15 deletions(-) > > -- > 2.17.1 > -- Pedro Falcato