From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Lee, Crystal" <crystalLee@ami.com.tw>
Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap
Date: Thu, 18 Jan 2024 16:18:39 +0000 [thread overview]
Message-ID: <CAKbZUD22GwBpuC1jnibxtGNhVYHh7bkLZ1=K2B0=hr9u6d6Qyg@mail.gmail.com> (raw)
In-Reply-To: <PH0PR11MB5048E9AC85ABC4C8C2E1E4B790712@PH0PR11MB5048.namprd11.prod.outlook.com>
On Thu, Jan 18, 2024 at 2:21 AM Liu, Zhiguang <zhiguang.liu@intel.com> wrote:
>
> Thanks Laszlo for the comment, I will send a new version of patch to fix this.
>
> Also include Pedro to see if Pedro have more comments.
The patch's subject really doesn't describe the fix (describe what you
did in the patch/commit, don't describe what you're fixing)
I also liked your IsFlushTlbNeeded suggestion (it would help clarify
what you actually want to keep track of).
--
Pedro
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113998): https://edk2.groups.io/g/devel/message/113998
Mute This Topic: https://groups.io/mt/103781942/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-18 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 8:09 [edk2-devel] [PATCH v2] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap Zhiguang Liu
2024-01-17 10:51 ` Laszlo Ersek
2024-01-18 2:21 ` Zhiguang Liu
2024-01-18 16:18 ` Pedro Falcato [this message]
2024-01-19 1:48 ` Zhiguang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKbZUD22GwBpuC1jnibxtGNhVYHh7bkLZ1=K2B0=hr9u6d6Qyg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox