From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4E69E740032 for ; Thu, 18 Jan 2024 16:18:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+nCzzQmcZgurV3PE9RDsopds3b2zMZkUgs55DL6lDOQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705594732; v=1; b=GaAxgRsPteBv6pATK0pZRTW+MwIMlqUUhzJei+ks6FxoSUcUGavt1aNxm5BfSdOlrv9McMXJ 9aoTgzs3DGWlrl6+8n448g80VR+4MLhThsNUyU5rtRr5Gn60BjAtiYeYpOZVuT4EtksWiXpJvl0 ATbtEjagLz+4kC9xLqQwv6Nc= X-Received: by 127.0.0.2 with SMTP id 83bRYY7687511xpGqkzs32ov; Thu, 18 Jan 2024 08:18:52 -0800 X-Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by mx.groups.io with SMTP id smtpd.web10.16051.1705594731320521952 for ; Thu, 18 Jan 2024 08:18:51 -0800 X-Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-7ce9defc4c2so2238553241.0 for ; Thu, 18 Jan 2024 08:18:51 -0800 (PST) X-Gm-Message-State: YIyJjL7wVYO22GKPFsZPbxLRx7686176AA= X-Google-Smtp-Source: AGHT+IGFM6kEj1rbdkuCo9x/4doygbKPZhj/V1G8GpWtg9TI+DKCkQnvY7f/84DoSC5OvruUTAZ7drufARan0I377+U= X-Received: by 2002:a05:6122:4692:b0:4b6:e7dd:db1 with SMTP id di18-20020a056122469200b004b6e7dd0db1mr693848vkb.31.1705594730329; Thu, 18 Jan 2024 08:18:50 -0800 (PST) MIME-Version: 1.0 References: <20240117080954.1414-1-zhiguang.liu@intel.com> In-Reply-To: From: "Pedro Falcato" Date: Thu, 18 Jan 2024 16:18:39 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap To: "Liu, Zhiguang" Cc: "devel@edk2.groups.io" , "lersek@redhat.com" , "Ni, Ray" , "Kumar, Rahul R" , Gerd Hoffmann , "Lee, Crystal" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GaAxgRsP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Jan 18, 2024 at 2:21=E2=80=AFAM Liu, Zhiguang wrote: > > Thanks Laszlo for the comment, I will send a new version of patch to fix = this. > > Also include Pedro to see if Pedro have more comments. The patch's subject really doesn't describe the fix (describe what you did in the patch/commit, don't describe what you're fixing) I also liked your IsFlushTlbNeeded suggestion (it would help clarify what you actually want to keep track of). -- Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113998): https://edk2.groups.io/g/devel/message/113998 Mute This Topic: https://groups.io/mt/103781942/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-