From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mx.groups.io with SMTP id smtpd.web11.2616.1675873973456760465 for ; Wed, 08 Feb 2023 08:32:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=A5/1VW8U; spf=pass (domain: gmail.com, ip: 209.85.216.54, mailfrom: pedro.falcato@gmail.com) Received: by mail-pj1-f54.google.com with SMTP id j1so13043341pjd.0 for ; Wed, 08 Feb 2023 08:32:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Gwhan4G/tCR9qUGrW2EmzFMRnkr3a1aa7XDEcYbiSy0=; b=A5/1VW8UU16VDdW7GxonOPbdIZCQv9LaTH62XMf0JHoPerdSC2oaWetlogZLAXQ/0N q3zxHMRBbWf/BAn4erF0bCLsmhZ6KuBRQ5tbCkSWS2LpYpX7btl5S1S4lYhg6ZYaBZyP kXV1dHyIm7AWo2mAT3CwBhOr1/3I6bpQJv5Yjq5ZL6ZhpOIjwXufwaX1IDqj86iFpsrd HMSfxu2O3s5raSlXIwfg2wUO3cX2vu0AaqEopPcJgSjCnxqrRT0v9TAOV4g/bEycNgI1 /YYmhYBwHDL+z+A5q3IqNCyd2ulrvBAL9VV/YUs0rfYkWizvyRMmnXY1wu2eYzNBqE1U UThw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gwhan4G/tCR9qUGrW2EmzFMRnkr3a1aa7XDEcYbiSy0=; b=sp+kTuKNsoK0kd2goeLs3ZTqrXXDSX8RGAKq0jNL8OpLHL6fIlOg9QIWAAgG8agfdO rGQL2Rch0N+bQ3F2jtUN7uvAJBuNYEwLtQgX8wltZxE1ptZl7CQSA35opuqpzZ3MIUkh e60a32nQBfZFYim3mFwofgllVkVFACHfad8AiV4elvBIzdS1iT8d1rC8F9eNE4zJcB8M hXvHKikrEoEV+49euzYjS2zZfkDpb2F3j0kkM6+yWLzmaHSpesT894LGdfNAz2N1KNaq HL61OKZX5vI9ySRLRylBDFlDGxFf6wSYX50+NjQnqxsPuEz8s3crhN/SN9SIM7J6k9Hv DN3g== X-Gm-Message-State: AO0yUKUOL/QkMuluFo/zpOvNCHQSKVSjKPHFD0iCoosHgzX/aOaS9Zdv p7jfPdS7CdrZDTqpBNMa7i3QjS/N0IptmoMG5w0= X-Google-Smtp-Source: AK7set9jiQthWDsAv6mkVYFteXA8E+HjhQbpl0uOaJtrZaLv0ToBSrQJLkX9S1cjYJ1cyAXvgzZWPDcmvpVeEy7LMUk= X-Received: by 2002:a17:902:f7c6:b0:199:2236:ae67 with SMTP id h6-20020a170902f7c600b001992236ae67mr1995391plw.14.1675873972855; Wed, 08 Feb 2023 08:32:52 -0800 (PST) MIME-Version: 1.0 References: <20230202102133.51606-1-savvamtr@gmail.com> In-Reply-To: <20230202102133.51606-1-savvamtr@gmail.com> From: "Pedro Falcato" Date: Wed, 8 Feb 2023 16:32:41 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH v4 00/12] Ext4Pkg: Code correctness and security improvements To: Savva Mitrofanov Cc: devel@edk2.groups.io, =?UTF-8?Q?Marvin_H=C3=A4user?= , Vitaly Cheptsov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable With some minor fixups[1], for the series: Reviewed-by: Pedro Falcato and pushed to edk2-platforms HEAD. Thanks, Pedro [1] Fixed up some commit messages to be imperative, added my Rb, fixed a status return in Extents.c for ("Ext4Pkg: Correct integer overflow check logic in DiskUtil"), and removed a comment wrt ("Ext4Pkg: Add inode number validity check"); you misinterpreted what I told you off-list, I meant that we shouldn't judge what operating systems put as inodes as long as it doesn't jeopardize the driver and it's correctness - so doing > 0 is good, banning 1 for no reason is not - this doesn't mean we're going to start using inode 1 any time soon. On Thu, Feb 2, 2023 at 10:21 AM Savva Mitrofanov wrote= : > > Hi all, > > In v4 I rebased patches according upstream. Also in this revision I corre= cted > all remarks and comments from v3. > > This patchset fixes several code problems found by fuzzing Ext4Dxe like > buffer and integer overflows, memory leaks, logic bugs and so on. > > REF: https://github.com/savvamitrofanov/edk2-platforms/tree/master > > Cc: Marvin H=C3=A4user > Cc: Pedro Falcato > Cc: Vitaly Cheptsov > > Savva Mitrofanov (12): > Ext4Pkg: Fix memory leak in Ext4RetrieveDirent > Ext4Pkg: Fix incorrect checksum metadata feature check > Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group > Ext4Pkg: Add inode number validity check > Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock > Ext4Pkg: Corrects integer overflow check logic in DiskUtil > Ext4Pkg: Check that source file is directory in Ext4OpenInternal > Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName > Ext4Pkg: Add missing exit Status in Ext4OpenDirent > Ext4Pkg: Fixes build on MSVC > Ext4Pkg: Filter out directory entry names containing \0 as invalid > Ext4Pkg: Corrects memory leak in Ext4ReadSlowSymlink > > Features/Ext4Pkg/Ext4Pkg.dsc | 2 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 13 +++++- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 26 ++++++++++++ > Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 5 +++ > Features/Ext4Pkg/Ext4Dxe/Directory.c | 42 ++++++++++++-------- > Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 18 +++++++-- > Features/Ext4Pkg/Ext4Dxe/Extents.c | 15 +++++-- > Features/Ext4Pkg/Ext4Dxe/File.c | 23 ++++++++--- > Features/Ext4Pkg/Ext4Dxe/Inode.c | 6 +-- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 16 ++++++-- > Features/Ext4Pkg/Ext4Dxe/Symlink.c | 13 +++--- > 11 files changed, 134 insertions(+), 45 deletions(-) > > -- > 2.39.1 > --=20 Pedro