From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: Dhaval Sharma <dhaval@rivosinc.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>,
devel@edk2.groups.io, Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Andrei Warkentin <andrei.warkentin@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Yang Cheng <yangcheng.work@foxmail.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseCacheMaintenanceLib: RV64 replace asserts with logs
Date: Tue, 23 Jan 2024 13:23:04 +0000 [thread overview]
Message-ID: <CAKbZUD22oie26Hc=92Ntw-dbLBWywKpLd8iGAS8XXjYk41rcag@mail.gmail.com> (raw)
In-Reply-To: <CAAxYnhQwFnNQYdKcPOGufuP9zrdK1H8tp1eqMdE=nrSWTp4uuQ@mail.gmail.com>
On Tue, Jan 23, 2024 at 6:13 AM Dhaval Sharma <dhaval@rivosinc.com> wrote:
>
> Sunil,
> I thought "WriteBackDataCacheRange not supported" is more explicit over "CMO not available".
>
> @Pedro Falcato For the example you mentioned, is your concern more about someone not being able to notice the problem (that the system is non-coherent) at the time of development and later ending up with corrupted data during production? And you are suggesting that an Assert helps address that problem by making that problem more visible to the developer and a verbose warning does not?
Correct. And simply logging breaks the interface's contract by *not*
doing what is specified in the library's interface.
--
Pedro
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114195): https://edk2.groups.io/g/devel/message/114195
Mute This Topic: https://groups.io/mt/103805230/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-23 13:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 9:50 [edk2-devel] [PATCH v1 0/1] Replace asserts with logs for unimplemented cache ops Dhaval Sharma
2024-01-18 9:50 ` [edk2-devel] [PATCH v1 1/1] MdePkg/BaseCacheMaintenanceLib: RV64 replace asserts with logs Dhaval Sharma
2024-01-18 14:45 ` Laszlo Ersek
2024-01-18 15:58 ` Pedro Falcato
2024-01-18 16:40 ` Dhaval Sharma
2024-01-18 16:41 ` Yang Cheng
2024-01-19 5:08 ` Sunil V L
2024-01-19 5:36 ` Sunil V L
2024-01-23 6:12 ` Dhaval Sharma
2024-01-23 13:23 ` Pedro Falcato [this message]
2024-01-23 16:54 ` Sunil V L
2024-01-24 14:27 ` Dhaval Sharma
2024-01-24 14:33 ` Sunil V L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKbZUD22oie26Hc=92Ntw-dbLBWywKpLd8iGAS8XXjYk41rcag@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox