From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 127909417D0 for ; Tue, 23 Jan 2024 13:23:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QC3SPpKNPHE9MSLznucnQdb5+WstYKhEkDWfDm7Odxc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706016197; v=1; b=Xxnf7L13MtZH+RwxHSK4iRniv2F9t94No6HM1NIQvacVqhHQrB/L8Ub0AZL6T04kD86s/hww YS1Q3FjDekEzoDlXmBbjDLPEHxvs09EdA2oGGqBcHrgHCcn7joaUw0d6Bvndnly6fc2oX427OSQ U1y74HQ68LKwB6UUDaIBRbUA= X-Received: by 127.0.0.2 with SMTP id yLFDYY7687511xhzqmuyzJ4l; Tue, 23 Jan 2024 05:23:17 -0800 X-Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by mx.groups.io with SMTP id smtpd.web11.12012.1706016196685014937 for ; Tue, 23 Jan 2024 05:23:16 -0800 X-Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-4bd302ce55eso89197e0c.2 for ; Tue, 23 Jan 2024 05:23:16 -0800 (PST) X-Gm-Message-State: ukO6RuUl38FY9DdtKi4HKb0vx7686176AA= X-Google-Smtp-Source: AGHT+IG4v5zV/w8/5nouS4wYFdxPIqCQDSjYlRoi7KVObUn3rTZ0U4N1p6bxq9AOsMxbU7cVD02uTddCuLSLB3D/KwM= X-Received: by 2002:ac5:c927:0:b0:4b7:8794:17cf with SMTP id u7-20020ac5c927000000b004b7879417cfmr1603717vkl.18.1706016195618; Tue, 23 Jan 2024 05:23:15 -0800 (PST) MIME-Version: 1.0 References: <20240118095018.509362-1-dhaval@rivosinc.com> <20240118095018.509362-2-dhaval@rivosinc.com> In-Reply-To: From: "Pedro Falcato" Date: Tue, 23 Jan 2024 13:23:04 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseCacheMaintenanceLib: RV64 replace asserts with logs To: Dhaval Sharma Cc: Sunil V L , devel@edk2.groups.io, Liming Gao , Michael D Kinney , Zhiguang Liu , Andrei Warkentin , Laszlo Ersek , Yang Cheng Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Xxnf7L13; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Jan 23, 2024 at 6:13=E2=80=AFAM Dhaval Sharma = wrote: > > Sunil, > I thought "WriteBackDataCacheRange not supported" is more explicit over "= CMO not available". > > @Pedro Falcato For the example you mentioned, is your concern more about = someone not being able to notice the problem (that the system is non-cohere= nt) at the time of development and later ending up with corrupted data duri= ng production? And you are suggesting that an Assert helps address that pro= blem by making that problem more visible to the developer and a verbose war= ning does not? Correct. And simply logging breaks the interface's contract by *not* doing what is specified in the library's interface. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114195): https://edk2.groups.io/g/devel/message/114195 Mute This Topic: https://groups.io/mt/103805230/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-