From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 75CE07803CC for ; Thu, 5 Oct 2023 19:46:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MMHVWCKOrNu6NQWoL28pxK6fRIe0pHfoQH4mio5BiwA=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696535159; v=1; b=kOPOjfPsIPINqv6hSESS8sdwvfs4seoTjd379GHO3wMc3wl+R3zqV+k6OnJ/Gm/jRxR8V9N5 jY0MFxYt76fJnTv3WtaE7pP3cwfc0y0I6y5/CnfU+E9Ga5VQVF3WPOm9uL1bPeKqrwznwSoWpB7 sh9fO+KciyjiLMlKG/UngGvE= X-Received: by 127.0.0.2 with SMTP id JoabYY7687511xSpkCIPO5o8; Thu, 05 Oct 2023 12:45:59 -0700 X-Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by mx.groups.io with SMTP id smtpd.web11.25449.1696535158392046315 for ; Thu, 05 Oct 2023 12:45:58 -0700 X-Received: by mail-ua1-f46.google.com with SMTP id a1e0cc1a2514c-7b07c3eaf9bso533314241.3 for ; Thu, 05 Oct 2023 12:45:58 -0700 (PDT) X-Gm-Message-State: Rf5GzlsGYFY03uVHQ9IbBKrox7686176AA= X-Google-Smtp-Source: AGHT+IGCMVvdbaVkFECAC0R5hVcvFg7ICeF4OIqv/sUJAMwGGX+6vYP5ksnrxk9ul9FNtxWbXxUkNnyy2/kg20SgInM= X-Received: by 2002:a05:6102:3a76:b0:454:6dc6:cd5e with SMTP id bf22-20020a0561023a7600b004546dc6cd5emr6027898vsb.15.1696535157413; Thu, 05 Oct 2023 12:45:57 -0700 (PDT) MIME-Version: 1.0 References: <9143994e6a5f37650930abfc4141c6061e5bef98.1696448945.git.matt.devillier@gmail.com> In-Reply-To: <9143994e6a5f37650930abfc4141c6061e5bef98.1696448945.git.matt.devillier@gmail.com> From: "Pedro Falcato" Date: Thu, 5 Oct 2023 20:45:46 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add ClockRate field to SerialPortInfo To: matt.devillier@gmail.com Cc: devel@edk2.groups.io Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=kOPOjfPs; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Oct 4, 2023 at 9:01=E2=80=AFPM MrChromebox wrote: > > Add the ClockRate field to the UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO > struct, so that the field can be used by UefiPayloadPkg to properly > set up the serial port on boards using a non-standard clock rate. > > Signed-off-by: Matt DeVillier > Change-Id: I9bcaf03ab63f6a45d2cf25a580f7a2eba388cbbd Series-generic-feedback: Remove Change-Id lines and CC the proper maintainers for each patch > --- > MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h b/Mde= ModulePkg/Include/UniversalPayload/SerialPortInfo.h > index 3c4459e2c0..e3c9f93654 100644 > --- a/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > +++ b/MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h > @@ -19,6 +19,7 @@ typedef struct { > BOOLEAN UseMmio; > UINT8 RegisterStride; > UINT32 BaudRate; > + UINT32 ClockRate; I don't think you can do this? UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO is part of a spec (https://universalscalablefirmware.github.io/documentation/2= _universal_payload.html) and it doesn't even seem to be versioned, so you'd just break ABI. Am I missing something? --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109361): https://edk2.groups.io/g/devel/message/109361 Mute This Topic: https://groups.io/mt/101763374/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-