From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179])
 by mx.groups.io with SMTP id smtpd.web10.1179.1670624179738546145
 for <devel@edk2.groups.io>;
 Fri, 09 Dec 2022 14:16:19 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@gmail.com header.s=20210112 header.b=dBMI7d/K;
 spf=pass (domain: gmail.com, ip: 209.85.214.179, mailfrom: pedro.falcato@gmail.com)
Received: by mail-pl1-f179.google.com with SMTP id p24so6333560plw.1
        for <devel@edk2.groups.io>; Fri, 09 Dec 2022 14:16:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=L/KdaiM4OVJBC6jCUK/mU2EhjxPWchj6x5GGLqNCRZo=;
        b=dBMI7d/Kpo2liOM9TxbqlWw5AvgBWWSOOn2i4+j+V2X9uZ94OZxpw+yAtjNeSiVJeF
         a1YtnaVdgEoYsCEnCtTu8Qc7VAxkgpaSrjygZht3aYhq6zJc6ptC9W0yPa6Uf5ob8+Sy
         GeosjgxcgcpQT3Cj6pJbtwL7K3MuE6SSn1GNCtMSKn9vkQgY7V1NTkN8fTpPgedkMfJa
         5aLZ+izEsX6SSitk0U2NLBtXSkjoCxY0tHgQoL1JBGoBuRrtw6RbEOioG+qIS4EQ8aqo
         5F+2LJk6YDMULUG9caAQN0THPeI0x7CvWEaUr3wOjWL1RQ28sGkzSndJhgWiTBk2bDiT
         sIzA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=L/KdaiM4OVJBC6jCUK/mU2EhjxPWchj6x5GGLqNCRZo=;
        b=pQ+Ls13bJWu0C+J8n/SnSI+/JFiFdKnO34kpL8Ldn/0PSkVxml3KRxI6XK3L1ngEAv
         Nas2S6+v2ms4A5rMzBdAsggd7V6P0bPnXH4kQ1bCqASSWDOj6TiCHQ9TA50sU6wsNgqt
         eyJ9ToGc02w9dxPxwReoOnqR+Vt0O0SdVzHrTt5pmOaHUO7aSIVTnPRWzpSj7Kum5P+x
         DrJR9o4/9CU49SI1j0g4r3xv7+W6bGVp36lNu8d5I93LTjf4meT4sYoDvOSX1r9DIRyw
         BxH641Ed949sJz1m60pTHn2BS2kI/3jfa7LaxnPWbE1Npu5FaDgLaz+uO8bRgSnPJIXm
         Jn+Q==
X-Gm-Message-State: ANoB5pnkXYZvoThPNDmSOCHJDjfcInjNGQJnR1YKGrVLM8OIM8BCpbRY
	K7+FBmtBKr9Zo6oQNKALA+FdQjWIV6p3Tj7JWAU=
X-Google-Smtp-Source: AA0mqf6i6vgugf8DV+3iuPH/wlU7yeXLBBOdgEtLEEq7XfHoEhpy7O+ydP4Tt/u/On8YrRGq8Ka1YaOWgpNxtYOxt0c=
X-Received: by 2002:a17:90a:c7d5:b0:219:63d9:d0ff with SMTP id
 gf21-20020a17090ac7d500b0021963d9d0ffmr42490119pjb.225.1670624179277; Fri, 09
 Dec 2022 14:16:19 -0800 (PST)
MIME-Version: 1.0
References: <20221209161104.70220-1-savvamtr@gmail.com> <20221209161104.70220-10-savvamtr@gmail.com>
In-Reply-To: <20221209161104.70220-10-savvamtr@gmail.com>
From: "Pedro Falcato" <pedro.falcato@gmail.com>
Date: Fri, 9 Dec 2022 22:16:08 +0000
Message-ID: <CAKbZUD2746Xc=pgMXyaOxZjqwaKwSGdnAHFkcm18xbTrsey4gQ@mail.gmail.com>
Subject: Re: [edk2-platforms][PATCH v1 09/12] Ext4Pkg: Correct integer overflow check on multiplication in DiskUtil
To: Savva Mitrofanov <savvamtr@gmail.com>
Cc: devel@edk2.groups.io, =?UTF-8?Q?Marvin_H=C3=A4user?= <mhaeuser@posteo.de>, 
	Vitaly Cheptsov <vit9696@protonmail.com>
Content-Type: multipart/alternative; boundary="000000000000c252c505ef6c80de"

--000000000000c252c505ef6c80de
Content-Type: text/plain; charset="UTF-8"

On Fri, Dec 9, 2022 at 4:11 PM Savva Mitrofanov <savvamtr@gmail.com> wrote:

> Multiplication overflow could result into small numbers, so we need also
> check it
>

Can you fix the commit message? Overflow was (in theory) already getting
checked, I just did a remarkably poor job open-coding it.

Pedro

--000000000000c252c505ef6c80de
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Dec 9, 2022 at 4:11 PM Savva Mitr=
ofanov &lt;<a href=3D"mailto:savvamtr@gmail.com">savvamtr@gmail.com</a>&gt;=
 wrote:</div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex">Multiplication overflow could result into small numbers, so =
we need also<br>
check it<br></blockquote><div><br></div><div>Can you fix the commit message=
? Overflow was (in theory) already getting checked, I just did a remarkably=
 poor job open-coding it.</div><div>=C2=A0<br></div></div><div dir=3D"ltr" =
class=3D"gmail_signature"><div dir=3D"ltr">Pedro<br></div></div></div>

--000000000000c252c505ef6c80de--