Ping. If someone could take a look, it would be much appreciated. On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3745 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871 > > Hi all, > > This patch-set attempts to address two open feature requests for Ext4Pkg > by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib > (id 3871). > > The previous patch-set regarding 3871 attempted to merge the different > crc16 implementations > but failed because, contrary to what I thought, there are many, many > different CRC16s which > are all slightly different. This one (plus the separate edk2 patch) > attempts to just merge > CRC16-ANSI (confusingly, also known as CRC16) into BaseLib. > > Since this patch set grew to be considerably different from the original, > I didn't mark it > as v2 but rather a separate, new patch-set. > > CC'ing the edk2-platforms stewards (as I cannot review my own code) and > the CC's of the MdePkg > patch. > > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > > Pedro Falcato (3): > Ext4Pkg: Replace the CRC implementations with BaseLib > Ext4Pkg: Format using uncrustify > Ext4Pkg: Add ext2/3 support > > Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +- > Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++ > Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +- > Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ----- > Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------ > Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +- > Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++--- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------ > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +- > Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +- > Features/Ext4Pkg/Ext4Dxe/File.c | 19 +- > Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +- > Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +- > 16 files changed, 640 insertions(+), 487 deletions(-) > create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c > delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c > delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c > > -- > 2.35.1 > > -- Pedro Falcato