From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by mx.groups.io with SMTP id smtpd.web11.32629.1650906858123408504 for ; Mon, 25 Apr 2022 10:14:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mlOkT3Xs; spf=pass (domain: gmail.com, ip: 209.85.217.41, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f41.google.com with SMTP id j16so15049767vsv.2 for ; Mon, 25 Apr 2022 10:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8g8QXsrOPToPZxdYM3HxpyU8AuHFaQ7XNcmdm/nCqxQ=; b=mlOkT3XsKwuAsGjLGym2uZtr85kxoPtr8Jz2CzR/AK6Qz/cBBFRsL1+KiM8TsIMl1+ DesLAQ+oPjiv9l9rgh6OkhSbeDB89x0UYl4Rt51pD5WRXGssIkuR9EfgIwK6OSAL0Ypl WUkfvdrybQoV9oq9iKBT10P+/Cr72nKikdP6xm9eQUv3VROIPt4Mfeav31PFjIYT02rq S8h4eUAlI3OhgNG/QjolMD00tMQC3HtV6agebln5sNvT93k5rzRbTXZWxxVwy3yXNyzS FX8EKFX+q2kHHvhN0lYk3teALtWkXxFR6WlZrRj/yQh6OBfFyGhfFxJv9Pg/DyHFhOs2 BCTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8g8QXsrOPToPZxdYM3HxpyU8AuHFaQ7XNcmdm/nCqxQ=; b=k1lBKrCiBywm8ztJAm4PRdD58RPvCo3yi332AdZN5xpLua1UUCD2dczS1OiQxkjT63 mmqHDQG41a6cau/AOKd1DyoOp0gFqpY3vhJXa3czf9nAOrV5zyxQ8atZeO/2AwOI12Nz uYZ0LPAUlY5PvTSNIUPGibwhgwNKi7Bh0DxN9n+boMmah8YRaUSnRMreXx6wnhI5ndbQ 1+vwoW0Co1fkgkRkwOlZLITisPzOqVvxk2Lab0t6RD2Sk2jTHobcLL+61GFsgbAPcLaF g287X4P37LCtWeQx/LeMnOeABMm/P4v29+EafN3E6A9bGVHK6+IJ77pWyDhH2BEtwRlj OJqw== X-Gm-Message-State: AOAM5319YzHMyZ9D1IH/bhQUVQKCviTNthM/OxeSTqu24FvxzHDoKMZt 7eHMpy/SnQ93dz7OXyIqyR80/RaE6Yk09lARU/n6IqJTFnsnYQ== X-Google-Smtp-Source: ABdhPJykm6wYfJ1a4jB1aq/G/jPNQfe/etJV0eEaK8bhlw4tc6oWhaHnzQ2o0eh00nciIbKcHINluFhvqW94f5pLsmw= X-Received: by 2002:a05:6102:a4c:b0:32c:cb54:383a with SMTP id i12-20020a0561020a4c00b0032ccb54383amr1994529vss.62.1650906857118; Mon, 25 Apr 2022 10:14:17 -0700 (PDT) MIME-Version: 1.0 References: <20220407220146.149580-1-pedro.falcato@gmail.com> In-Reply-To: <20220407220146.149580-1-pedro.falcato@gmail.com> From: "Pedro Falcato" Date: Mon, 25 Apr 2022 18:14:05 +0100 Message-ID: Subject: Re: [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib To: edk2-devel-groups-io Cc: Leif Lindholm , Michael D Kinney , Liming Gao , Zhiguang Liu Content-Type: multipart/alternative; boundary="000000000000c6a02305dd7db40b" --000000000000c6a02305dd7db40b Content-Type: text/plain; charset="UTF-8" Ping. If someone could take a look, it would be much appreciated. On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3745 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871 > > Hi all, > > This patch-set attempts to address two open feature requests for Ext4Pkg > by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib > (id 3871). > > The previous patch-set regarding 3871 attempted to merge the different > crc16 implementations > but failed because, contrary to what I thought, there are many, many > different CRC16s which > are all slightly different. This one (plus the separate edk2 patch) > attempts to just merge > CRC16-ANSI (confusingly, also known as CRC16) into BaseLib. > > Since this patch set grew to be considerably different from the original, > I didn't mark it > as v2 but rather a separate, new patch-set. > > CC'ing the edk2-platforms stewards (as I cannot review my own code) and > the CC's of the MdePkg > patch. > > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > > Pedro Falcato (3): > Ext4Pkg: Replace the CRC implementations with BaseLib > Ext4Pkg: Format using uncrustify > Ext4Pkg: Add ext2/3 support > > Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +- > Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++ > Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +- > Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ----- > Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------ > Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +- > Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++--- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------ > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +- > Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +- > Features/Ext4Pkg/Ext4Dxe/File.c | 19 +- > Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +- > Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +- > 16 files changed, 640 insertions(+), 487 deletions(-) > create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c > delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c > delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c > > -- > 2.35.1 > > -- Pedro Falcato --000000000000c6a02305dd7db40b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ping. If someone could take a look, it would be much appre= ciated.

On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato <pedro.falcato@gmail.com> wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3745
BZ: https://bugzilla.tianocore.org/show_bug.c= gi?id=3D3871

Hi all,

This patch-set attempts to address two open feature requests for Ext4Pkg by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib = (id 3871).

The previous patch-set regarding 3871 attempted to merge the different crc1= 6 implementations
but failed because, contrary to what I thought, there are many, many differ= ent CRC16s which
are all slightly different. This one (plus the separate edk2 patch) attempt= s to just merge
CRC16-ANSI (confusingly, also known as CRC16) into BaseLib.

Since this patch set grew to be considerably different from the original, I= didn't mark it
as v2 but rather a separate, new patch-set.

CC'ing the edk2-platforms stewards (as I cannot review my own code) and= the CC's of the MdePkg
patch.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>

Pedro Falcato (3):
=C2=A0 Ext4Pkg: Replace the CRC implementations with BaseLib
=C2=A0 Ext4Pkg: Format using uncrustify
=C2=A0 Ext4Pkg: Add ext2/3 support

=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |=C2=A0 10 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockMap.c=C2=A0 =C2=A0| 279 +++++++++++++++= ++
=C2=A0Features/Ext4Pkg/Ext4Dxe/Collation.c=C2=A0 |=C2=A0 =C2=A04 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Crc16.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 75 -----=
=C2=A0Features/Ext4Pkg/Ext4Dxe/Crc32c.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 84 -----= -
=C2=A0Features/Ext4Pkg/Ext4Dxe/Directory.c=C2=A0 |=C2=A0 13 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/DiskUtil.c=C2=A0 =C2=A0|=C2=A0 =C2=A06 +- =C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h=C2=A0 =C2=A0|=C2=A0 30 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c=C2=A0 =C2=A0 |=C2=A0 95 +++---
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h=C2=A0 =C2=A0 | 417 ++++++++++++++-= -----------
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf=C2=A0 |=C2=A0 =C2=A03 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Extents.c=C2=A0 =C2=A0 |=C2=A0 27 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/File.c=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 19 = +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Inode.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 33 +- =C2=A0Features/Ext4Pkg/Ext4Dxe/Partition.c=C2=A0 |=C2=A0 12 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Superblock.c |=C2=A0 20 +-
=C2=A016 files changed, 640 insertions(+), 487 deletions(-)
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c
=C2=A0delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
=C2=A0delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c

--
2.35.1



--
Pedro Falcato
--000000000000c6a02305dd7db40b--