From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B4C0E74003E for ; Wed, 29 Nov 2023 06:40:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2W9RPmULIAQ6/rmGUqtmiNmODCd4Fa7GRNXLhzUdNsc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701240029; v=1; b=FILppntmFJ/5J21e5Z1qgI0Op2/hplaVsgo+KKAmw7JzJWXpHn3M4FfrTfTc8MlIaPeOSZ+B ajvqW7lE/MJtSIR3vTAxAyH8bJUuxOMee5UQFgmMJON6BvE6iC07fjF6CayboqwqaUIMxeHK2Hs JIJOdAGjBB3pfRvwCr7yOmvU= X-Received: by 127.0.0.2 with SMTP id l3rRYY7687511xF7kuQF1Jdh; Tue, 28 Nov 2023 22:40:29 -0800 X-Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by mx.groups.io with SMTP id smtpd.web10.25798.1701240028858764717 for ; Tue, 28 Nov 2023 22:40:29 -0800 X-Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-46439cb7039so464179137.2 for ; Tue, 28 Nov 2023 22:40:28 -0800 (PST) X-Gm-Message-State: KSvvPredgPhY5hbw0RPidfJNx7686176AA= X-Google-Smtp-Source: AGHT+IEjRW9jSaNfxDxr1SZuXEL5gcX738tVt3wUU2C5hL8wZafsADIyafvAKeNXY38GxjpLfTTdaBgONatilHeci/o= X-Received: by 2002:a67:f60b:0:b0:464:4a0b:963f with SMTP id k11-20020a67f60b000000b004644a0b963fmr912253vso.30.1701240027709; Tue, 28 Nov 2023 22:40:27 -0800 (PST) MIME-Version: 1.0 References: <20231122131444.1885823-1-pierre.gondois@arm.com> In-Reply-To: From: "Pedro Falcato" Date: Wed, 29 Nov 2023 06:40:16 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id To: devel@edk2.groups.io, ray.ni@intel.com Cc: "Chen, Christine" , Pierre Gondois , Rebecca Cran , "Gao, Liming" , "Feng, Bob C" , Sami Mujawar , "YeoReum.Yun@arm.com" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FILppntm; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Nov 29, 2023 at 12:56=E2=80=AFAM Ni, Ray wrote: > > It's good. But I am curious why --ignore-change-id is needed? I didn't ask, but presumably, if you have an internal gerrit instance that runs CI before pushing, PatchCheck.py may be part of the CI workflow; in those cases, we don't want it to error out. So the CI would be adapted to do PatchCheck.py --ignore-change-id, and all is well. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111836): https://edk2.groups.io/g/devel/message/111836 Mute This Topic: https://groups.io/mt/102748141/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-