From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by mx.groups.io with SMTP id smtpd.web11.120.1685808281119483555 for ; Sat, 03 Jun 2023 09:04:41 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=knmU6kCX; spf=pass (domain: gmail.com, ip: 209.85.222.43, mailfrom: pedro.falcato@gmail.com) Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-786e783a748so942759241.2 for ; Sat, 03 Jun 2023 09:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685808280; x=1688400280; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ROtGdaJaKAbw7jfhDKlU45aeI/oUSPLfR8zDr+F1Ir0=; b=knmU6kCX337H2PsgSaiOQYCynsHsj7UXSMfY/vvoHAjjUGL4iejP9vfSGs7PV0NNhv yVYjWwZRU8J+JjsFvQ799QZlCvRmQUCuxQwMS0GFoRRxLSxRYDmcqMc7tMjCppgn+zMw 02Ej/kaXGC4rqDnkaqPuVzFa9B6fucr8QjfJcYo898MWbxlfv73doBo67kHYlaWto7jW x5HfQZ0CeBeAwdpLa/5S8iPLdrXmhq2ozRQwbGlV54wRObSFwtROyR/Ud4p+zJIgILkj i4gri3/l6rtqyxyAgZKeECZ7Xzu2VuvK4xoPyPn4iZEEDAPOMAm74GhTVRfsgjlUKuG9 K/tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685808280; x=1688400280; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ROtGdaJaKAbw7jfhDKlU45aeI/oUSPLfR8zDr+F1Ir0=; b=O4X/1tJeLpda9FRKiz0R2dizhilgXxWcLcPHKv/0goHZ8JOQcmkV3GRuzFvcbJYP9d 459b6snq6AhtpsDMMrE1kJ1WzLIa2TpC5uELD4RiePGpafj5Qqe1yCDIF0pBcM05kdJP Yg5W6iGDieMA9CUijEyehTi5vkohIRdI0r6XbL9mJY/xcNQeiARfFV9E2fN5x3lIPoiD GK4xw69/WTB825UlKDlQscVUUFQCseOwWmbT75ajvrLLXD5J5EqRikRbXTwolD7bYTX/ gvsE4BQpp+CENsIidxg4wuBGrFiHXy2OpeNVPe5Vckhm3bc+0F5WMPyX6a82kTj4hu+u 1YUg== X-Gm-Message-State: AC+VfDxQ7qCE21l7Ir+UUquC2F/fIJszMWvNBUYYuCC3WceweEhc0ro4 Cw5SqM2hqCR99vdqhF1qPAkeWjdeBnCfD1S+nwLSVebf X-Google-Smtp-Source: ACHHUZ52SYPXfsoGuUQNCK3n2qkoGrW3BuXdAlthImAC137r/QWjdTgnKRTmldBlsyNAkmhJmcDRoguL44a2H5Vx+Dc= X-Received: by 2002:a67:ea53:0:b0:435:5255:a1fd with SMTP id r19-20020a67ea53000000b004355255a1fdmr6019393vso.3.1685808279900; Sat, 03 Jun 2023 09:04:39 -0700 (PDT) MIME-Version: 1.0 References: <20230602070946.83730-1-rsingh@ventanamicro.com> <20230602070946.83730-2-rsingh@ventanamicro.com> In-Reply-To: <20230602070946.83730-2-rsingh@ventanamicro.com> From: "Pedro Falcato" Date: Sat, 3 Jun 2023 17:04:28 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue To: devel@edk2.groups.io, rsingh@ventanamicro.com Cc: Hao A Wu , Ray Ni Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jun 2, 2023 at 8:42=E2=80=AFPM Ranbir Singh wrote: > > From: Ranbir Singh > > The return value stored in Status after call to SetDriveParameters > is not made of any use thereafter and hence it remains as UNUSED. > Assuming, this non-usage is deliberate, the storage in Status can be > done away with. > > Cc: Hao A Wu > Cc: Ray Ni > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4204 > Signed-off-by: Ranbir Singh > --- > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c b/MdeModuleP= kg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > index 75403886e44a..c6d637afa989 100644 > --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > @@ -2555,7 +2555,7 @@ DetectAndConfigIdeDevice ( > DriveParameters.Heads =3D (UINT8)(((ATA5_IDENTIFY_DATA *)= (&Buffer.AtaData))->heads - 1); > DriveParameters.MultipleSector =3D (UINT8)((ATA5_IDENTIFY_DATA *)(= &Buffer.AtaData))->multi_sector_cmd_max_sct_cnt; > > - Status =3D SetDriveParameters (Instance, IdeChannel, IdeDevice, &D= riveParameters, NULL); > + SetDriveParameters (Instance, IdeChannel, IdeDevice, &DriveParamet= ers, NULL); I'm /fairly/ sure this is wrong and that you need to use Status. --=20 Pedro