public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>,
	Gerd Hoffmann <kraxel@redhat.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	 Pawel Polawski <ppolawsk@redhat.com>,
	Bob Feng <bob.c.feng@intel.com>,
	 Oliver Steffen <osteffen@redhat.com>,
	Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH v3 0/3] BaseTools: fix gcc workaround
Date: Mon, 4 Apr 2022 16:18:56 +0100	[thread overview]
Message-ID: <CAKbZUD2Em5HiTJEAtA1PSwtKE5iDGWgN5Xmw5bWxf28qmtLisQ@mail.gmail.com> (raw)
In-Reply-To: <20220404093229.1971782-1-kraxel@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

Hi Gerd,

These patches are a great idea but I don't know if we can take GPLv2 code
like that. Are they even mergeable into the main edk2 repo (as it's not
compatible with BSD-2-clause)?

Thanks,
Pedro

On Mon, Apr 4, 2022 at 10:32 AM Gerd Hoffmann <kraxel@redhat.com> wrote:

> The linux kernel has a bunch of useful macros to check whenever a given
> compiler supports specific flags.  Import them, adapt them for edk2, then
> put them into use to make both gcc5 and gcc12 work for BaseTools.
>
> Gerd Hoffmann (3):
>   BaseTools: import compiler check macros from linux kernel
>   BaseTools: adapt comniler checks mmacros for edk2
>   BaseTools: fix gcc workaround
>
>  BaseTools/Source/C/DevicePath/GNUmakefile     |  3 +-
>  .../Source/C/Makefiles/compiler.makefile      | 76 +++++++++++++++++++
>  2 files changed, 78 insertions(+), 1 deletion(-)
>  create mode 100644 BaseTools/Source/C/Makefiles/compiler.makefile
>
> --
> 2.35.1
>
>
>
> 
>
>
>

-- 
Pedro Falcato

[-- Attachment #2: Type: text/html, Size: 1505 bytes --]

  parent reply	other threads:[~2022-04-04 15:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04  9:32 [PATCH v3 0/3] BaseTools: fix gcc workaround Gerd Hoffmann
2022-04-04  9:32 ` [PATCH v3 1/3] BaseTools: import compiler check macros from linux kernel Gerd Hoffmann
2022-04-04  9:32 ` [PATCH v3 2/3] BaseTools: adapt comniler checks mmacros for edk2 Gerd Hoffmann
2022-04-04  9:32 ` [PATCH v3 3/3] BaseTools: fix gcc workaround Gerd Hoffmann
2022-04-04 15:18 ` Pedro Falcato [this message]
2022-04-07 10:12   ` [edk2-devel] [PATCH v3 0/3] " Gerd Hoffmann
2022-04-09  3:53     ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKbZUD2Em5HiTJEAtA1PSwtKE5iDGWgN5Xmw5bWxf28qmtLisQ@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox