From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mx.groups.io with SMTP id smtpd.web09.36594.1649085548097343170 for ; Mon, 04 Apr 2022 08:19:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=BXK+3Oza; spf=pass (domain: gmail.com, ip: 209.85.217.47, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f47.google.com with SMTP id i186so9550877vsc.9 for ; Mon, 04 Apr 2022 08:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=50CPng1aIwJDivJdUpCP8P+sQ6KBW1Ks6Bd+B9M9ZB0=; b=BXK+3OzaHXvzT/hVv0JyZlxTS5suJqqAXypvUhGagxDdUKvSwmO9PvDEJ6kFd11d4z SA4B/1lJZ6fFHo5lhPlSfXeXH8Vr51KKl+zMNXsyeDG5qfHlXQ/0mGx0mwUTiLDdnUg0 tbdQCh06MVIW2DnVUQRCXnT7jv1SDwX3jkTJ5fvAiffWCUbn2EteprMEiVOcUmFLwHAy yWVn7LXGTDcw46lZizZMig5+u74gsgCBuMu4XIvpYb0LnwlYlr8VVKSl5DKGeKSJS6z5 v0q+ghMNzwIu5f3vlWv5A0o9nlnEM0cfiJbftZAU3sBUnuUdWQkqaXRGILW1HGaImRjl UPFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=50CPng1aIwJDivJdUpCP8P+sQ6KBW1Ks6Bd+B9M9ZB0=; b=puH9hwd09yN+8kryZH5SpB65UCAPkkihD18VDZEgqI6ECDSs/5/zvBk8LpUxqStKW6 6MA64DHzPNytY+ikNaC+G2hW76tTEB3MDS3lowYqQV3+EpifCA4sMjeQilMAiTRR45WJ 5ORxrpnci9AHubt9t/AGg9DaKb6yb7KEHYkqY4U7SObOcXVu/njwFa1Tp804BkVSVtfU YbWkfMgiTCroEO0UkXqe1JQr++vCe3K1oksKtxAV3MxHlv829TNyYOWzbLqAZeM6CxhY 8JMgN8Fm/ljYZU6KuOg1cwaJsDAKPOlMwliEiTf0hJm+2ZisheQKhTPtODbOt73j3Voc ISig== X-Gm-Message-State: AOAM533utTZ//J+2TrvP9QxpXuQerAPzPX9o6+x8mqiYRcX6QKIXqqmB g2i6bf8IBBxwXdbbwNkshId3BKfuG9ogHe7vnNqVLlmsrhQ= X-Google-Smtp-Source: ABdhPJwMIwIMQ2TCme1qaOGjFDALH6WXKjhQ4of+26oWMMWr4nunCs/+Ri5iXFqyUYZAFBl8WW2EQ819z7HORM5sOYA= X-Received: by 2002:a05:6102:32d2:b0:325:7415:7190 with SMTP id o18-20020a05610232d200b0032574157190mr97215vss.6.1649085547067; Mon, 04 Apr 2022 08:19:07 -0700 (PDT) MIME-Version: 1.0 References: <20220404093229.1971782-1-kraxel@redhat.com> In-Reply-To: <20220404093229.1971782-1-kraxel@redhat.com> From: "Pedro Falcato" Date: Mon, 4 Apr 2022 16:18:56 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v3 0/3] BaseTools: fix gcc workaround To: edk2-devel-groups-io , Gerd Hoffmann Cc: Yuwei Chen , Liming Gao , Pawel Polawski , Bob Feng , Oliver Steffen , Rebecca Cran Content-Type: multipart/alternative; boundary="0000000000003cbb9b05dbd5a690" --0000000000003cbb9b05dbd5a690 Content-Type: text/plain; charset="UTF-8" Hi Gerd, These patches are a great idea but I don't know if we can take GPLv2 code like that. Are they even mergeable into the main edk2 repo (as it's not compatible with BSD-2-clause)? Thanks, Pedro On Mon, Apr 4, 2022 at 10:32 AM Gerd Hoffmann wrote: > The linux kernel has a bunch of useful macros to check whenever a given > compiler supports specific flags. Import them, adapt them for edk2, then > put them into use to make both gcc5 and gcc12 work for BaseTools. > > Gerd Hoffmann (3): > BaseTools: import compiler check macros from linux kernel > BaseTools: adapt comniler checks mmacros for edk2 > BaseTools: fix gcc workaround > > BaseTools/Source/C/DevicePath/GNUmakefile | 3 +- > .../Source/C/Makefiles/compiler.makefile | 76 +++++++++++++++++++ > 2 files changed, 78 insertions(+), 1 deletion(-) > create mode 100644 BaseTools/Source/C/Makefiles/compiler.makefile > > -- > 2.35.1 > > > > > > > -- Pedro Falcato --0000000000003cbb9b05dbd5a690 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Gerd,

These patches are a= great idea but I don't know if we can take GPLv2 code like that. Are t= hey even mergeable into the main edk2 repo (as it's not compatible with= BSD-2-clause)?

Thanks,
Pedro
<= /div>
O= n Mon, Apr 4, 2022 at 10:32 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
The linux kernel has a bunch of useful macros t= o check whenever a given
compiler supports specific flags.=C2=A0 Import them, adapt them for edk2, t= hen
put them into use to make both gcc5 and gcc12 work for BaseTools.

Gerd Hoffmann (3):
=C2=A0 BaseTools: import compiler check macros from linux kernel
=C2=A0 BaseTools: adapt comniler checks mmacros for edk2
=C2=A0 BaseTools: fix gcc workaround

=C2=A0BaseTools/Source/C/DevicePath/GNUmakefile=C2=A0 =C2=A0 =C2=A0|=C2=A0 = 3 +-
=C2=A0.../Source/C/Makefiles/compiler.makefile=C2=A0 =C2=A0 =C2=A0 | 76 +++= ++++++++++++++++
=C2=A02 files changed, 78 insertions(+), 1 deletion(-)
=C2=A0create mode 100644 BaseTools/Source/C/Makefiles/compiler.makefile

--
2.35.1








--
Pedro Falcato
--0000000000003cbb9b05dbd5a690--