Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification

["Pedro Falcato" <pedro.falcato@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 4538 bytes --]

Hi Sean,

I think it's clear from the wording that the 38.2% thing is a
recommendation and not mandatory. I was curious and checked out the ACPI
spec and they appear to not mention that at all. Maybe reword things to
"Microsoft recommendation"?

Thanks,
Pedro

On Fri, 5 Aug 2022, 07:55 Sean Rhodes, <sean@starlabs.systems> wrote:

> Hi Liming
>
> Microsoft details about positioning can be found here:
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components
>
> Thanks
>
> Sean
>
> On Fri, 5 Aug 2022 at 07:00, gaoliming via groups.io <gaoliming=
> byosoft.com.cn@groups.io> wrote:
>
>> Sean:
>>   Can you give BGRT spec link? I want to check the spec description.
>>
>> Thanks
>> Liming
>> > -----邮件原件-----
>> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sean Rhodes
>> > 发送时间: 2022年7月26日 16:15
>> > 收件人: devel@edk2.groups.io
>> > 抄送: Sean Rhodes <sean@starlabs.systems>; Zhichao Gao
>> > <zhichao.gao@intel.com>; Ray Ni <ray.ni@intel.com>; Jian J Wang
>> > <jian.j.wang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
>> > 主题: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to
>> > follow BGRT specification
>> >
>> > Add an option to position the logo 38.2% from the top of the screen,
>> > which follows the BGRT specification.
>> >
>> > Cc: Zhichao Gao <zhichao.gao@intel.com>
>> > Cc: Ray Ni <ray.ni@intel.com>
>> > Cc: Jian J Wang <jian.j.wang@intel.com>
>> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> > Signed-off-by: Sean Rhodes <sean@starlabs.systems>
>> > ---
>> >  MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
>> >  MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++---
>> >  2 files changed, 6 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
>> > b/MdeModulePkg/Include/Protocol/PlatformLogo.h
>> > index 08e1dc35a4..7c9ef63c66 100644
>> > --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
>> > +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
>> > @@ -29,7 +29,8 @@ typedef enum {
>> >    EdkiiPlatformLogoDisplayAttributeCenterBottom,
>> >
>> >    EdkiiPlatformLogoDisplayAttributeLeftBottom,
>> >
>> >    EdkiiPlatformLogoDisplayAttributeCenterLeft,
>> >
>> > -  EdkiiPlatformLogoDisplayAttributeCenter
>> >
>> > +  EdkiiPlatformLogoDisplayAttributeCenter,
>> >
>> > +  EdkiiPlatformLogoDisplayAttributeBGRTSpecification
>> >
>> >  } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
>> >
>> >
>> >
>> >  /**
>> >
>> > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
>> > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
>> > index 478ec2d40e..ac086f9c79 100644
>> > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
>> > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
>> > @@ -169,7 +169,6 @@ BootLogoEnableLogo (
>> >          DestX = SizeOfX - Image.Width;
>> >
>> >          DestY = 0;
>> >
>> >          break;
>> >
>> > -
>> >
>> >        case EdkiiPlatformLogoDisplayAttributeCenterLeft:
>> >
>> >          DestX = 0;
>> >
>> >          DestY = (SizeOfY - Image.Height) / 2;
>> >
>> > @@ -182,7 +181,6 @@ BootLogoEnableLogo (
>> >          DestX = SizeOfX - Image.Width;
>> >
>> >          DestY = (SizeOfY - Image.Height) / 2;
>> >
>> >          break;
>> >
>> > -
>> >
>> >        case EdkiiPlatformLogoDisplayAttributeLeftBottom:
>> >
>> >          DestX = 0;
>> >
>> >          DestY = SizeOfY - Image.Height;
>> >
>> > @@ -195,7 +193,10 @@ BootLogoEnableLogo (
>> >          DestX = SizeOfX - Image.Width;
>> >
>> >          DestY = SizeOfY - Image.Height;
>> >
>> >          break;
>> >
>> > -
>> >
>> > +      case EdkiiPlatformLogoDisplayAttributeBGRTSpecification:
>> >
>> > +        DestX = (SizeOfX - Image.Width) / 2;
>> >
>> > +        DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;
>> >
>> > +        break;
>> >
>> >        default:
>> >
>> >          ASSERT (FALSE);
>> >
>> >          continue;
>> >
>> > --
>> > 2.34.1
>> >
>> >
>> >
>> > -=-=-=-=-=-=
>> > Groups.io Links: You receive all messages sent to this group.
>> > View/Reply Online (#91842):
>> https://edk2.groups.io/g/devel/message/91842
>> > Mute This Topic: https://groups.io/mt/92623125/4905953
>> > Group Owner: devel+owner@edk2.groups.io
>> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
>> > [gaoliming@byosoft.com.cn]
>> > -=-=-=-=-=-=
>> >
>>
>>
>>
>>
>>
>>
>>
>>
>> 
>

[-- Attachment #2: Type: text/html, Size: 7921 bytes --]