From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by mx.groups.io with SMTP id smtpd.web10.4382.1659683070745420661 for ; Fri, 05 Aug 2022 00:04:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=liXMefQ2; spf=pass (domain: gmail.com, ip: 209.85.217.46, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f46.google.com with SMTP id 66so1664568vse.4 for ; Fri, 05 Aug 2022 00:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=FLiOA2Y9WjcM4HpHqeoWi/KNrKII4tZsXkVUbpvAdio=; b=liXMefQ2XTS5SGzKEGXQLKsBZIWfcrPkwHy83nceuKUAUauJ8WUjdLaFx8IvgZXMnv oFV4wNoNhb36gn3TlA0OG6R0pGWZtDEZRa+PaGBFS02iqMR22hcjUIE/A5WXCk0Q412x RRbALwSyPf3NovecF1F/XoVje4GQvGnTN0Pd4Ra9JOZQFc7pHILsJKjaYdI5FagM36Ki u8dE73M0lKWIHRfmLIvX+YU6aqu8e+DC08QzCErzpD+WnfodsYEXhH/Wn/jZqRgAkxjg i5lX6hnctFWolqix/a6lFOXMHD5n6ogVB9duyJNgBn8PqPiHK66D7vlj6N/7MNoc+jGy sYZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=FLiOA2Y9WjcM4HpHqeoWi/KNrKII4tZsXkVUbpvAdio=; b=ouKli7ZXkBn38QKAyryim4ZHQX4Je7B2SgttGIJ88CElNvqgIcr6w25x6YTth/3NF9 EKBVmSxroX4s3cRr6ghN1pMKaJv/GvdMU0uod1UYDFUucFL0cY9ECqFNJuZo1FrWzsDG /luDuMpbjpY2et2jWCrM6HPdFowWM/hXQVDOZwlDWLqqTm/krgz/ktS2ybJsSyowz96u /3NEcOzALFjwnykrUix45tqRzp4BOC1njmWIE85U2jQcc/H6rXd19VxN+FYKIFNmRJWW JTFbTkw7waz9RQo4DZS4jSQTJEU/eTDyexSFFkArJtYZT3xU/hHG9utQvYgSywEu77+z hE9A== X-Gm-Message-State: ACgBeo3iHaVy0EMLBBqFlWsaCxp9MVbUjbAe7AJHPDuR2h6Fdlj+yO+9 x5o7JMV2+hVW5ix0o4DH6zSR+ou2P8IBj7ftzDrAQWhd X-Google-Smtp-Source: AA6agR5tLmG4MouX7heNpZL437kIcIgGlAcrdfcBRK5//hit6jZ8fjRkuc/GZ/EV0SpJjxmVCreg+MqdUmf7C3RvSxY= X-Received: by 2002:a67:d194:0:b0:388:94b1:7178 with SMTP id w20-20020a67d194000000b0038894b17178mr16248vsi.75.1659683069295; Fri, 05 Aug 2022 00:04:29 -0700 (PDT) MIME-Version: 1.0 References: <030701d8a890$97e31bb0$c7a95310$@byosoft.com.cn> In-Reply-To: From: "Pedro Falcato" Date: Fri, 5 Aug 2022 08:04:18 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification To: edk2-devel-groups-io , sean@starlabs.systems Cc: Liming Gao , Zhichao Gao , Ray Ni , Jian J Wang Content-Type: multipart/alternative; boundary="000000000000c9020705e57913e8" --000000000000c9020705e57913e8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sean, I think it's clear from the wording that the 38.2% thing is a recommendation and not mandatory. I was curious and checked out the ACPI spec and they appear to not mention that at all. Maybe reword things to "Microsoft recommendation"? Thanks, Pedro On Fri, 5 Aug 2022, 07:55 Sean Rhodes, wrote: > Hi Liming > > Microsoft details about positioning can be found here: > https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-sc= reen-components > > Thanks > > Sean > > On Fri, 5 Aug 2022 at 07:00, gaoliming via groups.io byosoft.com.cn@groups.io> wrote: > >> Sean: >> Can you give BGRT spec link? I want to check the spec description. >> >> Thanks >> Liming >> > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Sean Rhodes >> > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B47=E6=9C=8826=E6=97= =A5 16:15 >> > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io >> > =E6=8A=84=E9=80=81: Sean Rhodes ; Zhichao Gao >> > ; Ray Ni ; Jian J Wang >> > ; Liming Gao >> > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib:= Add option to >> > follow BGRT specification >> > >> > Add an option to position the logo 38.2% from the top of the screen, >> > which follows the BGRT specification. >> > >> > Cc: Zhichao Gao >> > Cc: Ray Ni >> > Cc: Jian J Wang >> > Cc: Liming Gao >> > Signed-off-by: Sean Rhodes >> > --- >> > MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++- >> > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++--- >> > 2 files changed, 6 insertions(+), 4 deletions(-) >> > >> > diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h >> > b/MdeModulePkg/Include/Protocol/PlatformLogo.h >> > index 08e1dc35a4..7c9ef63c66 100644 >> > --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h >> > +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h >> > @@ -29,7 +29,8 @@ typedef enum { >> > EdkiiPlatformLogoDisplayAttributeCenterBottom, >> > >> > EdkiiPlatformLogoDisplayAttributeLeftBottom, >> > >> > EdkiiPlatformLogoDisplayAttributeCenterLeft, >> > >> > - EdkiiPlatformLogoDisplayAttributeCenter >> > >> > + EdkiiPlatformLogoDisplayAttributeCenter, >> > >> > + EdkiiPlatformLogoDisplayAttributeBGRTSpecification >> > >> > } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE; >> > >> > >> > >> > /** >> > >> > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c >> > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c >> > index 478ec2d40e..ac086f9c79 100644 >> > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c >> > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c >> > @@ -169,7 +169,6 @@ BootLogoEnableLogo ( >> > DestX =3D SizeOfX - Image.Width; >> > >> > DestY =3D 0; >> > >> > break; >> > >> > - >> > >> > case EdkiiPlatformLogoDisplayAttributeCenterLeft: >> > >> > DestX =3D 0; >> > >> > DestY =3D (SizeOfY - Image.Height) / 2; >> > >> > @@ -182,7 +181,6 @@ BootLogoEnableLogo ( >> > DestX =3D SizeOfX - Image.Width; >> > >> > DestY =3D (SizeOfY - Image.Height) / 2; >> > >> > break; >> > >> > - >> > >> > case EdkiiPlatformLogoDisplayAttributeLeftBottom: >> > >> > DestX =3D 0; >> > >> > DestY =3D SizeOfY - Image.Height; >> > >> > @@ -195,7 +193,10 @@ BootLogoEnableLogo ( >> > DestX =3D SizeOfX - Image.Width; >> > >> > DestY =3D SizeOfY - Image.Height; >> > >> > break; >> > >> > - >> > >> > + case EdkiiPlatformLogoDisplayAttributeBGRTSpecification: >> > >> > + DestX =3D (SizeOfX - Image.Width) / 2; >> > >> > + DestY =3D (SizeOfY * 382) / 1000 - Image.Height / 2; >> > >> > + break; >> > >> > default: >> > >> > ASSERT (FALSE); >> > >> > continue; >> > >> > -- >> > 2.34.1 >> > >> > >> > >> > -=3D-=3D-=3D-=3D-=3D-=3D >> > Groups.io Links: You receive all messages sent to this group. >> > View/Reply Online (#91842): >> https://edk2.groups.io/g/devel/message/91842 >> > Mute This Topic: https://groups.io/mt/92623125/4905953 >> > Group Owner: devel+owner@edk2.groups.io >> > Unsubscribe: https://edk2.groups.io/g/devel/unsub >> > [gaoliming@byosoft.com.cn] >> > -=3D-=3D-=3D-=3D-=3D-=3D >> > >> >> >> >> >> >> >> >> >>=20 > --000000000000c9020705e57913e8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Sean,

I t= hink it's clear from the wording that the 38.2% thing is a recommendati= on and not mandatory. I was curious and checked out the ACPI spec and they = appear to not mention that at all. Maybe reword things to "Microsoft r= ecommendation"?

Tha= nks,
Pedro

On Fri, 5 Aug 2022, 07:55 Sean Rhode= s, <sean@starlabs.systems> wrote:
Hi Liming

Microsoft details about posi= tioning can be found here:=C2=A0https://docs.microsoft.com/en-us/windows-hardware/drive= rs/bringup/boot-screen-components

Thanks

=
= Sean

On Fri, 5 Aug 2022 at 07:00, gaoliming via groups.io <gaoliming=3D<= a href=3D"mailto:byosoft.com.cn@groups.io" target=3D"_blank" rel=3D"norefer= rer">byosoft.com.cn@groups.io> wrote:
Sean:
=C2=A0 Can you give BGRT spec link? I want to check the spec description. <= br>
Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@ed= k2.groups.io> =E4=BB=A3=E8=A1=A8 Sean Rhodes
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B47=E6=9C=8826=E6=97= =A5 16:15
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io
> =E6=8A=84=E9=80=81: Sean Rhodes <sean@starlabs.systems>; Zhichao= Gao
> <zhichao.gao@intel.com>; Ray Ni <ray.ni@intel.com>= ;; Jian J Wang
> <jian.j.wang@intel.com>; Liming Gao <gaoliming@b= yosoft.com.cn>
> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib:= Add option to
> follow BGRT specification
>
> Add an option to position the logo 38.2% from the top of the screen, > which follows the BGRT specification.
>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
>=C2=A0 MdeModulePkg/Include/Protocol/PlatformLogo.h=C2=A0 =C2=A0| 3 ++-=
>=C2=A0 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++---
>=C2=A0 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> index 08e1dc35a4..7c9ef63c66 100644
> --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
> +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
> @@ -29,7 +29,8 @@ typedef enum {
>=C2=A0 =C2=A0 EdkiiPlatformLogoDisplayAttributeCenterBottom,
>
>=C2=A0 =C2=A0 EdkiiPlatformLogoDisplayAttributeLeftBottom,
>
>=C2=A0 =C2=A0 EdkiiPlatformLogoDisplayAttributeCenterLeft,
>
> -=C2=A0 EdkiiPlatformLogoDisplayAttributeCenter
>
> +=C2=A0 EdkiiPlatformLogoDisplayAttributeCenter,
>
> +=C2=A0 EdkiiPlatformLogoDisplayAttributeBGRTSpecification
>
>=C2=A0 } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;
>
>
>
>=C2=A0 /**
>
> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 478ec2d40e..ac086f9c79 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @@ -169,7 +169,6 @@ BootLogoEnableLogo (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D SizeOfX - Image.Width;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D 0;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>
> -
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 case EdkiiPlatformLogoDisplayAttributeCente= rLeft:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D 0;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D (SizeOfY - Image.Height) /= 2;
>
> @@ -182,7 +181,6 @@ BootLogoEnableLogo (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D SizeOfX - Image.Width;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D (SizeOfY - Image.Height) /= 2;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>
> -
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 case EdkiiPlatformLogoDisplayAttributeLeftB= ottom:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D 0;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D SizeOfY - Image.Height; >
> @@ -195,7 +193,10 @@ BootLogoEnableLogo (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D SizeOfX - Image.Width;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D SizeOfY - Image.Height; >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>
> -
>
> +=C2=A0 =C2=A0 =C2=A0 case EdkiiPlatformLogoDisplayAttributeBGRTSpecif= ication:
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 DestX =3D (SizeOfX - Image.Width) / 2; >
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 DestY =3D (SizeOfY * 382) / 1000 - Image.= Height / 2;
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 break;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 default:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ASSERT (FALSE);
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue;
>
> --
> 2.34.1
>
>
>
> -=3D-=3D-=3D-=3D-=3D-=3D
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#91842): https://edk2= .groups.io/g/devel/message/91842
> Mute This Topic: https://groups.io/mt/92623125/= 4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsu= b
> [gaoliming@byosoft.com.cn]
> -=3D-=3D-=3D-=3D-=3D-=3D
>








=20

--000000000000c9020705e57913e8--