From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mx.groups.io with SMTP id smtpd.web11.45720.1680230160616791122 for ; Thu, 30 Mar 2023 19:36:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Y7Y0ALSg; spf=pass (domain: gmail.com, ip: 209.85.214.170, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f170.google.com with SMTP id kc4so19928584plb.10 for ; Thu, 30 Mar 2023 19:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680230160; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=86F+ceC1NW1bMTeg52u64nx73IS84oPBFUIyL2W5K6M=; b=Y7Y0ALSg7pqw/8zCYLT5zYoI7Yr4qkfwtVlz0dU+vmvPV2X23aAZI/dFUSvHQElnzF v5I5CoLNYxgorG+5T6ZW/0z2oWpLN7USpS8gCcIefrkefWBIkfq7r2OstvSxwIuPcZe7 +TpD+n12aniSSw2t4snMX6KJOmaKgrfhboERg+wAKiQgaLagBupTd8WKTn6clswsKirL KCWbsS0LESDVPnVrTrPZ+Gmw9fTBwPotmoEyqPi5tP2Fq8ZFfGbOideAN2uEXUfKkDCE lSEvVsKenxqNzvjReIFw7jD+w8uQVz0v9hvGB4RC/v2K7QD5rW8g+x27IyA3BNWvs73d kUAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680230160; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=86F+ceC1NW1bMTeg52u64nx73IS84oPBFUIyL2W5K6M=; b=RQngp1oIkBW57Nl4aWwvtmbQ5IylCezB7XQstXMXJyu89vbiqDQFkuKhgQYffvy8Sx KxB467MhgptGOdL1dFeUUKxg+wh8MjahX2wh7yxztQg34Q5G1LTLdG3L+SQajjGYOGKT TxsEM4UASdrKr4Hza6uZn5IzZ9/aUAGIUgc5aygwWW2dlOVPo6EOpGGdJBDeX2IJUr59 sjwOuI++C2msUAXZwru30hWeB2vtT7ccwGN19xESSm+d7gnL3tWb9WZhuz5AwCZMFFCD d3juc0K8TRnejnivqeXO6Jg/w0uHLV8PlYluelAXDH5Jk5PwHI3P9v1TPUkWU6KNYKSx 4SLg== X-Gm-Message-State: AAQBX9cVC2UrQ5LLAAFbVxn4JkDNsntmX2XdqAUyrAIeiVOvh9VARJbp pGysxtPoWeuZHXCnISSfZluRWhk6Rnt3fSFAb6k= X-Google-Smtp-Source: AKy350aKgrfTVw/QfsAHHp2YYh/+7lEJ+WauFDZne7LGSSWd/zBZAuKPR4JtHuRRyIYK8lX0m++i2c/Ig1SAz7XR+Ck= X-Received: by 2002:a17:902:c194:b0:1a2:87a2:c927 with SMTP id d20-20020a170902c19400b001a287a2c927mr1947891pld.12.1680230159857; Thu, 30 Mar 2023 19:35:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Fri, 31 Mar 2023 03:35:48 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/2] Support FDT library. To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "Lin, Benny" , "Gao, Liming" , "Liu, Zhiguang" , Sean Brogan , Michael Kubacki , Leif Lindholm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 31, 2023 at 12:32=E2=80=AFAM Kinney, Michael D wrote: > Appreciate the feedback. Agree that any libc API that is implemented in = a > wrapper should conform to the standard. > > > We also have a whole libc implementation in edk2-libc that seems to be > > permanently gathering dust until Intel touches it for Python purposes > > from time to time. So between crypto, libfdt, etc, could we try to > > unify things here a bit? > > edk2-libc to too large for FW components and it is out of date. > > Would you like to volunteer to lead a design and implementation that > is right-sized for FW modules and could be the one wrapper that works > for all current use cases and could be extended in the future as > needed to support additional use cases? Don=E2=80=99t need all of libc. = Just > enough to support the APIs used by the submodules used so far. > Mike, I wrote up a quick RFC patch for a bunch of libc bits that you needed in this case (BaseFdtLib and libfdt). It's very much a WIP and only supports GCC/clang. MSVC needs some support when it comes to limits.h (because of LP64 vs Windows's LLP64), but nothing too hard certainly. See https://edk2.groups.io/g/devel/topic/rfc_patch_1_1_mdepkg_add_a/9796583= 0?p=3D,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,97965830,previd%3D1680229= 851681438282,nextid%3D1680190220621190228&previd=3D1680229851681438282&next= id=3D1680190220621190228 Comments welcome. --=20 Pedro