From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174])
 by mx.groups.io with SMTP id smtpd.web10.103192.1674829792255135901
 for <devel@edk2.groups.io>;
 Fri, 27 Jan 2023 06:29:52 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@gmail.com header.s=20210112 header.b=RJHsxj2f;
 spf=pass (domain: gmail.com, ip: 209.85.210.174, mailfrom: pedro.falcato@gmail.com)
Received: by mail-pf1-f174.google.com with SMTP id 203so2051089pfx.6
        for <devel@edk2.groups.io>; Fri, 27 Jan 2023 06:29:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=CKPxABB67b+mK6OC9m2dHnnXZTww8DGFqJmzutHpCPE=;
        b=RJHsxj2fYBvztaWzJYnkWKyOm4TZCKSsv06xMP0oLgEY2Qeh/MOmDs6niCZQfdIFQr
         UCBii9lULJ7XJj+dpB8w36S8zpx06oI+Q0XiDMb/FDIM4jhpnYPWovqpOya8kE8vPbPd
         UjDMJhTXGJQEBtNxN7SAJ+7Pn0Slk5byGedEhQUkd2wmNZ2P1ux1NSHQVE6PlAg1tO+o
         xsQwAYxuGPe+OQiWLdsd6KxjdIOT7zEvhWMdLaKOFAhq34txeKwkXmf6FcrRUsCPqL0P
         rtPJMBDISvMnQTDrWwkYL+47PLJbP5qA1/vq8FCmswhMixasDZhetEuy+4Xp3+m6pRuj
         cCeQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=CKPxABB67b+mK6OC9m2dHnnXZTww8DGFqJmzutHpCPE=;
        b=AY0p5w6hlE7YW+i32+9bxau3aBske5+ZdowrLHEpXB/gVift6/lqOKZf6F9Y+LLXgz
         MGLUvUayZhF7rc3EChAJ3T5Qb28oA+5wUDjRWAjsOFlSdnDYFUohT1JJkBIjUUliMtBy
         J/JCyjEpc8x/wNClzX4z0sfiz1cLSFwBxJ97s+bZdkmiQ68GNMDEggqCE0Ysc9XDMRLy
         fxyX966Ib5xFtSmExbU2b1bDVhWddXUbubax34nBr3wYzIOs5w7tK1EFjvvkJuk+ctgk
         Yrpm4TSwS8efRDgA8LzGOW5O1CBbrgqAN1Lp2Btl3CO5y2U3bgBl5FZd2RDrJ5dSmKN2
         x/+Q==
X-Gm-Message-State: AFqh2krSETygJ1+CVye8Zb1JkcX4XBHkHCX/4C2gfS/qj/4julApWsqz
	uwnWzNtomp8jhuxqU6bAbObqYRYhnq3AJKWatC0=
X-Google-Smtp-Source: AMrXdXuGGPy8W9IuSpvo7G+aSxUftiwWq78zKbny/4WxF6Oy7OiFAXCs7qElMTt7vm4Kt/5VIEFmvxx0jpZJyL1W+rk=
X-Received: by 2002:a62:1c86:0:b0:58d:a84a:190b with SMTP id
 c128-20020a621c86000000b0058da84a190bmr4583584pfc.48.1674829791723; Fri, 27
 Jan 2023 06:29:51 -0800 (PST)
MIME-Version: 1.0
References: <20230127092945.94389-1-savvamtr@gmail.com> <20230127092945.94389-3-savvamtr@gmail.com>
 <72C59A93-6B86-4046-A408-6D63396C24B2@posteo.de>
In-Reply-To: <72C59A93-6B86-4046-A408-6D63396C24B2@posteo.de>
From: "Pedro Falcato" <pedro.falcato@gmail.com>
Date: Fri, 27 Jan 2023 14:29:40 +0000
Message-ID: <CAKbZUD2FbxOLzHX1drCO9sJMzypruzDBZm1JZbtVMFgrisXGVg@mail.gmail.com>
Subject: Re: [edk2-platforms][PATCH v3 02/11] Ext4Pkg: Fix incorrect checksum metadata feature check
To: =?UTF-8?Q?Marvin_H=C3=A4user?= <mhaeuser@posteo.de>
Cc: Savva Mitrofanov <savvamtr@gmail.com>, edk2-devel-groups-io <devel@edk2.groups.io>, 
	Vitaly Cheptsov <vit9696@protonmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 27, 2023 at 10:02 AM Marvin H=C3=A4user <mhaeuser@posteo.de> wr=
ote:
>
> On 27. Jan 2023, at 10:29, Savva Mitrofanov <savvamtr@gmail.com> wrote:
> >
> > Missing comparison !=3D 0 leads to broken logic condition.
>
> The actual issue appears to be FeaturesCompat vs FeaturesRoCompat (latter=
 is hidden by your usage of the macro). Checking for !=3D 0 is redundant (a=
lbeit required by the code style guideline for non-functional reasons). Ple=
ase confirm and update the commit message if you agree.

+1, the actual issue comes from using the wrong feature mask and not the !=
=3D 0.
If we get a v4, please update, else I can rewrite it myself.

Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>

--=20
Pedro