From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mx.groups.io with SMTP id smtpd.web10.102763.1674828807700101271 for ; Fri, 27 Jan 2023 06:13:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=jtL8nqc3; spf=pass (domain: gmail.com, ip: 209.85.214.174, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f174.google.com with SMTP id k18so5046575pll.5 for ; Fri, 27 Jan 2023 06:13:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KSLmiqixIEVwbaH+LPiYMpx64Eqkjh08fLJ5PSC7zD8=; b=jtL8nqc33oXzUwLqleKLFQMKxLFErt7awkV4yvSiMyBNDqR/vMbzib1N6XDfsD6MKQ TLmAG8nwCR1DK4zwj64/MfgjqSJXq8ppKeTyXtfXt9WMrVusKmSWGYIFt2JVQXV8up8d J+XePTRaTXrIJlaRLz78R2HtUMehOL/nvxHw3c4oreBUwhGIvcmN5nzAXLTeJ8EkDqXp RQ9vJ97aAFOpfs3o8Ue2mI7nAMS+BDkjy26alPe3Sb6H/mWW7BowIp7QrGp86xK/YxSk qleOtwjIechJXrv/ek8Wu/aCaCzjU3cUhS6iBsjhZwe317B8qLZnKyZDD9UMpcv/ifoL 47Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KSLmiqixIEVwbaH+LPiYMpx64Eqkjh08fLJ5PSC7zD8=; b=YF/Cfn4Z3hnq6IHXFV6t4dGVcEXdJgj8ORCSfHZBDzgCSH22YJJCXr8En8UbpgPUOj grUlR3tryNYq9Ki9KsCq8UGz+5xjVrF3C1vv8hgcrZVOUpgPFsHn/1jjNd5ieNq1d/uL 7QtbammC8yHebsbWE0R/jdLOlztQ5uT8hFrApfgDAekg0rZWnJSNYUdD62rNzi7gDIVZ K12fkKEU4BBbpRd/jKGPQYN6bNCFgJcjhG8LODwfX2AoYc24/oarm9zAw7CVPFVfoDfU QrcUGNDyPp3JBy5bNVpoHaEE1yVXpsxTRultKBb54ywfUOdvPvLK6P8K/ZaH/4TicZM3 EhlQ== X-Gm-Message-State: AO0yUKUNkT1X8OTnaSDFIOx8Tq3HtBJP9Rv1KjYiB7ldxkf5M3CoHSp4 +7dp+BUpqMtqQrmUob68mTSJM1iDetdFXAg3pl4kUbdEEoqQvQ== X-Google-Smtp-Source: AK7set9Sn6QoP8sjUQNX9txS6LhJ3qo9VmKWO9TUfcVsyGSSfc6MrL2NHoXxu1yAB7grdO9t8viWcdXwlAy0H4iW5qE= X-Received: by 2002:a17:90a:4897:b0:22c:13f5:3345 with SMTP id b23-20020a17090a489700b0022c13f53345mr1236591pjh.37.1674828807275; Fri, 27 Jan 2023 06:13:27 -0800 (PST) MIME-Version: 1.0 References: <20230127092945.94389-1-savvamtr@gmail.com> <20230127092945.94389-4-savvamtr@gmail.com> In-Reply-To: <20230127092945.94389-4-savvamtr@gmail.com> From: "Pedro Falcato" Date: Fri, 27 Jan 2023 14:13:16 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH v3 03/11] Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group To: Savva Mitrofanov Cc: devel@edk2.groups.io, =?UTF-8?Q?Marvin_H=C3=A4user?= , Vitaly Cheptsov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 27, 2023 at 9:29 AM Savva Mitrofanov wrote= : > > Superblock s_inodes_per_group field can't be zero, it leads to division > by zero in BlockGroup routine Ext4ReadInode > > Cc: Marvin H=C3=A4user > Cc: Pedro Falcato > Cc: Vitaly Cheptsov > Fixes: d9ceedca6c8f ("Ext4Pkg: Add Ext4Dxe driver.") > Signed-off-by: Savva Mitrofanov > --- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext= 4Dxe/Superblock.c > index 35dcf3c007c8..be3527e4d618 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c > @@ -243,6 +243,11 @@ Ext4OpenSuperblock ( > > DEBUG ((DEBUG_FS, "Read only =3D %u\n", Partition->ReadOnly)); > > + if (Sb->s_inodes_per_group =3D=3D 0) { > + DEBUG ((DEBUG_ERROR, "[ext4] Inodes per group can not be zero\n")); > + return EFI_VOLUME_CORRUPTED; > + } > + > Partition->BlockSize =3D (UINT32)LShiftU64 (1024, Sb->s_log_block_size= ); > > // The size of a block group can also be calculated as 8 * Partition->= BlockSize > -- > 2.39.0 > Reviewed-by: Pedro Falcato --=20 Pedro