From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7DAA3AC18C1 for ; Mon, 11 Dec 2023 15:09:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=R6bi6cny5bGQJKvuCO2JbMuEU3hPz0ZXC2METti2qWQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702307373; v=1; b=DnU8UOqJD2VY7yXwA4XItk9OkijHBGxrkHwikfHVW2MncWC4zcabjwaJpX9B8O3KKQ0gy7W7 VxXgsvK0tP+u6RNJxG1vkvCxPY4ur1Og/fDeCPMgUD7AtvZuj2MLzuWzdCG3CkKieiEBGy9UQO2 JcGr9/Oc5mrptF+yae3O07XU= X-Received: by 127.0.0.2 with SMTP id YicVYY7687511xGiNjDQAlYY; Mon, 11 Dec 2023 07:09:33 -0800 X-Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by mx.groups.io with SMTP id smtpd.web11.10577.1702307372649249873 for ; Mon, 11 Dec 2023 07:09:32 -0800 X-Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-46629ef4cc5so122676137.2 for ; Mon, 11 Dec 2023 07:09:32 -0800 (PST) X-Gm-Message-State: XJM8IxgJsH4Qv5V89vGeJf2mx7686176AA= X-Google-Smtp-Source: AGHT+IGyshj7fI1OjihE0h8BSK/g/8IEirkuYZ4qroLpG/BU9T5FB8P8eKFA2r5p4gOJJE5NUAKsfm4hpE+om9PA0Zg= X-Received: by 2002:a05:6122:2088:b0:495:bd61:a184 with SMTP id i8-20020a056122208800b00495bd61a184mr1506661vkd.2.1702307371392; Mon, 11 Dec 2023 07:09:31 -0800 (PST) MIME-Version: 1.0 References: <20231204082950.96914-1-dhaval@rivosinc.com> <20231204082950.96914-5-dhaval@rivosinc.com> In-Reply-To: From: "Pedro Falcato" Date: Mon, 11 Dec 2023 15:09:19 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH v9 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V To: devel@edk2.groups.io, sunilvl@ventanamicro.com Cc: Dhaval Sharma , Michael D Kinney , Liming Gao , Zhiguang Liu , Laszlo Ersek Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DnU8UOqJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Dec 11, 2023 at 1:12=E2=80=AFPM Sunil V L wrote: > > On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote: [...] > > nit: Can we pick a log style here? Like : > > In this case, "CacheOpCacheRange: Performing ...". It's just prettier > > and more greppable. > > My interpretation of this was removing __func__ and instead having some > > relevant text would make it more searchable. > > And it kind of did make sense to me. I know many places __func__ is use= d > > but this is just a perspective. > > > I think the comment meant to follow a standard logging format since > there was no ":" and a space in original change. I prefer __func__ over > this so that we don't need to update multiple lines in case function > name gets changed. I definitely meant that __func__ should not be used for this as well. You can't really search for an error message if you're doing gratuitous printf formatting for no reason. Linux even has a policy where user-facing strings (i.e logs) cannot get broken up, even if you run out of line width. PS: Dhaval, I gave you a bunch of feedback and you dropped me from CCs. Please don't do that, I completely lost track of this patch set :/ --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112305): https://edk2.groups.io/g/devel/message/112305 Mute This Topic: https://groups.io/mt/102967058/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-