From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mx.groups.io with SMTP id smtpd.web10.18427.1681229237054451702 for ; Tue, 11 Apr 2023 09:07:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=H5/MSpbB; spf=pass (domain: gmail.com, ip: 209.85.216.54, mailfrom: pedro.falcato@gmail.com) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2467761dfabso320521a91.3 for ; Tue, 11 Apr 2023 09:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681229236; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3G7QLlaeMaZ2etLGislUxSpmkz4DbGZOkpxQfJcNdeg=; b=H5/MSpbBbz+vWVRzS5RPfoDVpmTb/ai9jGJojZu7fhN1oR40L2Pnwq4VNGn+x3Oikf Ep9GdCiFbWr5t86p7KogYwKFX/Q6rvIMeHr/Tg4NWAL3uXrLy7fA6PcsZgqLPNS7874P GWnMQi2tgsIX+xfDy/nFpiOI5Eifd8tOHHe9fYHWqr7hyoXWocneX9joGpJauyoJ0Kdm KKDWirvJV1vxvrQ3RgXPGCs36+0fuFVy+JpTVUzIZdUqF3q0ZiZ+K2VNTVaiP3uEDT4n XfjhfHhCrTD8vDdFAOq7KgP9+sijiyxLb/RuF3Gd2B3G0zpazmqi6Ty8aqeqMad5SaIZ 5rlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681229236; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3G7QLlaeMaZ2etLGislUxSpmkz4DbGZOkpxQfJcNdeg=; b=Rzsd7uChDaftnoGXxEjI8LMPb7NccCQuLM1SzqcIYvQtDi94xUWBg5592OIEYBsYG7 zOsz/255W9kSVkiK72QPcNdxvPBmnZijL6AXXirqc3fUTZfvyh4yDbY8i9fBLhFq9DMW bJ/Um77A1RRrE8qh7jSXK8WJLHXBNC4YGA5Eeeq5dnTWoVg9pXbEQOUPACXyG/Q4iMZo YZDFLS2MAxIDxo7Ka/DzYEinkXqkCdeZehJ0gZ/YuXcM1qqqzJTz1VW8Y1N0Bget4gis VX+1G8wKOIYcQoIPD2Lidf8punqUzMuloqas4IhPjfDcQlygBIU5cdcij1R88v0PDzyr r4iQ== X-Gm-Message-State: AAQBX9czx9UqVRnuVqpOyd12fa2gCiFfOnsJQuRZuK6RQFF7ZmveKoYQ gm8DKJ4Cz5KiYeNrnwTZX9tFVuO8f7//dzGxHu8= X-Google-Smtp-Source: AKy350Z9RQq6iDsSl7yZO57dZi6/3nyJmEgBYsyaEqpGZ9HIB7YgIHll1v3pdxydUbv1FJLiRRG2p+lyYMbDMZwoaJQ= X-Received: by 2002:a05:6a00:13a2:b0:639:fed3:c57 with SMTP id t34-20020a056a0013a200b00639fed30c57mr2555581pfg.5.1681229236396; Tue, 11 Apr 2023 09:07:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Tue, 11 Apr 2023 17:07:05 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/2] Support FDT library. To: Lean Sheng Tan Cc: "Kinney, Michael D" , "Warkentin, Andrei" , "devel@edk2.groups.io" , "Lin, Benny" , "Gao, Liming" , "Liu, Zhiguang" , Sean Brogan , Michael Kubacki Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 11, 2023 at 2:20=E2=80=AFPM Lean Sheng Tan wrote: > > Thanks Mike for the proposal layout! > It sounds good to me :) > > Hi Pedro, > I went through the email chain again, basically these are 2 of your main = concerns (correct me if I'm wrong): > 1. a good idea to at least ditch that specific copy (current FDT in Embed= ded Pkg) for a git submodule. > 2. Rework to remove/reduce libc Implementation as there is a problem with= both libc fragments and compiler intrinsic fragments all over edk2. Should= unify standards between crypto, libfdt, etc, could we try here > > I guess Mike has provided a plan to answer your first question, and the 2= nd question would require a broader discussion with a few key owners. > > So it seems like we could get the current patchset from Benny Lin in for = now? Any minor clean up needed for the current patch? > No. 3. Lots of questions and comments on the actual patch set regarding the quality of the libc implementation. Which should be fixed, regardless of centralizing a libc implementation. Also questions on the FdtLib itself (why are we wrapping pure libfdt functions with FluffyIdentifierNames and SCARY_TYPEDEFS?). I also sent out an RFC for a central libc for GCC/clang based toolchains, which should cover the libc usage of libfdt. Asked for testing, got ignored. So a NAK from me, in its current state. --=20 Pedro