From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 10C05941D11 for ; Mon, 23 Oct 2023 21:05:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7Abu/7BW3RneG/ZrSzyF8r3CSQHiRe3rx6KIZxaU5+Q=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698095099; v=1; b=fjxTgyiC0lH0w9vP/A58jATnoP5c9BiGe3+JUI1LEoBojoOWdxBOQqDXRvRaE3ZSm8Ao3SQH C9OE18uOA8LLaXEddHFTDDKCDo7w3OK/NxzD5WSGnCVVVwwXw+N6YgX2BQlMSDNn2OKraA3LrHA m+2oKQ/8NKRbUXSqAhYaXfPs= X-Received: by 127.0.0.2 with SMTP id pzBBYY7687511xt6JtX0WOUo; Mon, 23 Oct 2023 14:04:59 -0700 X-Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by mx.groups.io with SMTP id smtpd.web11.3309.1698095098728940018 for ; Mon, 23 Oct 2023 14:04:58 -0700 X-Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-49d14708479so1655663e0c.2 for ; Mon, 23 Oct 2023 14:04:58 -0700 (PDT) X-Gm-Message-State: 8qPgGLdTCYDpz4cQSMdYVzAIx7686176AA= X-Google-Smtp-Source: AGHT+IFzepb+eSx8eHiLHOAMOMLZblXP6RNfP4y9BmDHuOziQzU7Tzc2q58h/S3jZ30krL3EomSucSvfUB0sUTwztm8= X-Received: by 2002:a1f:7d0f:0:b0:49a:bff1:23 with SMTP id y15-20020a1f7d0f000000b0049abff10023mr8495036vkc.5.1698095097636; Mon, 23 Oct 2023 14:04:57 -0700 (PDT) MIME-Version: 1.0 References: <20231023141732.152-1-nicklew@nvidia.com> In-Reply-To: <20231023141732.152-1-nicklew@nvidia.com> From: "Pedro Falcato" Date: Mon, 23 Oct 2023 22:04:46 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions. To: devel@edk2.groups.io, nicklew@nvidia.com Cc: Abner Chang , Igor Kulchytskyy , Nick Ramirez , Mike Maslenkin Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fjxTgyiC; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Oct 23, 2023 at 3:18=E2=80=AFPM Nickle Wang via groups.io wrote: > > There are two definitions for below functions in RedfishCrtLib.h. Create > this change to remote duplicated functions. > Function list: strcmp(), strncmp(), strncpy(), strcat(), strchr(), > strcasecmp(), strstr(), memcmp(), memset(), memcpy() and memchr(). > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > Cc: Mike Maslenkin > --- > RedfishPkg/Include/Library/RedfishCrtLib.h | 81 +--------------------- > 1 file changed, 1 insertion(+), 80 deletions(-) > > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Incl= ude/Library/RedfishCrtLib.h > index 23c6acfca33e..80f0e10de8e7 100644 > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h > @@ -3,6 +3,7 @@ > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. Can we take it easy with the copyright lines? This patch has literally no additions apart from this copyright line, how can someone ever claim copyright over this patch... --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109952): https://edk2.groups.io/g/devel/message/109952 Mute This Topic: https://groups.io/mt/102136148/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-