From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mx.groups.io with SMTP id smtpd.web12.15600.1663275738306796605 for ; Thu, 15 Sep 2022 14:02:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=J3m7Xaoi; spf=pass (domain: gmail.com, ip: 209.85.210.171, mailfrom: pedro.falcato@gmail.com) Received: by mail-pf1-f171.google.com with SMTP id l65so19250463pfl.8 for ; Thu, 15 Sep 2022 14:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=j/Em1eiK+2dTqoBH5YJ6p2lKqFxJO0vsfJYWRyCmSfs=; b=J3m7Xaoi6NueXabtCwzNnEjBNEeRg8FH4a/ICL6/x+UiBQzOIohUKW2r73X9LMXpOP HNQhpLpZ4cksruGpluhkTPQK+vLmLGRAa+f1G2EatQwHFUkA1J/473KU9UEZ4GEjQHRb cXCEYXYIR80aiRiv8Lh+ARWVV+I2PXFSO3K6a+fI8cMsLq9yCW/wAgq6VwARqbD0uP1f 1T4CQNFGomalZiQzst9IitsovKSbq7NaNPSWq7+yObH+lROGDR5I18lNasoiX4+scPdf AmjsgbcIuwh5fAdfwHCfuAwb9+QchwVgY5YBsRKSxiZ2ekqyqNVHjQbVc0F4A5JqhvK+ l5+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=j/Em1eiK+2dTqoBH5YJ6p2lKqFxJO0vsfJYWRyCmSfs=; b=ViyAl85vBEuvnjujDi1rJsTDQca8+SmCsWdqREbLeN8cFuY9Jg8Wyo9eWtsFaMNeOx hBntV9kPrwwieqKIFejLLPzOOjWuR7+U2griH29+Cip2WHA3FvLBuJoYAhFwptrKRZGL Q2H15Uoa+5YoCpIW1CqwTmBlpLSA+Kx6T4NEw+I9W7p2SXyp8Bb/I3wXl0NNBjgTYpyg 9Vd+Rfx6M9VWvOnLdU3CSAG2/g82oDUpwbH88v9fxG2iNa5jXjm1KFfM97oC3F0ysdrQ 1Ecnkb1ScHWMaZchvNkurUY+Fzo2cdbHnTKz9WmIF44tgFA7Mz0VoQFa+XEL47PAFHBS NJwg== X-Gm-Message-State: ACrzQf20KkxD4cUYoZ3skbOazDLH8Mu+aaxkOhlzxps/f/hw2owIDPyF AOclc7mOL5UeCCcJFY9gwjjIwCAs6mc0v6tp+iw= X-Google-Smtp-Source: AMsMyM7BWO1rLj1jn+PrivPtbatwcaRZpVCNX0dFiIMiBsncJKxDfmU5LQESCZ3+9+1vOR08CeGr0aMS7rYLU++ZRuo= X-Received: by 2002:a05:6a00:27a0:b0:548:2664:8bd1 with SMTP id bd32-20020a056a0027a000b0054826648bd1mr1957544pfb.14.1663275736318; Thu, 15 Sep 2022 14:02:16 -0700 (PDT) MIME-Version: 1.0 References: <20220907140213.13286-1-savvamtr@gmail.com> In-Reply-To: From: "Pedro Falcato" Date: Thu, 15 Sep 2022 22:02:04 +0100 Message-ID: Subject: Re: [edk2-platforms][PATCH v5 0/2] Ext4Pkg: Add Symbolic Links support To: Savva Mitrofanov Cc: edk2-devel-groups-io , =?UTF-8?Q?Marvin_H=C3=A4user?= , Vitaly Cheptsov Content-Type: multipart/alternative; boundary="0000000000006d4a7505e8bd8fdf" --0000000000006d4a7505e8bd8fdf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Pushed as e81432f and 76fc44f. Thanks! On Thu, Sep 15, 2022 at 10:00 PM Pedro Falcato wrote: > Series-Reviewed-by: Pedro Falcato > > On Wed, Sep 7, 2022 at 3:02 PM Savva Mitrofanov > wrote: > >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3677 >> >> Hi all, >> >> In the fifth version I corrected remarks from Pedro Falcato and Marvin >> H=C3=A4user. >> I moved symlink procedures into independent C file, corrected code style >> like >> debug messages macros and etc. >> >> This patchset adds symbolic links support with simple recursion >> protection based >> on symbolic link nest level limitation, also I included patch which adds >> BASE_CR >> to extract EXT4_FILE private structure to prevent possible code >> corruption caused >> by structure changes and rearrangements in future. >> >> REF: >> https://github.com/savvamitrofanov/edk2-platforms/tree/ext4pkg_symlink_s= upport >> >> Cc: Marvin H=C3=A4user >> Cc: Pedro Falcato >> Cc: Vitaly Cheptsov >> >> Savva Mitrofanov (2): >> Ext4Pkg: Add symbolic links support >> Ext4Pkg: Add base containing record macro for EXT4_FILE >> >> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 1 + >> Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 13 +- >> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 74 +++++- >> Features/Ext4Pkg/Ext4Dxe/File.c | 179 +++++++++++--- >> Features/Ext4Pkg/Ext4Dxe/Inode.c | 15 ++ >> Features/Ext4Pkg/Ext4Dxe/Symlink.c | 261 ++++++++++++++++++++ >> 6 files changed, 499 insertions(+), 44 deletions(-) >> create mode 100644 Features/Ext4Pkg/Ext4Dxe/Symlink.c >> >> -- >> 2.37.3 >> >> > > -- > Pedro Falcato > --=20 Pedro Falcato --0000000000006d4a7505e8bd8fdf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Pushed as e81432f and 76fc44f.
Thanks!
=

= On Thu, Sep 15, 2022 at 10:00 PM Pedro Falcato <pedro.falcato@gmail.com> wrote:
Series-Reviewed-= by: Pedro Falcato <pedro.falcato@gmail.com>

On Wed, Sep 7, 2022 at 3:02 PM S= avva Mitrofanov <savvamtr@gmail.com> wrote:
BZ: https://bugzilla.tianoco= re.org/show_bug.cgi?id=3D3677

Hi all,

In the fifth version I corrected remarks from Pedro Falcato and Marvin H=C3= =A4user.
I moved symlink procedures into independent C file, corrected code style li= ke
debug messages macros and etc.

This patchset adds symbolic links support with simple recursion protection = based
on symbolic link nest level limitation, also I included patch which adds BA= SE_CR
to extract EXT4_FILE private structure to prevent possible code corruption = caused
by structure changes and rearrangements in future.

REF: https://github.co= m/savvamitrofanov/edk2-platforms/tree/ext4pkg_symlink_support

Cc: Marvin H=C3=A4user <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>

Savva Mitrofanov (2):
=C2=A0 Ext4Pkg: Add symbolic links support
=C2=A0 Ext4Pkg: Add base containing record macro for EXT4_FILE

=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf |=C2=A0 =C2=A01 +
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h=C2=A0 |=C2=A0 13 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h=C2=A0 =C2=A0|=C2=A0 74 +++++-
=C2=A0Features/Ext4Pkg/Ext4Dxe/File.c=C2=A0 =C2=A0 =C2=A0 | 179 +++++++++++= ---
=C2=A0Features/Ext4Pkg/Ext4Dxe/Inode.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 15 ++
=C2=A0Features/Ext4Pkg/Ext4Dxe/Symlink.c=C2=A0 =C2=A0| 261 ++++++++++++++++= ++++
=C2=A06 files changed, 499 insertions(+), 44 deletions(-)
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Dxe/Symlink.c

--
2.37.3



--
Pedro Falcato


--
Pedro Falcato
--0000000000006d4a7505e8bd8fdf--